[PR PATCH] New package: LACT-0.5.4

[PR PATCH] New package: LACT-0.5.4

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

There is a new pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages LACT-new
https://github.com/void-linux/void-packages/pull/50027

New package: LACT-0.5.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - aarch64 (cross)
  - aarch64-musl (cross)



A patch file from https://github.com/void-linux/void-packages/pull/50027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-LACT-new-50027.patch --]
[-- Type: text/x-diff, Size: 2962 bytes --]

From 85c963fc0de286e5fd7a8816ce18f188f6e4d60d Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Wed, 24 Apr 2024 22:32:37 -0400
Subject: [PATCH] New package: LACT-0.5.4

---
 srcpkgs/LACT/files/lact/run            |  3 +++
 srcpkgs/LACT/patches/malloc_trim.patch | 17 +++++++++++++++
 srcpkgs/LACT/template                  | 29 ++++++++++++++++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100755 srcpkgs/LACT/files/lact/run
 create mode 100644 srcpkgs/LACT/patches/malloc_trim.patch
 create mode 100644 srcpkgs/LACT/template

diff --git a/srcpkgs/LACT/files/lact/run b/srcpkgs/LACT/files/lact/run
new file mode 100755
index 00000000000000..74e0a5ebbd8539
--- /dev/null
+++ b/srcpkgs/LACT/files/lact/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -n -10 lact daemon
diff --git a/srcpkgs/LACT/patches/malloc_trim.patch b/srcpkgs/LACT/patches/malloc_trim.patch
new file mode 100644
index 00000000000000..020683ea3749a7
--- /dev/null
+++ b/srcpkgs/LACT/patches/malloc_trim.patch
@@ -0,0 +1,17 @@
+diff --git a/lact-daemon/src/server/handler.rs b/lact-daemon/src/server/handler.rs
+index 93dc86c..0ef85fd 100644
+--- a/lact-daemon/src/server/handler.rs
++++ b/lact-daemon/src/server/handler.rs
+@@ -107,12 +107,6 @@ impl<'a> Handler {
+         };
+         handler.apply_current_config().await;
+ 
+-        // Eagerly release memory
+-        // `load_controllers` allocates and deallocates the entire PCI ID database,
+-        // this tells the os to release it right away, lowering measured memory usage (the actual usage is low regardless as it was already deallocated)
+-        unsafe {
+-            libc::malloc_trim(0);
+-        }
+ 
+         Ok(handler)
+     }
diff --git a/srcpkgs/LACT/template b/srcpkgs/LACT/template
new file mode 100644
index 00000000000000..52ca8d05742abe
--- /dev/null
+++ b/srcpkgs/LACT/template
@@ -0,0 +1,29 @@
+# Template file for 'LACT'
+pkgname=LACT
+version=0.5.4
+revision=1
+archs="x86_64* aarch64*"
+build_style=cargo
+configure_args="--features=adw"
+hostmakedepends="pkg-config blueprint-compiler libadwaita-devel"
+makedepends="libadwaita-devel"
+short_desc="Linux AMDGPU Control Application"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="MIT"
+homepage="https://github.com/ilya-zlobintsev/LACT"
+distfiles="https://github.com/ilya-zlobintsev/LACT/archive/refs/tags/v${version}.tar.gz"
+checksum=ce55f19dab2cb3616b404fc53feb381ee1e10e948bed65c7c33dc3b361685891
+
+do_install() {
+
+	vsv lact
+
+	vbin target/$RUST_TARGET/release/lact
+
+	vinstall res/lactd.service                644 usr/lib/systemd/system/lactd.service
+	vinstall res/io.github.lact-linux.desktop 644 usr/share/applications/io.github.lact-linux.desktop
+	vinstall res/io.github.lact-linux.png     644 usr/share/pixmaps/io.github.lact-linux.png
+	vinstall res/io.github.lact-linux.svg     644 usr/share/icons/hicolor/scalable/apps/io.github.lact-linux.svg
+
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: LACT-0.5.4

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/50027#discussion_r1578781338

Comment:
use a nice value of -10 because that is what's used in the sample systemd service

Re: [PR REVIEW] New package: LACT-0.5.4

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New review comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/50027#discussion_r1578782842

Comment:
Uses an AMDGPU cargo crate which only compiles on 64bit

Don't think this matters, since using a modern amd gpu on 32bit arm seems extemely unlikely, but not working on i686 is unfortuneate.

Re: [PR REVIEW] New package: LACT-0.5.4

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/50027#discussion_r1578781599

Comment:
musl does not have `malloc_trim`

Re: [PR PATCH] [Updated] New package: LACT-0.5.4

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages LACT-new
https://github.com/void-linux/void-packages/pull/50027

New package: LACT-0.5.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - aarch64 (cross)
  - aarch64-musl (cross)



A patch file from https://github.com/void-linux/void-packages/pull/50027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-LACT-new-50027.patch --]
[-- Type: text/x-diff, Size: 3084 bytes --]

From a8cc22d9f39bd51509f9cbf8ac8b539f0698dfc5 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Wed, 24 Apr 2024 22:32:37 -0400
Subject: [PATCH] New package: LACT-0.5.4

---
 srcpkgs/LACT/files/lact/run            |  3 +++
 srcpkgs/LACT/patches/malloc_trim.patch | 17 ++++++++++++++
 srcpkgs/LACT/template                  | 31 ++++++++++++++++++++++++++
 3 files changed, 51 insertions(+)
 create mode 100755 srcpkgs/LACT/files/lact/run
 create mode 100644 srcpkgs/LACT/patches/malloc_trim.patch
 create mode 100644 srcpkgs/LACT/template

diff --git a/srcpkgs/LACT/files/lact/run b/srcpkgs/LACT/files/lact/run
new file mode 100755
index 00000000000000..74e0a5ebbd8539
--- /dev/null
+++ b/srcpkgs/LACT/files/lact/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -n -10 lact daemon
diff --git a/srcpkgs/LACT/patches/malloc_trim.patch b/srcpkgs/LACT/patches/malloc_trim.patch
new file mode 100644
index 00000000000000..020683ea3749a7
--- /dev/null
+++ b/srcpkgs/LACT/patches/malloc_trim.patch
@@ -0,0 +1,17 @@
+diff --git a/lact-daemon/src/server/handler.rs b/lact-daemon/src/server/handler.rs
+index 93dc86c..0ef85fd 100644
+--- a/lact-daemon/src/server/handler.rs
++++ b/lact-daemon/src/server/handler.rs
+@@ -107,12 +107,6 @@ impl<'a> Handler {
+         };
+         handler.apply_current_config().await;
+ 
+-        // Eagerly release memory
+-        // `load_controllers` allocates and deallocates the entire PCI ID database,
+-        // this tells the os to release it right away, lowering measured memory usage (the actual usage is low regardless as it was already deallocated)
+-        unsafe {
+-            libc::malloc_trim(0);
+-        }
+ 
+         Ok(handler)
+     }
diff --git a/srcpkgs/LACT/template b/srcpkgs/LACT/template
new file mode 100644
index 00000000000000..ced7dd00cdddf9
--- /dev/null
+++ b/srcpkgs/LACT/template
@@ -0,0 +1,31 @@
+# Template file for 'LACT'
+pkgname=LACT
+version=0.5.4
+revision=1
+# only builds on 64bit
+archs="x86_64* aarch64*"
+build_style=cargo
+configure_args="--features=adw"
+make_check_args="-- --skip app::root_stack::thermals_page::fan_curve_frame::tests::set_get_curve"
+hostmakedepends="pkg-config blueprint-compiler libadwaita-devel"
+makedepends="libadwaita-devel"
+short_desc="Linux AMDGPU Control Application"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="MIT"
+homepage="https://github.com/ilya-zlobintsev/LACT"
+distfiles="https://github.com/ilya-zlobintsev/LACT/archive/refs/tags/v${version}.tar.gz"
+checksum=ce55f19dab2cb3616b404fc53feb381ee1e10e948bed65c7c33dc3b361685891
+
+do_install() {
+
+	vsv lact
+
+	vbin target/$RUST_TARGET/release/lact
+
+	vinstall res/lactd.service                644 usr/lib/systemd/system/lactd.service
+	vinstall res/io.github.lact-linux.desktop 644 usr/share/applications/io.github.lact-linux.desktop
+	vinstall res/io.github.lact-linux.png     644 usr/share/pixmaps/io.github.lact-linux.png
+	vinstall res/io.github.lact-linux.svg     644 usr/share/icons/hicolor/scalable/apps/io.github.lact-linux.svg
+
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: LACT-0.5.4

[meator]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by meator on void-packages repository

https://github.com/void-linux/void-packages/pull/50027#discussion_r1578946142

Comment:
It might be worth considering applying this patch only on musl and leaving the code intact on glibc.

Re: [PR PATCH] [Updated] New package: LACT-0.5.4

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages LACT-new
https://github.com/void-linux/void-packages/pull/50027

New package: LACT-0.5.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - aarch64 (cross)
  - aarch64-musl (cross)



A patch file from https://github.com/void-linux/void-packages/pull/50027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-LACT-new-50027.patch --]
[-- Type: text/x-diff, Size: 3040 bytes --]

From cf8f2cba5943a4e5822812ad1a4174bef8e05516 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Wed, 24 Apr 2024 22:32:37 -0400
Subject: [PATCH] New package: LACT-0.5.4

---
 srcpkgs/LACT/files/lact/run            |  3 +++
 srcpkgs/LACT/patches/malloc_trim.patch | 17 +++++++++++++++
 srcpkgs/LACT/template                  | 30 ++++++++++++++++++++++++++
 3 files changed, 50 insertions(+)
 create mode 100755 srcpkgs/LACT/files/lact/run
 create mode 100644 srcpkgs/LACT/patches/malloc_trim.patch
 create mode 100644 srcpkgs/LACT/template

diff --git a/srcpkgs/LACT/files/lact/run b/srcpkgs/LACT/files/lact/run
new file mode 100755
index 00000000000000..74e0a5ebbd8539
--- /dev/null
+++ b/srcpkgs/LACT/files/lact/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -n -10 lact daemon
diff --git a/srcpkgs/LACT/patches/malloc_trim.patch b/srcpkgs/LACT/patches/malloc_trim.patch
new file mode 100644
index 00000000000000..020683ea3749a7
--- /dev/null
+++ b/srcpkgs/LACT/patches/malloc_trim.patch
@@ -0,0 +1,17 @@
+diff --git a/lact-daemon/src/server/handler.rs b/lact-daemon/src/server/handler.rs
+index 93dc86c..0ef85fd 100644
+--- a/lact-daemon/src/server/handler.rs
++++ b/lact-daemon/src/server/handler.rs
+@@ -107,12 +107,6 @@ impl<'a> Handler {
+         };
+         handler.apply_current_config().await;
+ 
+-        // Eagerly release memory
+-        // `load_controllers` allocates and deallocates the entire PCI ID database,
+-        // this tells the os to release it right away, lowering measured memory usage (the actual usage is low regardless as it was already deallocated)
+-        unsafe {
+-            libc::malloc_trim(0);
+-        }
+ 
+         Ok(handler)
+     }
diff --git a/srcpkgs/LACT/template b/srcpkgs/LACT/template
new file mode 100644
index 00000000000000..a0ad54d7599a3e
--- /dev/null
+++ b/srcpkgs/LACT/template
@@ -0,0 +1,30 @@
+# Template file for 'LACT'
+pkgname=LACT
+version=0.5.4
+revision=1
+# only builds on 64bit
+archs="x86_64* aarch64*"
+build_style=cargo
+make_check_args="-- --skip app::root_stack::thermals_page::fan_curve_frame::tests::set_get_curve"
+hostmakedepends="pkg-config blueprint-compiler gtk4-devel"
+makedepends="gtk4-devel"
+short_desc="Linux AMDGPU Control Application"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="MIT"
+homepage="https://github.com/ilya-zlobintsev/LACT"
+distfiles="https://github.com/ilya-zlobintsev/LACT/archive/refs/tags/v${version}.tar.gz"
+checksum=ce55f19dab2cb3616b404fc53feb381ee1e10e948bed65c7c33dc3b361685891
+
+do_install() {
+
+	vsv lact
+
+	vbin target/$RUST_TARGET/release/lact
+
+	vinstall res/lactd.service                644 usr/lib/systemd/system/lactd.service
+	vinstall res/io.github.lact-linux.desktop 644 usr/share/applications/io.github.lact-linux.desktop
+	vinstall res/io.github.lact-linux.png     644 usr/share/pixmaps/io.github.lact-linux.png
+	vinstall res/io.github.lact-linux.svg     644 usr/share/icons/hicolor/scalable/apps/io.github.lact-linux.svg
+
+	vlicense LICENSE
+}