Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] vifm: update to 0.13, adopt.
@ 2024-05-10 22:53 jpnt
  2024-05-11  2:40 ` [PR REVIEW] " classabbyamp
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: jpnt @ 2024-05-10 22:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

There is a new pull request by jpnt against master on the void-packages repository

https://github.com/jpnt/void-packages vifm-0.13
https://github.com/void-linux/void-packages/pull/50271

vifm: update to 0.13, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->

<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
-->


A patch file from https://github.com/void-linux/void-packages/pull/50271.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vifm-0.13-50271.patch --]
[-- Type: text/x-diff, Size: 2958 bytes --]

From 961bfb67222a943b8a23a25a1bf3893f40b70fe9 Mon Sep 17 00:00:00 2001
From: Joao Pinto <joaopintojpgp@gmail.com>
Date: Fri, 10 May 2024 23:50:40 +0100
Subject: [PATCH] vifm: update to 0.13, adopt.

---
 .../vifm/patches/disable-failed-tests.patch   | 38 -------------------
 srcpkgs/vifm/template                         |  8 ++--
 2 files changed, 4 insertions(+), 42 deletions(-)
 delete mode 100644 srcpkgs/vifm/patches/disable-failed-tests.patch

diff --git a/srcpkgs/vifm/patches/disable-failed-tests.patch b/srcpkgs/vifm/patches/disable-failed-tests.patch
deleted file mode 100644
index f674a4be66d825..00000000000000
--- a/srcpkgs/vifm/patches/disable-failed-tests.patch
+++ /dev/null
@@ -1,38 +0,0 @@
-diff --git tests/Makefile tests/Makefile
-index 1419a4edd..a213d70ef 100644
---- a/tests/Makefile
-+++ b/tests/Makefile
-@@ -67,14 +67,14 @@ B ?=
- BUILD := $(B)bin/build/$(BINSUBDIR)
- 
- # engine
--suites += abbrevs autocmds cmds commands completion keys options parsing
-+suites += abbrevs autocmds cmds completion keys options parsing
- suites += text_buffer variables
- # io
- suites += ioeta ionotif iop ior
- # ui
- suites += colmgr column_view viewcolumns_parser
- # everything else
--suites += bmarks env escape fileops filetype filter lua misc undo utils
-+suites += bmarks env escape fileops filetype filter undo utils
- 
- # these are built, but not automatically executed
- apps := fuzz regs_shmem_app
-diff --git tests/fileops/chown.c tests/fileops/chown.c
-index ef7b1a405..cd2c33388 100644
---- a/tests/fileops/chown.c
-+++ b/tests/fileops/chown.c
-@@ -65,12 +65,10 @@ TEST(file_group_is_changed, IF(has_more_than_one_group))
- 	mark_selection_or_current(curr_view);
- 	fops_chown(0, 1, 0, gid1);
- 	assert_success(os_stat("dir/chown-me", &s));
--	assert_true(s.st_gid == gid1);
- 
- 	mark_selection_or_current(curr_view);
- 	fops_chown(0, 1, 0, gid2);
- 	assert_success(os_stat("dir/chown-me", &s));
--	assert_true(s.st_gid == gid2);
- 
- 	assert_success(unlink("dir/chown-me"));
- 	assert_success(rmdir("dir"));
diff --git a/srcpkgs/vifm/template b/srcpkgs/vifm/template
index 67cc901ec943cc..aa89d36e62f818 100644
--- a/srcpkgs/vifm/template
+++ b/srcpkgs/vifm/template
@@ -1,18 +1,18 @@
 # Template file for 'vifm'
 pkgname=vifm
-version=0.12
+version=0.13
 revision=1
 build_style=gnu-configure
 configure_args="--without-gtk"
 hostmakedepends="mdocml"
-makedepends="ncurses-devel file-devel"
+makedepends="ncurses-devel file-devel perl"
 depends="desktop-file-utils"
 short_desc="Ncurses-based file manager with vi-like keybindings"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="João Pinto <joaopintojpgp@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://vifm.info/"
 distfiles="${SOURCEFORGE_SITE}/vifm/vifm-${version}.tar.bz2"
-checksum=33a9618f32b35b5b8c64483884f9ad09963ca8465b2935def79159028e27b2c0
+checksum=0d9293749a794076ade967ecdc47d141d85e450370594765391bdf1a9bd45075
 
 CFLAGS="-fcommon"
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] vifm: update to 0.13, adopt.
  2024-05-10 22:53 [PR PATCH] vifm: update to 0.13, adopt jpnt
@ 2024-05-11  2:40 ` classabbyamp
  2024-05-11  2:40 ` classabbyamp
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-11  2:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50271#discussion_r1597338027

Comment:
we'd prefer package get adopted by established contributors. I encourage you to keep track of this package and continue making contributions, but please don't change the maintainer at this time

https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#adopting-a-template

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] vifm: update to 0.13, adopt.
  2024-05-10 22:53 [PR PATCH] vifm: update to 0.13, adopt jpnt
  2024-05-11  2:40 ` [PR REVIEW] " classabbyamp
@ 2024-05-11  2:40 ` classabbyamp
  2024-05-11 17:24 ` jpnt
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-11  2:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50271#discussion_r1597338027

Comment:
we'd prefer packages get adopted by established contributors. I encourage you to keep track of this package and continue making contributions, but please don't change the maintainer at this time

https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#adopting-a-template

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] vifm: update to 0.13, adopt.
  2024-05-10 22:53 [PR PATCH] vifm: update to 0.13, adopt jpnt
  2024-05-11  2:40 ` [PR REVIEW] " classabbyamp
  2024-05-11  2:40 ` classabbyamp
@ 2024-05-11 17:24 ` jpnt
  2024-05-20  1:26 ` classabbyamp
  2024-05-20  1:26 ` [PR PATCH] [Closed]: " classabbyamp
  4 siblings, 0 replies; 6+ messages in thread
From: jpnt @ 2024-05-11 17:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New review comment by jpnt on void-packages repository

https://github.com/void-linux/void-packages/pull/50271#discussion_r1597481942

Comment:
Ok very well, I will have to see how I can get this to build this on musl and arm before commiting again.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: vifm: update to 0.13, adopt.
  2024-05-10 22:53 [PR PATCH] vifm: update to 0.13, adopt jpnt
                   ` (3 preceding siblings ...)
  2024-05-20  1:26 ` classabbyamp
@ 2024-05-20  1:26 ` classabbyamp
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-20  1:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

There's a closed pull request on the void-packages repository

vifm: update to 0.13, adopt.
https://github.com/void-linux/void-packages/pull/50271

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: vifm: update to 0.13, adopt.
  2024-05-10 22:53 [PR PATCH] vifm: update to 0.13, adopt jpnt
                   ` (2 preceding siblings ...)
  2024-05-11 17:24 ` jpnt
@ 2024-05-20  1:26 ` classabbyamp
  2024-05-20  1:26 ` [PR PATCH] [Closed]: " classabbyamp
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-05-20  1:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50271#issuecomment-2119508492

Comment:
https://github.com/void-linux/void-packages/pull/50422

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-05-20  1:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-10 22:53 [PR PATCH] vifm: update to 0.13, adopt jpnt
2024-05-11  2:40 ` [PR REVIEW] " classabbyamp
2024-05-11  2:40 ` classabbyamp
2024-05-11 17:24 ` jpnt
2024-05-20  1:26 ` classabbyamp
2024-05-20  1:26 ` [PR PATCH] [Closed]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).