[PR PATCH] build-style/go: use XBPS_MAKEJOBS to control parallelism

[PR PATCH] build-style/go: use XBPS_MAKEJOBS to control parallelism

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages gojobs
https://github.com/void-linux/void-packages/pull/12538

build-style/go: use XBPS_MAKEJOBS to control parallelism
None

A patch file from https://github.com/void-linux/void-packages/pull/12538.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gojobs-12538.patch --]
[-- Type: application/text/x-diff, Size: 2112 bytes --]

From 01acf3798c41c632c733f9972ed245b0ff000a6a Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Tue, 18 Jun 2019 19:37:27 -0700
Subject: [PATCH] build-style/go: use XBPS_MAKEJOBS to control parallelism

---
 Manual.md                | 7 ++++++-
 common/build-style/go.sh | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Manual.md b/Manual.md
index ec5206bba58..7f6f23de59e 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1460,7 +1460,7 @@ Go packages should be built with the `go` build style, if possible.
 The `go` build style takes care of downloading Go dependencies and
 setting up cross compilation.
 
-The following variables influence how Go packages are built:
+The following template variables influence how Go packages are built:
 
 - `go_import_path`: The import path of the package included in the
   distfile, as it would be used with `go get`. For example, GitHub's
@@ -1479,6 +1479,11 @@ The following variables influence how Go packages are built:
   accepted by `go build -mod MODE`.  Defaults to `vendor` if there's
   a vendor directory, otherwise `default`.
 
+The following environment variables influence how Go packages are built:
+
+- `XBPS_MAKEJOBS`: Value passed to the `-p` flag of `go install`, to
+  control the parallelism of the Go compiler.
+
 Occasionally it is necessary to perform operations from within the Go
 source tree.  This is usually needed by programs using go-bindata or
 otherwise preping some assets.  If possible do this in pre_build().
diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index 98f95bea2e5..5242a446a15 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -33,7 +33,7 @@ do_build() {
 			# default behavior.
 			go_mod_mode=
 		fi
-		go install -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
+		go install -p "$XBPS_MAKEJOBS" -mod="${go_mod_mode}" -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}
 	else
 		# Otherwise, build using GOPATH
 		go get -x -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${go_package}

Re: build-style/go: use XBPS_MAKEJOBS to control parallelism

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/12538#issuecomment-503389233
Comment:
@the-maldridge not sure if you want to gosmoke this or what

Re: build-style/go: use XBPS_MAKEJOBS to control parallelism

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/12538#issuecomment-503389626
Comment:
This looks okay, I'd rather merge this though with a change that also fixes everywhere that we've hacked in a parallelism disable.  I don't think we need to gosmoke this, it should be reasonably safe.

Re: [PR PATCH] [Merged]: build-style/go: use XBPS_MAKEJOBS to control parallelism

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

There's a merged pull request on the void-packages repository

build-style/go: use XBPS_MAKEJOBS to control parallelism
https://github.com/void-linux/void-packages/pull/12538
Description: None

Re: build-style/go: use XBPS_MAKEJOBS to control parallelism

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/12538#issuecomment-505601792
Comment:
@xtraeme please do not merge changes that still have open discussions.

Re: build-style/go: use XBPS_MAKEJOBS to control parallelism

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/12538#issuecomment-505608389
Comment:
what packages could take advantage of / test this?

Re: build-style/go: use XBPS_MAKEJOBS to control parallelism

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/12538#issuecomment-505623295
Comment:
This has been reverted. I thought the conversation was resolved.