[PR PATCH] vscode: update to 1.35.1.

[PR PATCH] vscode: update to 1.35.1.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

There is a new pull request by AluisioASG against master on the void-packages repository

https://github.com/AluisioASG/void-packages vscode-1.35.1
https://github.com/void-linux/void-packages/pull/12654

vscode: update to 1.35.1.
[ci skip]

Included is a fix for the current breakage (courtesy of https://github.com/nodejs/node-gyp/issues/1457#issuecomment-395490546).

I can also cross-build it for i686 on my machine. Can we see if it works again on the buildserver?

A patch file from https://github.com/void-linux/void-packages/pull/12654.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-1.35.1-12654.patch --]
[-- Type: application/text/x-diff, Size: 1789 bytes --]

From 5f3cff37be5ca3a948d9d468d9e591176e7b1c9b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alu=C3=ADsio=20Augusto=20Silva=20Gon=C3=A7alves?=
 <aluisio@aasg.name>
Date: Mon, 24 Jun 2019 11:19:18 -0300
Subject: [PATCH] vscode: update to 1.35.1.

[ci skip]
---
 srcpkgs/vscode/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index 2b8093f5d8d..786394eaefa 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,6 +1,6 @@
 # Template file for 'vscode'
 pkgname=vscode
-version=1.35.0
+version=1.35.1
 revision=1
 hostmakedepends="pkg-config python nodejs-lts yarn"
 makedepends="libxkbfile-devel libsecret-devel"
@@ -10,7 +10,7 @@ maintainer="shizonic <realtiaz@gmail.com>"
 license="MIT"
 homepage="https://code.visualstudio.com/"
 distfiles="https://github.com/Microsoft/vscode/archive/${version}.tar.gz"
-checksum=8bbf959691f6bc20e787c1aa26fb8331462e74f83e861fbe6632f2de6a1bb099
+checksum=6a5bab018f35727897140d410a3d0ebaa640d6c75ee8053a1cd5e02ece5714e9
 patch_args="-Np1"
 
 # Due to electron
@@ -22,8 +22,6 @@ nostrip_files="code-oss"
 # change this number if it still doesn't work for your system.
 _mem_limit="--max_old_space_size=4095"
 
-broken="https://build.voidlinux.org/builders/x86_64_builder/builds/18087/steps/shell_3/logs/stdio"
-
 case "$XBPS_TARGET_MACHINE" in
 	i686)   broken="https://build.voidlinux.org/builders/i686_builder/builds/10486/steps/shell_3/logs/stdio"
 		    _ARCH="ia32";;
@@ -37,6 +35,8 @@ pre_build() {
 
 do_build() {
 	export NODE_OPTIONS="${_mem_limit}"
+	# Remove once nodejs-lts >= 10; see node-gyp issue 1457.
+	export npm_config_build_v8_with_gn="false"
 	yarn install --ignore-engines --arch=${_ARCH}
 	yarn run gulp vscode-linux-${_ARCH}-min
 }

Re: [PR PATCH] [Merged]: vscode: update to 1.35.1.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

There's a merged pull request on the void-packages repository

vscode: update to 1.35.1.
https://github.com/void-linux/void-packages/pull/12654
Description: [ci skip]

Included is a fix for the current breakage (courtesy of https://github.com/nodejs/node-gyp/issues/1457#issuecomment-395490546).

I can also cross-build it for i686 on my machine. Can we see if it works again on the buildserver?