[PR PATCH] linux5.2: Make some things modules.

[PR PATCH] linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

There is a new pull request by thomas-t-w against master on the void-packages repository

https://github.com/thomas-t-w/void-packages linux-changes
https://github.com/void-linux/void-packages/pull/13090

linux5.2: Make some things modules.
I have a laptop that requires i8042 to be unloaded upon suspend. Some people don't have nvme drives.

A patch file from https://github.com/void-linux/void-packages/pull/13090.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-linux-changes-13090.patch --]
[-- Type: application/text/x-diff, Size: 4132 bytes --]

From eac6680869fddad038de51ca0609a7846ac1d538 Mon Sep 17 00:00:00 2001
From: Thomas <thomasw@fastmail.cn>
Date: Sat, 13 Jul 2019 09:48:04 -0400
Subject: [PATCH] linux5.2: Make some things modules. I have a laptop that
 requires i8042 to be unloaded upon suspend. Some people don't have nvme
 drives.

---
 srcpkgs/linux5.2/files/i386-dotconfig   | 20 ++++++++++----------
 srcpkgs/linux5.2/files/x86_64-dotconfig | 20 ++++++++++----------
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/srcpkgs/linux5.2/files/i386-dotconfig b/srcpkgs/linux5.2/files/i386-dotconfig
index 601c1d1ba31..5fddb8f1198 100644
--- a/srcpkgs/linux5.2/files/i386-dotconfig
+++ b/srcpkgs/linux5.2/files/i386-dotconfig
@@ -4,10 +4,10 @@
 #
 
 #
-# Compiler: gcc (GCC) 8.3.0
+# Compiler: gcc (GCC) 9.1.0
 #
 CONFIG_CC_IS_GCC=y
-CONFIG_GCC_VERSION=80300
+CONFIG_GCC_VERSION=90100
 CONFIG_CLANG_VERSION=0
 CONFIG_CC_HAS_ASM_GOTO=y
 CONFIG_CC_HAS_WARN_MAYBE_UNINITIALIZED=y
@@ -2134,8 +2134,8 @@ CONFIG_BLK_DEV_RSXX=m
 #
 # NVME Support
 #
-CONFIG_NVME_CORE=y
-CONFIG_BLK_DEV_NVME=y
+CONFIG_NVME_CORE=m
+CONFIG_BLK_DEV_NVME=m
 CONFIG_NVME_MULTIPATH=y
 CONFIG_NVME_FABRICS=m
 CONFIG_NVME_RDMA=m
@@ -3415,7 +3415,7 @@ CONFIG_INPUT_MATRIXKMAP=m
 #
 # Userland interfaces
 #
-CONFIG_INPUT_MOUSEDEV=y
+CONFIG_INPUT_MOUSEDEV=m
 CONFIG_INPUT_MOUSEDEV_PSAUX=y
 CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
 CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
@@ -3430,7 +3430,7 @@ CONFIG_INPUT_KEYBOARD=y
 CONFIG_KEYBOARD_ADC=m
 CONFIG_KEYBOARD_ADP5588=m
 CONFIG_KEYBOARD_ADP5589=m
-CONFIG_KEYBOARD_ATKBD=y
+CONFIG_KEYBOARD_ATKBD=m
 CONFIG_KEYBOARD_QT1050=m
 CONFIG_KEYBOARD_QT1070=m
 CONFIG_KEYBOARD_QT2160=m
@@ -3472,7 +3472,7 @@ CONFIG_MOUSE_PS2_SENTELIC=y
 CONFIG_MOUSE_PS2_FOCALTECH=y
 CONFIG_MOUSE_PS2_VMMOUSE=y
 CONFIG_MOUSE_PS2_SMBUS=y
-CONFIG_MOUSE_SERIAL=y
+CONFIG_MOUSE_SERIAL=m
 CONFIG_MOUSE_APPLETOUCH=m
 CONFIG_MOUSE_BCM5974=m
 CONFIG_MOUSE_CYAPA=m
@@ -3689,14 +3689,14 @@ CONFIG_RMI4_F55=y
 #
 # Hardware I/O ports
 #
-CONFIG_SERIO=y
+CONFIG_SERIO=m
 CONFIG_ARCH_MIGHT_HAVE_PC_SERIO=y
-CONFIG_SERIO_I8042=y
+CONFIG_SERIO_I8042=m
 CONFIG_SERIO_SERPORT=m
 CONFIG_SERIO_CT82C710=m
 CONFIG_SERIO_PARKBD=m
 CONFIG_SERIO_PCIPS2=m
-CONFIG_SERIO_LIBPS2=y
+CONFIG_SERIO_LIBPS2=m
 CONFIG_SERIO_RAW=m
 CONFIG_SERIO_ALTERA_PS2=m
 CONFIG_SERIO_PS2MULT=m
diff --git a/srcpkgs/linux5.2/files/x86_64-dotconfig b/srcpkgs/linux5.2/files/x86_64-dotconfig
index 0e05ed37e80..0377798b129 100644
--- a/srcpkgs/linux5.2/files/x86_64-dotconfig
+++ b/srcpkgs/linux5.2/files/x86_64-dotconfig
@@ -4,10 +4,10 @@
 #
 
 #
-# Compiler: gcc (GCC) 8.3.0
+# Compiler: gcc (GCC) 9.1.0
 #
 CONFIG_CC_IS_GCC=y
-CONFIG_GCC_VERSION=80300
+CONFIG_GCC_VERSION=90100
 CONFIG_CLANG_VERSION=0
 CONFIG_CC_HAS_ASM_GOTO=y
 CONFIG_CC_HAS_WARN_MAYBE_UNINITIALIZED=y
@@ -2195,8 +2195,8 @@ CONFIG_BLK_DEV_RSXX=m
 #
 # NVME Support
 #
-CONFIG_NVME_CORE=y
-CONFIG_BLK_DEV_NVME=y
+CONFIG_NVME_CORE=m
+CONFIG_BLK_DEV_NVME=m
 CONFIG_NVME_MULTIPATH=y
 CONFIG_NVME_FABRICS=m
 CONFIG_NVME_RDMA=m
@@ -3491,7 +3491,7 @@ CONFIG_INPUT_MATRIXKMAP=m
 #
 # Userland interfaces
 #
-CONFIG_INPUT_MOUSEDEV=y
+CONFIG_INPUT_MOUSEDEV=m
 CONFIG_INPUT_MOUSEDEV_PSAUX=y
 CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
 CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
@@ -3506,7 +3506,7 @@ CONFIG_INPUT_KEYBOARD=y
 CONFIG_KEYBOARD_ADC=m
 CONFIG_KEYBOARD_ADP5588=m
 CONFIG_KEYBOARD_ADP5589=m
-CONFIG_KEYBOARD_ATKBD=y
+CONFIG_KEYBOARD_ATKBD=m
 CONFIG_KEYBOARD_QT1050=m
 CONFIG_KEYBOARD_QT1070=m
 CONFIG_KEYBOARD_QT2160=m
@@ -3548,7 +3548,7 @@ CONFIG_MOUSE_PS2_SENTELIC=y
 CONFIG_MOUSE_PS2_FOCALTECH=y
 CONFIG_MOUSE_PS2_VMMOUSE=y
 CONFIG_MOUSE_PS2_SMBUS=y
-CONFIG_MOUSE_SERIAL=y
+CONFIG_MOUSE_SERIAL=m
 CONFIG_MOUSE_APPLETOUCH=m
 CONFIG_MOUSE_BCM5974=m
 CONFIG_MOUSE_CYAPA=m
@@ -3765,14 +3765,14 @@ CONFIG_RMI4_F55=y
 #
 # Hardware I/O ports
 #
-CONFIG_SERIO=y
+CONFIG_SERIO=m
 CONFIG_ARCH_MIGHT_HAVE_PC_SERIO=y
-CONFIG_SERIO_I8042=y
+CONFIG_SERIO_I8042=m
 CONFIG_SERIO_SERPORT=m
 CONFIG_SERIO_CT82C710=m
 CONFIG_SERIO_PARKBD=m
 CONFIG_SERIO_PCIPS2=m
-CONFIG_SERIO_LIBPS2=y
+CONFIG_SERIO_LIBPS2=m
 CONFIG_SERIO_RAW=m
 CONFIG_SERIO_ALTERA_PS2=m
 CONFIG_SERIO_PS2MULT=m

Re: linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/13090#issuecomment-511142729
Comment:
should i be making these changes to the ppc kernels as well? I am reluctant to change a kernel without hardware to test my changes.

Re: linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/13090#issuecomment-511194178
Comment:
Personally I don't like the idea to make these modules, though.

If I see it right then, with this change applied, without a working initrd and the modules available you won't have keyboard input and support for NVME on any system and thus could not even try to e.g. use the `Ctrl+Alt+Shift+SysReq+<X>` keys for debug info, sync, reboot, etc.?

If this is the case, please create your x86_64-dotconfig-custom and roll your own kernel. It's your laptop which requires i8042 as a module and I haven't heard of anyone else asking for this.

Re: linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/13090#issuecomment-511196685
Comment:
That is an excellent point. Since I can't see. i forget that that stuff even works. Usually for me if its not booting into userspace its game over and I have to chroot in to see whats wrong. IN that case, should we go the other direction and also build ahci into the kernel instead of a module for people who have sata drives and not NVME?

Re: linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by thomas-t-w on void-packages repository

https://github.com/void-linux/void-packages/pull/13090#issuecomment-511197232
Comment:
also, we should maybe include usbhid in the kernel for usb keyboard and mice?

Re: linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/13090#issuecomment-511217028
Comment:
I don't think we should change a running system for no apparent reason. @void-linux/pkg-committers ?

Re: linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/13090#issuecomment-511234370
Comment:
This change would break multiple known classes of users and therefore is not a candidate for merge to the official repo. If you have hardware that needs custom kernels to work correctly you are encouraged to build it outside the distro provided tree.

Re: [PR PATCH] [Closed]: linux5.2: Make some things modules.

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

There's a closed pull request on the void-packages repository

linux5.2: Make some things modules.
https://github.com/void-linux/void-packages/pull/13090
Description: I have a laptop that requires i8042 to be unloaded upon suspend. Some people don't have nvme drives.