Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES
@ 2019-09-28 20:34 voidlinux-github
  2019-09-29  4:25 ` [PR PATCH] [Closed]: " voidlinux-github
  2019-09-29  4:32 ` voidlinux-github
  0 siblings, 2 replies; 3+ messages in thread
From: voidlinux-github @ 2019-09-28 20:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

There is a new pull request by leahneukirchen against master on the void-packages repository

https://github.com/leahneukirchen/void-packages grub-zfs
https://github.com/void-linux/void-packages/pull/14801

grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES
Not setting this results in the output of 'zpool status' being
misparsed.

See https://github.com/zfsonlinux/grub/issues/5

A patch file from https://github.com/void-linux/void-packages/pull/14801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grub-zfs-14801.patch --]
[-- Type: text/x-diff, Size: 1349 bytes --]

From cb204a6427afc6aaeb7151fadd66e2b238498901 Mon Sep 17 00:00:00 2001
From: Leah Neukirchen <leah@vuxu.org>
Date: Sat, 28 Sep 2019 22:31:22 +0200
Subject: [PATCH] grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES

Not setting this results in the output of 'zpool status' being
misparsed.

See https://github.com/zfsonlinux/grub/issues/5
---
 srcpkgs/grub/files/kernel.d/grub.post | 2 ++
 srcpkgs/grub/template                 | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/grub/files/kernel.d/grub.post b/srcpkgs/grub/files/kernel.d/grub.post
index f28257d999d..561d8b2f179 100644
--- a/srcpkgs/grub/files/kernel.d/grub.post
+++ b/srcpkgs/grub/files/kernel.d/grub.post
@@ -7,6 +7,8 @@
 PKGNAME="$1"
 VERSION="$2"
 
+export ZPOOL_VDEV_NAME_PATH=YES
+
 if command -v grub-mkconfig >/dev/null 2>&1; then
 	if [ -d $ROOTDIR/boot/grub ]; then
 		grub-mkconfig -o $ROOTDIR/boot/grub/grub.cfg
diff --git a/srcpkgs/grub/template b/srcpkgs/grub/template
index cd6b168036d..16f3f5eb01c 100644
--- a/srcpkgs/grub/template
+++ b/srcpkgs/grub/template
@@ -1,7 +1,7 @@
 # Template file for 'grub'
 pkgname=grub
 version=2.04
-revision=1
+revision=2
 hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf"
 makedepends="libusb-compat-devel ncurses-devel freetype-devel
  liblzma-devel device-mapper-devel fuse-devel"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES
  2019-09-28 20:34 [PR PATCH] grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES voidlinux-github
@ 2019-09-29  4:25 ` voidlinux-github
  2019-09-29  4:32 ` voidlinux-github
  1 sibling, 0 replies; 3+ messages in thread
From: voidlinux-github @ 2019-09-29  4:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

There's a closed pull request on the void-packages repository

grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES
https://github.com/void-linux/void-packages/pull/14801

Description:
Not setting this results in the output of 'zpool status' being
misparsed.

See https://github.com/zfsonlinux/grub/issues/5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES
  2019-09-28 20:34 [PR PATCH] grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES voidlinux-github
  2019-09-29  4:25 ` [PR PATCH] [Closed]: " voidlinux-github
@ 2019-09-29  4:32 ` voidlinux-github
  1 sibling, 0 replies; 3+ messages in thread
From: voidlinux-github @ 2019-09-29  4:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/14801#issuecomment-536248039

Comment:
Next probably also either `update-grub` or killing that terrible Debian compat script completely. Or we can keep it because it's not doing harm.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-29  4:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-28 20:34 [PR PATCH] grub: grub.post: set ZPOOL_VDEV_NAME_PATH=YES voidlinux-github
2019-09-29  4:25 ` [PR PATCH] [Closed]: " voidlinux-github
2019-09-29  4:32 ` voidlinux-github

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).