[PR PATCH] owncloudcustom: add service

[PR PATCH] owncloudcustom: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

There is a new pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages owncloudcustom
https://github.com/void-linux/void-packages/pull/16119

owncloudcustom: add service
Added service, as one can sync folder without the need of GUI
Adopt; contacted maintainer and he said I could take

A patch file from https://github.com/void-linux/void-packages/pull/16119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-owncloudcustom-16119.patch --]
[-- Type: text/x-diff, Size: 2553 bytes --]

From 52291b0401decbdcda1bf96a032a61c3d0117cc0 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens04@gmail.com>
Date: Mon, 4 Nov 2019 10:32:29 -0600
Subject: [PATCH] owncloudcustom: add service

Added service, as one can sync folder without the need of GUI
Adopt; contacted maintainer and he said I could take
---
 srcpkgs/owncloudclient/INSTALL.msg              | 9 +++++++++
 srcpkgs/owncloudclient/files/owncloudclient/run | 6 ++++++
 srcpkgs/owncloudclient/template                 | 9 +++++++--
 3 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/owncloudclient/INSTALL.msg
 create mode 100644 srcpkgs/owncloudclient/files/owncloudclient/run

diff --git a/srcpkgs/owncloudclient/INSTALL.msg b/srcpkgs/owncloudclient/INSTALL.msg
new file mode 100644
index 00000000000..6d7b82392ae
--- /dev/null
+++ b/srcpkgs/owncloudclient/INSTALL.msg
@@ -0,0 +1,9 @@
+In order to use the owncloudclient service:
+
+Edit /etc/sv/owncloudclient/run
+
+Add your login, password, and folder details
+E.G.:
+USER=owncloud
+PASSWORD=owncloud
+FOLDER=/home/owncloud
diff --git a/srcpkgs/owncloudclient/files/owncloudclient/run b/srcpkgs/owncloudclient/files/owncloudclient/run
new file mode 100644
index 00000000000..b9c7081255b
--- /dev/null
+++ b/srcpkgs/owncloudclient/files/owncloudclient/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+USER=
+PASSWORD=
+SERVER=
+FOLDER=
+exec sleep 2m ; owncloudcmd ${FOLDER} https://${USER}:${PASSWORD}@${SERVER}
diff --git a/srcpkgs/owncloudclient/template b/srcpkgs/owncloudclient/template
index 406b515b45c..3886e94b46b 100644
--- a/srcpkgs/owncloudclient/template
+++ b/srcpkgs/owncloudclient/template
@@ -1,7 +1,7 @@
 # Template file for 'owncloudclient'
 pkgname=owncloudclient
 version=2.5.4.11654
-revision=1
+revision=2
 build_style=cmake
 configure_args="-Wno-dev -DNO_SHIBBOLETH=TRUE"
 hostmakedepends="pkg-config"
@@ -11,12 +11,17 @@ makedepends="qtkeychain-qt5-devel sqlite-devel qt5-declarative-devel
 depends="qt5-plugin-sqlite"
 conf_files="/etc/ownCloud/sync-exclude.lst"
 short_desc="Connect to ownCloud servers"
-maintainer="Samuel Chodur <samuelchodur@gmail.com>"
+maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.owncloud.org"
 distfiles="https://download.owncloud.com/desktop/stable/${pkgname}-${version}.tar.xz"
 checksum=615439c6a224e263cee0d554b8b5f98b57c331dbc18df7ae5d99197480cf563f
+system_accounts="owncloud"
 
 if [ "$CROSS_BUILD" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-tools-devel"
 fi
+
+post_install() {
+	vsv owncloudclient
+}

Re: [PR PATCH] [Updated] owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages owncloudcustom
https://github.com/void-linux/void-packages/pull/16119

owncloudclient: add service
Added service, as one can sync folder without the need of GUI
Adopt; contacted maintainer and he said I could take

A patch file from https://github.com/void-linux/void-packages/pull/16119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-owncloudcustom-16119.patch --]
[-- Type: text/x-diff, Size: 2553 bytes --]

From bd1944284b7e33f7c260571d927a30220ceccddd Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens04@gmail.com>
Date: Mon, 4 Nov 2019 10:32:29 -0600
Subject: [PATCH] owncloudclient: add service

Added service, as one can sync folder without the need of GUI
Adopt; contacted maintainer and he said I could take
---
 srcpkgs/owncloudclient/INSTALL.msg              | 9 +++++++++
 srcpkgs/owncloudclient/files/owncloudclient/run | 6 ++++++
 srcpkgs/owncloudclient/template                 | 9 +++++++--
 3 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/owncloudclient/INSTALL.msg
 create mode 100644 srcpkgs/owncloudclient/files/owncloudclient/run

diff --git a/srcpkgs/owncloudclient/INSTALL.msg b/srcpkgs/owncloudclient/INSTALL.msg
new file mode 100644
index 00000000000..6d7b82392ae
--- /dev/null
+++ b/srcpkgs/owncloudclient/INSTALL.msg
@@ -0,0 +1,9 @@
+In order to use the owncloudclient service:
+
+Edit /etc/sv/owncloudclient/run
+
+Add your login, password, and folder details
+E.G.:
+USER=owncloud
+PASSWORD=owncloud
+FOLDER=/home/owncloud
diff --git a/srcpkgs/owncloudclient/files/owncloudclient/run b/srcpkgs/owncloudclient/files/owncloudclient/run
new file mode 100644
index 00000000000..b9c7081255b
--- /dev/null
+++ b/srcpkgs/owncloudclient/files/owncloudclient/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+USER=
+PASSWORD=
+SERVER=
+FOLDER=
+exec sleep 2m ; owncloudcmd ${FOLDER} https://${USER}:${PASSWORD}@${SERVER}
diff --git a/srcpkgs/owncloudclient/template b/srcpkgs/owncloudclient/template
index 406b515b45c..3886e94b46b 100644
--- a/srcpkgs/owncloudclient/template
+++ b/srcpkgs/owncloudclient/template
@@ -1,7 +1,7 @@
 # Template file for 'owncloudclient'
 pkgname=owncloudclient
 version=2.5.4.11654
-revision=1
+revision=2
 build_style=cmake
 configure_args="-Wno-dev -DNO_SHIBBOLETH=TRUE"
 hostmakedepends="pkg-config"
@@ -11,12 +11,17 @@ makedepends="qtkeychain-qt5-devel sqlite-devel qt5-declarative-devel
 depends="qt5-plugin-sqlite"
 conf_files="/etc/ownCloud/sync-exclude.lst"
 short_desc="Connect to ownCloud servers"
-maintainer="Samuel Chodur <samuelchodur@gmail.com>"
+maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.owncloud.org"
 distfiles="https://download.owncloud.com/desktop/stable/${pkgname}-${version}.tar.xz"
 checksum=615439c6a224e263cee0d554b8b5f98b57c331dbc18df7ae5d99197480cf563f
+system_accounts="owncloud"
 
 if [ "$CROSS_BUILD" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-tools-devel"
 fi
+
+post_install() {
+	vsv owncloudclient
+}

Re: owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/16119#issuecomment-549521467

Comment:
I don't think this service should be added.
`exec sleep 2; cmd` is definitively wrong.

Re: owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/16119#issuecomment-549522465

Comment:
Heh

El lun., 4 nov. 2019 20:58, Duncan Overbruck <notifications@github.com>
escribió:

> I don't think this service should be added.
> exec sleep 2; cmd is definitively wrong.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/16119?email_source=notifications&email_token=AAGR7KJ2GMSU6UIQIXRQUS3QSB5E3A5CNFSM4JIYBDP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDAQQOY#issuecomment-549521467>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAGR7KKRX3V3XBLCSEHQOITQSB5E3ANCNFSM4JIYBDPQ>
> .
>

Re: owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/16119#issuecomment-549524421

Comment:
> I don't think this service should be added.
> `exec sleep 2; cmd` is definitively wrong.

Should it be just sleep 2m, drop the exec?  I think having a service file would be convenient for people that doesn’t want/need a GUI to run to sync files. I know I don’t want it having to be up just to sync and waste more memory than a service would use

Re: [PR PATCH] [Updated] owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages owncloudcustom
https://github.com/void-linux/void-packages/pull/16119

owncloudclient: add service
Added service, as one can sync folder without the need of GUI
Adopt; contacted maintainer and he said I could take

A patch file from https://github.com/void-linux/void-packages/pull/16119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-owncloudcustom-16119.patch --]
[-- Type: text/x-diff, Size: 2548 bytes --]

From 99ff597a93641097dc5800c44537c800981d2bb9 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens04@gmail.com>
Date: Mon, 4 Nov 2019 10:32:29 -0600
Subject: [PATCH] owncloudclient: add service

Added service, as one can sync folder without the need of GUI
Adopt; contacted maintainer and he said I could take
---
 srcpkgs/owncloudclient/INSTALL.msg              | 9 +++++++++
 srcpkgs/owncloudclient/files/owncloudclient/run | 6 ++++++
 srcpkgs/owncloudclient/template                 | 9 +++++++--
 3 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/owncloudclient/INSTALL.msg
 create mode 100644 srcpkgs/owncloudclient/files/owncloudclient/run

diff --git a/srcpkgs/owncloudclient/INSTALL.msg b/srcpkgs/owncloudclient/INSTALL.msg
new file mode 100644
index 00000000000..6d7b82392ae
--- /dev/null
+++ b/srcpkgs/owncloudclient/INSTALL.msg
@@ -0,0 +1,9 @@
+In order to use the owncloudclient service:
+
+Edit /etc/sv/owncloudclient/run
+
+Add your login, password, and folder details
+E.G.:
+USER=owncloud
+PASSWORD=owncloud
+FOLDER=/home/owncloud
diff --git a/srcpkgs/owncloudclient/files/owncloudclient/run b/srcpkgs/owncloudclient/files/owncloudclient/run
new file mode 100644
index 00000000000..0bc97a0ca56
--- /dev/null
+++ b/srcpkgs/owncloudclient/files/owncloudclient/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+USER=
+PASSWORD=
+SERVER=
+FOLDER=
+sleep 2m ; owncloudcmd ${FOLDER} https://${USER}:${PASSWORD}@${SERVER}
diff --git a/srcpkgs/owncloudclient/template b/srcpkgs/owncloudclient/template
index 406b515b45c..3886e94b46b 100644
--- a/srcpkgs/owncloudclient/template
+++ b/srcpkgs/owncloudclient/template
@@ -1,7 +1,7 @@
 # Template file for 'owncloudclient'
 pkgname=owncloudclient
 version=2.5.4.11654
-revision=1
+revision=2
 build_style=cmake
 configure_args="-Wno-dev -DNO_SHIBBOLETH=TRUE"
 hostmakedepends="pkg-config"
@@ -11,12 +11,17 @@ makedepends="qtkeychain-qt5-devel sqlite-devel qt5-declarative-devel
 depends="qt5-plugin-sqlite"
 conf_files="/etc/ownCloud/sync-exclude.lst"
 short_desc="Connect to ownCloud servers"
-maintainer="Samuel Chodur <samuelchodur@gmail.com>"
+maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://www.owncloud.org"
 distfiles="https://download.owncloud.com/desktop/stable/${pkgname}-${version}.tar.xz"
 checksum=615439c6a224e263cee0d554b8b5f98b57c331dbc18df7ae5d99197480cf563f
+system_accounts="owncloud"
 
 if [ "$CROSS_BUILD" ]; then
 	hostmakedepends+=" qt5-host-tools qt5-tools-devel"
 fi
+
+post_install() {
+	vsv owncloudclient
+}

Re: owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/16119#issuecomment-549524421

Comment:
I had taken exec out on my end, forgot to remove from this update. I think having a service file would be convenient for people that doesn’t want/need a GUI to run to sync files. I know I don’t want it having to be up just to sync and waste more memory than a service would use

Re: owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/16119#issuecomment-549538471

Comment:
Even without the exec, its not a good service, it will supervise the run script and its running as root.
I feel like if we would allow this, we open the doors for a bunch of other not really services that don't fit into the supervision model.

Re: [PR PATCH] [Closed]: owncloudclient: add service

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

There's a closed pull request on the void-packages repository

owncloudclient: add service
https://github.com/void-linux/void-packages/pull/16119

Description:
Added service, as one can sync folder without the need of GUI
Adopt; contacted maintainer and he said I could take