Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] vscode: remove telemetry
@ 2020-01-15 11:19 voidlinux-github
  2020-03-31  9:31 ` [PR PATCH] [Closed]: " xtraeme
  0 siblings, 1 reply; 2+ messages in thread
From: voidlinux-github @ 2020-01-15 11:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

There is a new pull request by ametisf against master on the void-packages repository

https://github.com/ametisf/void-ports vscode-telemetry
https://github.com/void-linux/void-packages/pull/18314

vscode: remove telemetry
Adds a sed script from vscodium
https://github.com/VSCodium/vscodium/blob/f805d740bb77135aa36d77bda41318510978abc4/undo_telemetry.sh

AFAICT this is the only change sans rebranding vscodium does, so this
should address issue #10582

Also added `tar` in `hostmakedepends` because the vscode build script uses tar and this is way easier than trying to patch it to use bsdtar.

A patch file from https://github.com/void-linux/void-packages/pull/18314.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-telemetry-18314.patch --]
[-- Type: text/x-diff, Size: 1461 bytes --]

From 25a3ddd4ab96ff779c4298d7b82881865b95ace4 Mon Sep 17 00:00:00 2001
From: Frantisek Fladung <fladufra@fel.cvut.cz>
Date: Wed, 15 Jan 2020 12:12:31 +0100
Subject: [PATCH] vscode: remove telemetry

Adds a sed script from vscodium
https://github.com/VSCodium/vscodium/blob/f805d740bb77135aa36d77bda41318510978abc4/undo_telemetry.sh

AFAICT this is the only change sans rebranding vscodium does, so this
should address issue #10582
---
 srcpkgs/vscode/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index 3a0ce068442..4f4eccaa4a3 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,8 +1,8 @@
 # Template file for 'vscode'
 pkgname=vscode
 version=1.41.1
-revision=2
-hostmakedepends="pkg-config python nodejs-lts yarn"
+revision=3
+hostmakedepends="pkg-config python nodejs-lts yarn tar"
 makedepends="libxkbfile-devel libsecret-devel"
 depends="libXtst libxkbfile nss dejavu-fonts-ttf"
 short_desc="Microsoft Code for Linux"
@@ -31,6 +31,12 @@ esac
 pre_build() {
 	# Use yarn to install dependencies
 	echo "" > build/npm/preinstall.js
+
+	# redirect telemetry urls to 0.0.0.0
+	# src: vscodium/undo_telemetry.sh
+	_TELEMETRY_URLS="(dc\.services\.visualstudio\.com)|(vortex\.data\.microsoft\.com)"
+	_REPLACEMENT="s/$_TELEMETRY_URLS/0\.0\.0\.0/g"
+	grep -rl --exclude-dir=.git -E $_TELEMETRY_URLS | xargs sed -i -E $_REPLACEMENT
 }
 
 do_build() {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Closed]: vscode: remove telemetry
  2020-01-15 11:19 [PR PATCH] vscode: remove telemetry voidlinux-github
@ 2020-03-31  9:31 ` xtraeme
  0 siblings, 0 replies; 2+ messages in thread
From: xtraeme @ 2020-03-31  9:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

There's a closed pull request on the void-packages repository

vscode: remove telemetry
https://github.com/void-linux/void-packages/pull/18314

Description:
Adds a sed script from vscodium
https://github.com/VSCodium/vscodium/blob/f805d740bb77135aa36d77bda41318510978abc4/undo_telemetry.sh

AFAICT this is the only change sans rebranding vscodium does, so this
should address issue #10582

Also added `tar` in `hostmakedepends` because the vscode build script uses tar and this is way easier than trying to patch it to use bsdtar.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-31  9:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 11:19 [PR PATCH] vscode: remove telemetry voidlinux-github
2020-03-31  9:31 ` [PR PATCH] [Closed]: " xtraeme

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).