[PR PATCH] New package: arma3-unix-launcher-git-20200112_1

[PR PATCH] New package: arma3-unix-launcher-git-20200112_1

[voidlinux-github]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

There is a new pull request by Auberginez against master on the void-packages repository

https://github.com/Auberginez/void-packages arma3-unix-launcher-git
https://github.com/void-linux/void-packages/pull/18627

New package: arma3-unix-launcher-git-20200112_1


A patch file from https://github.com/void-linux/void-packages/pull/18627.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-arma3-unix-launcher-git-18627.patch --]
[-- Type: text/x-diff, Size: 1238 bytes --]

From 6c7777d07671aa5e43a266fbea663307b7017bdb Mon Sep 17 00:00:00 2001
From: Auberginez <aubergines@protonmail.com>
Date: Wed, 29 Jan 2020 11:48:36 +0000
Subject: [PATCH] New package: arma3-unix-launcher-git-20200112_1

---
 srcpkgs/arma3-unix-launcher-git/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/arma3-unix-launcher-git/template

diff --git a/srcpkgs/arma3-unix-launcher-git/template b/srcpkgs/arma3-unix-launcher-git/template
new file mode 100644
index 00000000000..e5e282671ca
--- /dev/null
+++ b/srcpkgs/arma3-unix-launcher-git/template
@@ -0,0 +1,19 @@
+# Template file for 'arma3-unix-launcher-git'
+pkgname=arma3-unix-launcher-git
+version=20200112
+revision=1
+_commit=facedb0993d66e7bf31fde87e945a59641d25e43
+wrksrc="arma3-unix-launcher-$_commit"
+build_style=cmake
+makedepends="cmake pkg-config gtkmm-devel"
+depends="gtkmm"
+short_desc="ArmA 3 Launcher for Linux and Mac"
+maintainer="Auberginez <aubergines@protonmail.com>"
+license="MIT"
+homepage="https://github.com/muttleyxd/arma3-unix-launcher"
+distfiles="${homepage}/archive/${_commit}.tar.gz"
+checksum=76209d4e748f1a2a45a41658421e0a937dbe0c6e8b6892b66410728da2a623a1
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: arma3-unix-launcher-git-20200112_1

[Noah-Huppert]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by Noah-Huppert on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#issuecomment-670998373

Comment:
I think the build failed due to some reason unrelated to this package:

```
=> ERROR: xbps-src: failed to update xbps!
````

I built and installed this package just fine on x86_64.

Re: [PR REVIEW] New package: arma3-unix-launcher-git-20200112_1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#discussion_r467529076

Comment:
drop cmake here, move pkg-config to hostmakedepends

Re: New package: arma3-unix-launcher-git-20200112_1

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#issuecomment-670999260

Comment:
Void does not accept `-git` packages. It looks like upstream tagged a release nine hours ago, so you can update to fetch the release. However, the upstream numbering scheme is based on commit number and truncated hash. This could be fragile; I recommend you file an issue upstream to provide more sensible numbering. (If the maintainer ever decides to adopt more conventional release numbering, it will likely break XBPS version comparisons and require some ugly workarounds.)

Also, the other archs failed CI for legitimate issues, not just XBPS failures. These will need to be resolved before the package can be considered for inclusion.

Re: [PR REVIEW] New package: arma3-unix-launcher-git-20200112_1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#discussion_r467529113

Comment:
just use the versions [they are](https://github.com/muttleyxd/arma3-unix-launcher/releases). version=235

Re: [PR REVIEW] New package: arma3-unix-launcher-git-20200112_1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#discussion_r467529148

Comment:
 wrksrc="arma3-unix-launcher-commit-${version}"

Re: [PR REVIEW] New package: arma3-unix-launcher-git-20200112_1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#discussion_r467529162

Comment:
Don't need this.

Re: [PR REVIEW] New package: arma3-unix-launcher-git-20200112_1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#discussion_r467529233

Comment:
distfiles="${homepage}/archive/commit-${version}.tar.gz"

Re: [PR REVIEW] New package: arma3-unix-launcher-git-20200112_1

[abenson]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#discussion_r467529314

Comment:
drop the -git 

Re: New package: arma3-unix-launcher-git-20200112_1

[Noah-Huppert]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New comment by Noah-Huppert on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#issuecomment-670998373

Comment:
~~I think the build failed due to some reason unrelated to this package:~~

~~I built and installed this package just fine on x86_64.~~ looks like there are other issues.

Re: New package: arma3-unix-launcher-git-20200112_1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/18627#issuecomment-748550521

Comment:
Author hasn't been active for a while, closing for now. Feel free to reopen!

Re: [PR PATCH] [Closed]: New package: arma3-unix-launcher-git-20200112_1

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

There's a closed pull request on the void-packages repository

New package: arma3-unix-launcher-git-20200112_1
https://github.com/void-linux/void-packages/pull/18627

Description: