[ISSUE] Latest docker update causes issues on btrfs

[ISSUE] Latest docker update causes issues on btrfs

[kernle32dll]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

New issue by kernle32dll on void-packages repository

https://github.com/void-linux/void-packages/issues/19202

Description:
The commit https://github.com/void-linux/void-packages/commit/ec709f9e09458bb1707a4136c1d4635ca11b0e7a did not only update docker, but enforced the `overlay2` storage driver. While this is a fine default, it can actually break docker on `btrfs` file systems.

From the [Dockerd documentation](https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-storage-driver):

> Note: Both overlay and overlay2 are currently unsupported on btrfs or any Copy on Write filesystem and should only be used over ext4 partitions.

Even if not breaking, its an un-intuitive change, if you don't happen to use `overlay2` previously. It took me a good while to understand why all of my images and volumes were gone - which was due to the change of the storage driver.

Its easy to fix locally - just remove the `storage-driver` line from `/etc/docker/daemon.json`. But this should be removed in the package, too - IMO.

Re: Latest docker update causes issues on btrfs

[D-Nice]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New comment by D-Nice on void-packages repository

https://github.com/void-linux/void-packages/issues/19202#issuecomment-586799000

Comment:
I find many issues with the change myself. The only potentially needed part there is log-driver, which should just be passed as a flag from runit, and not bog the rest of us down with some defaults we don't want AND replacing our own configs.

Re: Latest docker update causes issues on btrfs

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/19202#issuecomment-586813026

Comment:
@jbenden 

Re: [ISSUE] [CLOSED] Latest docker update causes issues on btrfs

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

Closed issue by kernle32dll on void-packages repository

https://github.com/void-linux/void-packages/issues/19202

Description:
The commit https://github.com/void-linux/void-packages/commit/ec709f9e09458bb1707a4136c1d4635ca11b0e7a did not only update docker, but enforced the `overlay2` storage driver. While this is a fine default, it can actually break docker on `btrfs` file systems.

From the [Dockerd documentation](https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-storage-driver):

> Note: Both overlay and overlay2 are currently unsupported on btrfs or any Copy on Write filesystem and should only be used over ext4 partitions.

Even if not breaking, its an un-intuitive change, if you don't happen to use `overlay2` previously. It took me a good while to understand why all of my images and volumes were gone - which was due to the change of the storage driver.

Its easy to fix locally - just remove the `storage-driver` line from `/etc/docker/daemon.json`. But this should be removed in the package, too - IMO.

Re: Latest docker update causes issues on btrfs

[kernle32dll]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by kernle32dll on void-packages repository

https://github.com/void-linux/void-packages/issues/19202#issuecomment-586993317

Comment:
Welp, the new PR now completely broke Docker for me. Daemon is not starting again anymore.

`sv status docker` yields:

`run: docker: (pid 15449) 1s; warning: docker/log: unable to open supervise/ok: file does not exist`

No clue how to fix myself.

Re: Latest docker update causes issues on btrfs

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/19202#issuecomment-586996190

Comment:
Has been fixed this morning, make sure your system is up to date 

Re: Latest docker update causes issues on btrfs

[kernle32dll]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

New comment by kernle32dll on void-packages repository

https://github.com/void-linux/void-packages/issues/19202#issuecomment-586997308

Comment:
It is. After some tinkering I got it running again:

First, I removed the `/etc/sv/docker/log` folder - not sure if that did anything, but it got rid of the error message above.

Then turns out, due to the original problem I had both `overlay2` and `btrfs` under `/var/lib/docker`. With the removal of the daemon.json per https://github.com/void-linux/void-packages/pull/19226, Docker was unable to "guess" the correct storage driver. I deleted the `overlay2` folder (warning fellow Googler, this is due to me using Btrfs, don't do that blindly), and it works again.

Re: Latest docker update causes issues on btrfs

[kernle32dll]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

New comment by kernle32dll on void-packages repository

https://github.com/void-linux/void-packages/issues/19202#issuecomment-586997308

Comment:
It is. After some tinkering I got it running again:

First, I removed the `/etc/sv/docker/log` folder - not sure if that did anything, but it got rid of the error message above.

Then turns out, due to the original problem I had both `overlay2` and `btrfs` under `/var/lib/docker`. With the removal of the daemon.json per https://github.com/void-linux/void-packages/pull/19226 (edit: to be precise - I deleted it locally too after the update), Docker was unable to "guess" the correct storage driver. I deleted the `overlay2` folder (warning fellow Googler, this is due to me using Btrfs, don't do that blindly), and it works again.

Re: Latest docker update causes issues on btrfs

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/19202#issuecomment-586999600

Comment:
Your issue might be an artifact due to having a pkg with a configuration file and then a new one without it.