[PR PATCH] Kindd: remove unnecessary dependencies

[PR PATCH] Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

There is a new pull request by LinArcX against master on the void-packages repository

https://github.com/LinArcX/void-packages kindd-remove-unrd
https://github.com/void-linux/void-packages/pull/20821

Kindd: remove unnecessary dependencies
1. Let users decide which polkit-agent is appropriate for them.
2. Remove unnecessary runtime dependencies like:
`polkit-gnome` , `qt5-quickcontrols2`, `qt5-declarative`, `qt5-svg`

A patch file from https://github.com/void-linux/void-packages/pull/20821.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kindd-remove-unrd-20821.patch --]
[-- Type: text/x-diff, Size: 1134 bytes --]

From 6bc531f9d1ce04327fb7fbb01500fcb621bdb773 Mon Sep 17 00:00:00 2001
From: linarcx <linarcx@riseup.net>
Date: Fri, 10 Apr 2020 12:47:26 +0430
Subject: [PATCH] Kindd: remove polkit-gnome, qt5-quickcontrols2,
 qt5-declarative, qt5-svg from run-time dependencies

---
 srcpkgs/kindd/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/kindd/template b/srcpkgs/kindd/template
index 87c6e6bdf7c..46d9351bfe5 100644
--- a/srcpkgs/kindd/template
+++ b/srcpkgs/kindd/template
@@ -1,11 +1,12 @@
 # Template file for 'kindd'
 pkgname=kindd
 version=2.1.0
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="cmake pkg-config qt5-qmake qt5-host-tools"
-makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel qt5-svg-devel"
-depends="polkit-gnome qt5-quickcontrols qt5-quickcontrols2 qt5-graphicaleffects  qt5-declarative qt5-svg"
+makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel
+ qt5-svg-devel"
+depends="qt5-quickcontrols qt5-graphicaleffects"
 short_desc="Kindful dd, written by qt-quick"
 maintainer="linarcx <linarcx@gmail.com>"
 license="GPL-3.0-only"

Re: [PR PATCH] [Updated] Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

There is an updated pull request by LinArcX against master on the void-packages repository

https://github.com/LinArcX/void-packages kindd-remove-unrd
https://github.com/void-linux/void-packages/pull/20821

Kindd: remove unnecessary dependencies
1. Let users decide which polkit-agent is appropriate for them.
2. Remove unnecessary runtime dependencies like:
`polkit-gnome` , `qt5-quickcontrols2`, `qt5-declarative`, `qt5-svg`

A patch file from https://github.com/void-linux/void-packages/pull/20821.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kindd-remove-unrd-20821.patch --]
[-- Type: text/x-diff, Size: 1072 bytes --]

From dc71d0a51bec23afdd006b53c6ba038aed4fecb4 Mon Sep 17 00:00:00 2001
From: linarcx <linarcx@riseup.net>
Date: Fri, 10 Apr 2020 12:47:26 +0430
Subject: [PATCH] Kindd: remove unnecessary dependencies

---
 srcpkgs/kindd/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/kindd/template b/srcpkgs/kindd/template
index 87c6e6bdf7c..46d9351bfe5 100644
--- a/srcpkgs/kindd/template
+++ b/srcpkgs/kindd/template
@@ -1,11 +1,12 @@
 # Template file for 'kindd'
 pkgname=kindd
 version=2.1.0
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="cmake pkg-config qt5-qmake qt5-host-tools"
-makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel qt5-svg-devel"
-depends="polkit-gnome qt5-quickcontrols qt5-quickcontrols2 qt5-graphicaleffects  qt5-declarative qt5-svg"
+makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel
+ qt5-svg-devel"
+depends="qt5-quickcontrols qt5-graphicaleffects"
 short_desc="Kindful dd, written by qt-quick"
 maintainer="linarcx <linarcx@gmail.com>"
 license="GPL-3.0-only"

Re: Kindd: remove unnecessary dependencies

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612210470

Comment:
lol this seems to be your very project and it lists `qt5-svg` as runtime dependency, yet you remove it from the template?

When this GUI is for those who don't want to `sudo dd`, do you really think the intended target audience is supposed to "decide which polkit-agent is appropriate for them"? 

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612219901

Comment:
> yet you remove it from the template?
Yes. 

> When this GUI is for those who don't want to sudo dd..
No. It's not the main idea behind kindd. The idea is providing a safe place to create bootable USB from iso files. Why polkit agent should be optional? Imagine you've installed pantheon, ad it already will install pantheon agent polkit. When you install kindd, it'll install gnome agent polkit too. Why there should be two diffeent agents on your machine?

So, I think it's better to let users to decide install which agent polkit. 

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612219901

Comment:
> yet you remove it from the template?

Yes. 

> When this GUI is for those who don't want to sudo dd..

No. It's not the main idea behind kindd. The idea is providing a safe place to create bootable USB from iso files. Why polkit agent should be optional? Imagine you've installed pantheon, ad it already will install pantheon agent polkit. When you install kindd, it'll install gnome agent polkit too. Why there should be two diffeent agents on your machine?

So, I think it's better to let users to decide install which agent polkit. 

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612219901

Comment:
> yet you remove it from the template?

Yes. 

> When this GUI is for those who don't want to sudo dd..

No. It's not the main idea behind kindd. The idea is providing a safe place to create bootable USB from iso files. Why polkit agent should be optional? Imagine you've installed pantheon, ad it already will install pantheon agent polkit. When you install kindd, it'll install gnome agent polkit too. Why there should be two diffeent agents on your machine?

So, I think it's a better idea to let users decide which agent polkit is appropriate for them. 

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612219901

Comment:
> yet you remove it from the template?

Yes. 

> When this GUI is for those who don't want to sudo dd..

No. It's not the main idea behind kindd. The idea is providing a safe place to create bootable USB from iso files. Why polkit agent should be optional? Imagine you've installed pantheon, ad it already installed pantheon-agent-polkit. When you install kindd, it'll install gnome agent polkit too. Why there should be two diffeent agents on your machine?

So, I think it's a better idea to let users decide which agent polkit is appropriate for them. 

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612219901

Comment:
> yet you remove it from the template?

Yes. 

> When this GUI is for those who don't want to sudo dd..

No. It's not the main idea behind kindd. The idea is providing a safe place to create bootable USB from iso files. Why polkit agent should be optional? Imagine you've installed pantheon, and it already installed pantheon-agent-polkit. When you install kindd, it'll install gnome agent polkit too. Why there should be two diffeent agents on your machine?

So, I think it's a better idea to let users decide which agent polkit is appropriate for them. 

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612219901

Comment:
> yet you remove it from the template?

Yes. 

> When this GUI is for those who don't want to sudo dd..

No. It's not the main idea behind kindd. The idea is providing a safe place to create bootable USB from iso files. Why polkit agent should be optional? Imagine you've installed pantheon, and it already installed pantheon-agent-polkit. When you install kindd, it'll install gnome agent polkit too. Why there should be two diffeent agents on your machine?

Or kde users will complain: "why gnome-agent-polkit installed on my machine"? 

So, I think it's a better idea to let users decide which agent polkit is appropriate for them. 

Re: Kindd: remove unnecessary dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612545073

Comment:
While `qt5-quickcontrols2`, `qt5-declarative` are automatically detected by xbps as runtime deps, `qt5-svg` is not. Removing it will break icon support.
![kindd](https://user-images.githubusercontent.com/50471800/79057998-76921080-7c85-11ea-94ef-3b360b040f93.png)

I'd hate to not see that lovely mascot while using `kindd`.

Re: Kindd: remove unnecessary dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612545073

Comment:
While `qt5-quickcontrols2`, `qt5-declarative` are automatically detected by xbps-src as runtime deps, `qt5-svg` is not. Removing it will break icon support.
![kindd](https://user-images.githubusercontent.com/50471800/79057998-76921080-7c85-11ea-94ef-3b360b040f93.png)

I'd hate to not see that lovely mascot while using `kindd`.

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612571232

Comment:
> ... detected by xbps-src as runtime deps, qt5-svg is not.

Why?

Re: Kindd: remove unnecessary dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612574251

Comment:
> > ... detected by xbps-src as runtime deps, qt5-svg is not.
> 
> Why?

Kindd links with the shlibs, aka shared libraries provided by the other two packages, so xbps-src detects that those packages must be installed to load those libraries at runtime.

It doesn't need to link against any of `qt5-svg` shlibs but uses the package to render the svg icons. So you have to mention it as a runtime dependency.

Re: Kindd: remove unnecessary dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612574251

Comment:
> > ... detected by xbps-src as runtime deps, qt5-svg is not.
> 
> Why?

Kindd links with the shlibs, aka shared libraries provided by the other two packages, so xbps-src detects that those packages must be installed to load those libraries at runtime.

It doesn't need to link against any of `qt5-svg` shlibs but uses the package to render the svg icons. So you have to mention it as a runtime dependency.
@LinArcX You can check it via build output.
![rundep](https://user-images.githubusercontent.com/50471800/79063566-1e2c3480-7cc0-11ea-9c99-602e1d3ce87f.png)

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612638356

Comment:
> While qt5-quickcontrols2, qt5-declarative are automatically detected by xbps-src as runtime deps, qt5-svg is not.

I want to know exactly why this didn't happen?

Also I've noticed that i had `qt5-svg` on my machine (as dependency of other packages). So removing `qt5-svg` didn't affect my experience with software.(Sorry about that!)

Still I'm confused! Why some `makedepends` detected as runtime dependencies, and other don't.

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612638356

Comment:
> While qt5-quickcontrols2, qt5-declarative are automatically detected by xbps-src as runtime deps, qt5-svg is not.

I want to know exactly why this didn't happen?

Also I've noticed that i had `qt5-svg` on my machine (as dependency of other packages). So removing `qt5-svg` didn't affect my experience with software.(Sorry about that!)

Still I'm confused! Why some `makedepends` detected as runtime dependencies, and other don't.

Re: [PR PATCH] [Updated] Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

There is an updated pull request by LinArcX against master on the void-packages repository

https://github.com/LinArcX/void-packages kindd-remove-unrd
https://github.com/void-linux/void-packages/pull/20821

Kindd: remove unnecessary dependencies
1. Let users [decide](https://github.com/LinArcX/kindd/#polkit) which polkit-agent is appropriate for them.
2. Remove unnecessary runtime dependencies like:
`polkit-gnome` , `qt5-quickcontrols2`, `qt5-declarative`, `qt5-svg`

A patch file from https://github.com/void-linux/void-packages/pull/20821.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kindd-remove-unrd-20821.patch --]
[-- Type: text/x-diff, Size: 1134 bytes --]

From ad61ab38d545ff903e8790361f46598f257652ee Mon Sep 17 00:00:00 2001
From: linarcx <linarcx@riseup.net>
Date: Fri, 10 Apr 2020 12:47:26 +0430
Subject: [PATCH] Kindd: remove polkit-gnome, qt5-quickcontrols2,
 qt5-declarative, from run-time dependencies

---
 srcpkgs/kindd/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/kindd/template b/srcpkgs/kindd/template
index 87c6e6bdf7c..61e12333f2f 100644
--- a/srcpkgs/kindd/template
+++ b/srcpkgs/kindd/template
@@ -1,11 +1,12 @@
 # Template file for 'kindd'
 pkgname=kindd
 version=2.1.0
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="cmake pkg-config qt5-qmake qt5-host-tools"
-makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel qt5-svg-devel"
-depends="polkit-gnome qt5-quickcontrols qt5-quickcontrols2 qt5-graphicaleffects  qt5-declarative qt5-svg"
+makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel
+ qt5-svg-devel"
+depends="qt5-quickcontrols qt5-graphicaleffects qt5-svg"
 short_desc="Kindful dd, written by qt-quick"
 maintainer="linarcx <linarcx@gmail.com>"
 license="GPL-3.0-only"

Re: [PR PATCH] [Updated] Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

There is an updated pull request by LinArcX against master on the void-packages repository

https://github.com/LinArcX/void-packages kindd-remove-unrd
https://github.com/void-linux/void-packages/pull/20821

Kindd: remove unnecessary dependencies
1. Let users [decide](https://github.com/LinArcX/kindd/#polkit) which polkit-agent is appropriate for them.
2. Remove unnecessary runtime dependencies like:
`polkit-gnome` , `qt5-quickcontrols2`, `qt5-declarative`, `qt5-svg`

A patch file from https://github.com/void-linux/void-packages/pull/20821.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kindd-remove-unrd-20821.patch --]
[-- Type: text/x-diff, Size: 1080 bytes --]

From 3317d13f0b99b60ef419fff620ecbd1b7870ab00 Mon Sep 17 00:00:00 2001
From: linarcx <linarcx@riseup.net>
Date: Fri, 10 Apr 2020 12:47:26 +0430
Subject: [PATCH] Kindd: remove unnecessary dependencies

---
 srcpkgs/kindd/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/kindd/template b/srcpkgs/kindd/template
index 87c6e6bdf7c..61e12333f2f 100644
--- a/srcpkgs/kindd/template
+++ b/srcpkgs/kindd/template
@@ -1,11 +1,12 @@
 # Template file for 'kindd'
 pkgname=kindd
 version=2.1.0
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="cmake pkg-config qt5-qmake qt5-host-tools"
-makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel qt5-svg-devel"
-depends="polkit-gnome qt5-quickcontrols qt5-quickcontrols2 qt5-graphicaleffects  qt5-declarative qt5-svg"
+makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel
+ qt5-svg-devel"
+depends="qt5-quickcontrols qt5-graphicaleffects qt5-svg"
 short_desc="Kindful dd, written by qt-quick"
 maintainer="linarcx <linarcx@gmail.com>"
 license="GPL-3.0-only"

Re: Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

New comment by LinArcX on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612641031

Comment:
@not-chicken Thank you for explanations.

I've noticed that i had `qt5-svg` on my machine (as dependency of other packages). So removing `qt5-svg` didn't affect my experience with software.(Sorry about that!)

So I added it again.

Re: Kindd: remove unnecessary dependencies

[not-chicken]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/20821#issuecomment-612642886

Comment:
> I've noticed that i had `qt5-svg` on my machine (as dependency of other packages). So removing `qt5-svg` didn't affect my experience with software.(Sorry about that!)

 Yeah it's a common dep of qt5 apps. I did the same mistake, see #20608 
I'd recommend testing packages in a vm or in a secondary installation with only base-system, xorg and a wm. It will make it easy to catch missing runtime dependencies.

Re: [PR PATCH] [Updated] Kindd: remove unnecessary dependencies

[LinArcX]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

There is an updated pull request by LinArcX against master on the void-packages repository

https://github.com/LinArcX/void-packages kindd-remove-unrd
https://github.com/void-linux/void-packages/pull/20821

Kindd: remove unnecessary dependencies
1. Let users [decide](https://github.com/LinArcX/kindd/#polkit) which polkit-agent is appropriate for them.
2. Remove unnecessary runtime dependencies like:
`polkit-gnome` , `qt5-quickcontrols2`, `qt5-declarative`, `qt5-svg`

A patch file from https://github.com/void-linux/void-packages/pull/20821.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kindd-remove-unrd-20821.patch --]
[-- Type: text/x-diff, Size: 1137 bytes --]

From 0345d9fdb702f60cb1b9e35bdb725be6d51db8e3 Mon Sep 17 00:00:00 2001
From: linarcx <linarcx@riseup.net>
Date: Fri, 10 Apr 2020 12:47:26 +0430
Subject: [PATCH] Kindd: remove unnecessary dependencies

---
 srcpkgs/kindd/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/kindd/template b/srcpkgs/kindd/template
index 87c6e6bdf7c..e634b0f69bf 100644
--- a/srcpkgs/kindd/template
+++ b/srcpkgs/kindd/template
@@ -1,11 +1,12 @@
 # Template file for 'kindd'
 pkgname=kindd
 version=2.1.0
-revision=1
+revision=2
 build_style=cmake
-hostmakedepends="cmake pkg-config qt5-qmake qt5-host-tools"
-makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel qt5-svg-devel"
-depends="polkit-gnome qt5-quickcontrols qt5-quickcontrols2 qt5-graphicaleffects  qt5-declarative qt5-svg"
+hostmakedepends="pkg-config qt5-qmake qt5-host-tools"
+makedepends="qt5-devel qt5-declarative-devel qt5-quickcontrols2-devel
+ qt5-svg-devel"
+depends="qt5-quickcontrols qt5-graphicaleffects qt5-svg"
 short_desc="Kindful dd, written by qt-quick"
 maintainer="linarcx <linarcx@gmail.com>"
 license="GPL-3.0-only"

Re: [PR PATCH] [Merged]: Kindd: remove unnecessary dependencies

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

There's a merged pull request on the void-packages repository

Kindd: remove unnecessary dependencies
https://github.com/void-linux/void-packages/pull/20821

Description:
1. Let users [decide](https://github.com/LinArcX/kindd/#polkit) which polkit-agent is appropriate for them.
2. Remove unnecessary runtime dependencies like:
`polkit-gnome` , `qt5-quickcontrols2`, `qt5-declarative`, `qt5-svg`