[ISSUE] GNU make-4.2 has issues with musl (glob)

[ISSUE] GNU make-4.2 has issues with musl (glob)

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

New issue by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21089

Description:
If any of you have noticed why linux5* builds are so slow with musl currently it's due to GNU make when it was downgraded to 4.2.

This version contains an obsolete glob implementation that is used by default with musl (see configure) that makes building linux5* with -jX not parallelize jobs as it should.

Try with current void make (4.2.x) `./xbps-src -jX linux5.6` and then compare with make 4.3.

Fix: update GNU glob implementation for 4.2 or update again to 4.3.

Your choice! I don't really care because I've fixed this on my tree...

Re: GNU make-4.2 has issues with musl (glob)

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615618905

Comment:
Well, I do care because when building many thousand *-musl packages here it makes a difference :)
Can you confirm the make-4.3 fnmatch and glob injection helps? It seems so to me because when I build e.g. `linux5.6-5.6.5` for `x86_64-musl` in a `x86_64-musl` chroot it really uses 30 threads.

Re: GNU make-4.2 has issues with musl (glob)

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615618905

Comment:
Well, I do care because when building many thousand *-musl packages here it makes a difference :) Can you confirm the make-4.3 fnmatch and glob injection helps? It seems so to me because when I build e.g. `linux5.6-5.6.5` for `x86_64-musl` in a `x86_64-musl` chroot it really uses 30 threads.

Re: GNU make-4.2 has issues with musl (glob)

[travankor]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615683725

Comment:
@xtraeme @pullmoll Appreciate the work you both do!

Thank you, jefe 👍

Re: GNU make-4.2 has issues with musl (glob)

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615833248

Comment:
@pullmoll wouldn't be better to update make to 4.3 and fix the issues with those two pkgs instead? 

Re: GNU make-4.2 has issues with musl (glob)

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615844776

Comment:
If anyone wants to do that, i.e. fix Aegisub and openjdk9-bootstrap with make-4.3, sure.
This PR is meant as a workaround in case no one cares - /me has sufficient other things on the list.

Re: GNU make-4.2 has issues with musl (glob)

[Gottox]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by Gottox on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615855454

Comment:
Is there a minimized testcase for that? I'm currently on LTE only, so I'd really like to avoid traffic intensive builds :D

Re: GNU make-4.2 has issues with musl (glob)

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615856347

Comment:
We don't know yet, but the only thing to trigger it is with linux5.x. I think linux4.x is not affected. I couldn't investigate what's the real reason.

Re: GNU make-4.2 has issues with musl (glob)

[q66]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615894221

Comment:
you can't "fix the issues with these two pkgs" as this is literally a regression in make, a bug.

Re: GNU make-4.2 has issues with musl (glob)

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615894860

Comment:
right, but rather than downgrading why do not fix the issues?

Re: GNU make-4.2 has issues with musl (glob)

[q66]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/21089#issuecomment-615896807

Comment:
feel free to

Re: [ISSUE] [CLOSED] GNU make-4.2 has issues with musl (glob)

[q66]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Closed issue by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21089

Description:
If any of you have noticed why linux5* builds are so slow with musl currently it's due to GNU make when it was downgraded to 4.2.

This version contains an obsolete glob implementation that is used by default with musl (see configure) that makes building linux5* with -jX not parallelize jobs as it should.

Try with current void make (4.2.x) `./xbps-src -jX linux5.6` and then compare with make 4.3.

Fix: update GNU glob implementation for 4.2 or update again to 4.3.

Your choice! I don't really care because I've fixed this on my tree...