[PR PATCH] Hooktftp

[PR PATCH] Hooktftp

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

There is a new pull request by Vaelatern against master on the void-packages repository

https://github.com/Vaelatern/void-packages hooktftp
https://github.com/void-linux/void-packages/pull/21194

Hooktftp
Side-downgrade to the latest git commit. I've talked to upstream about tagging actual releases so it can be better flagged as out of date. I've also talked about their packaging, and hope to encourage the software becoming more package able.

@thypon can I take maintainership? I found myself using this recently, found bugs in the ancient version we were using.

A patch file from https://github.com/void-linux/void-packages/pull/21194.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooktftp-21194.patch --]
[-- Type: text/x-diff, Size: 2343 bytes --]

From e1df3f7c8290640b588c452c81880d5cfdf67526 Mon Sep 17 00:00:00 2001
From: Toyam Cox <Vaelatern@voidlinux.org>
Date: Mon, 20 Apr 2020 19:16:52 -0400
Subject: [PATCH 1/2] hooktftp: Fails to drop privileges

---
 srcpkgs/hooktftp/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/hooktftp/template b/srcpkgs/hooktftp/template
index abee0ccefd1..f473c54496d 100644
--- a/srcpkgs/hooktftp/template
+++ b/srcpkgs/hooktftp/template
@@ -1,7 +1,7 @@
 # Template file for 'hooktftp'
 pkgname=hooktftp
 version=1.0.0
-revision=8
+revision=9
 _gitcommit="a7258310669522806b903c9ffc98ad7c62b02d56"
 wrksrc="${pkgname}-${_gitcommit}"
 hostmakedepends="go bzr git"

From 9fcfa426bce38157178be4096014aeea5e2fddb0 Mon Sep 17 00:00:00 2001
From: Toyam Cox <Vaelatern@voidlinux.org>
Date: Mon, 20 Apr 2020 19:41:44 -0400
Subject: [PATCH 2/2] hooktftp: update to 0.0.0.1.

---
 srcpkgs/hooktftp/template | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/srcpkgs/hooktftp/template b/srcpkgs/hooktftp/template
index f473c54496d..742b6afe6c3 100644
--- a/srcpkgs/hooktftp/template
+++ b/srcpkgs/hooktftp/template
@@ -1,24 +1,23 @@
 # Template file for 'hooktftp'
 pkgname=hooktftp
-version=1.0.0
-revision=9
-_gitcommit="a7258310669522806b903c9ffc98ad7c62b02d56"
+version=0.0.0.1
+revision=1
+reverts="1.0.0_1 1.0.0_2 1.0.0_3 1.0.0_4 1.0.0_5 1.0.0_6 1.0.0_7 1.0.0_8"
+_gitcommit="344d77c91960612bfddd8a918b0c1c4437349289"
 wrksrc="${pkgname}-${_gitcommit}"
-hostmakedepends="go bzr git"
+build_style=go
+go_import_path="github.com/tftp-go-team/hooktftp"
+go_package="github.com/tftp-go-team/hooktftp/src"
+hostmakedepends="bzr git"
 short_desc="Hook based tftp server"
-maintainer="Andrea Brancaleoni <abc@pompel.me>"
+maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
 license="MIT"
 homepage="https://github.com/tftp-go-team/hooktftp"
 distfiles="${homepage}/archive/${_gitcommit}.tar.gz"
-checksum=42cbe6c402aee13722cb55ac1e3a22fc6be27c6313b7c59d7a7277c0e3a6065e
-nocross=yes
-nopie=yes
+checksum=7030bf338c68cf9e3e22d85daf2e34b195603aa3ef30d6d1f726b4e4ee9cc3ec
 
-do_build() {
-	GOPATH=$PWD make build
-}
-
-do_install() {
+post_install() {
+	# I talked to upstream about this
+	mv ${DESTDIR}/usr/bin/src ${DESTDIR}/usr/bin/hooktftp
 	vlicense LICENSE
-	vbin src/${pkgname}
 }

Re: [PR PATCH] [Updated] Hooktftp

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

There is an updated pull request by Vaelatern against master on the void-packages repository

https://github.com/Vaelatern/void-packages hooktftp
https://github.com/void-linux/void-packages/pull/21194

Hooktftp
Side-downgrade to the latest git commit. I've talked to upstream about tagging actual releases so it can be better flagged as out of date. I've also talked about their packaging, and hope to encourage the software becoming more package able.

@thypon can I take maintainership? I found myself using this recently, found bugs in the ancient version we were using.

A patch file from https://github.com/void-linux/void-packages/pull/21194.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hooktftp-21194.patch --]
[-- Type: text/x-diff, Size: 1554 bytes --]

From 561cde6f8cedf91cb1d0e9a416201e9172f2577f Mon Sep 17 00:00:00 2001
From: Toyam Cox <Vaelatern@voidlinux.org>
Date: Mon, 20 Apr 2020 19:16:52 -0400
Subject: [PATCH] hooktftp: update to 1.1.0.

And adopt, since Vaelatern uses this now.
---
 srcpkgs/hooktftp/template | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/hooktftp/template b/srcpkgs/hooktftp/template
index abee0ccefd1..e1e669154b4 100644
--- a/srcpkgs/hooktftp/template
+++ b/srcpkgs/hooktftp/template
@@ -1,24 +1,18 @@
 # Template file for 'hooktftp'
 pkgname=hooktftp
-version=1.0.0
-revision=8
-_gitcommit="a7258310669522806b903c9ffc98ad7c62b02d56"
-wrksrc="${pkgname}-${_gitcommit}"
-hostmakedepends="go bzr git"
+version=1.1.0
+revision=1
+build_style=go
+go_import_path="github.com/tftp-go-team/hooktftp"
+go_package="github.com/tftp-go-team/hooktftp/cmd/hooktftp"
+hostmakedepends="bzr git"
 short_desc="Hook based tftp server"
-maintainer="Andrea Brancaleoni <abc@pompel.me>"
+maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
 license="MIT"
 homepage="https://github.com/tftp-go-team/hooktftp"
-distfiles="${homepage}/archive/${_gitcommit}.tar.gz"
-checksum=42cbe6c402aee13722cb55ac1e3a22fc6be27c6313b7c59d7a7277c0e3a6065e
-nocross=yes
-nopie=yes
+distfiles="https://github.com/tftp-go-team/hooktftp/archive/${version}.tar.gz"
+checksum=74a29947509a4a718091a5571cc2b2bdbfae807499f06beae124e78afdc56cf9
 
-do_build() {
-	GOPATH=$PWD make build
-}
-
-do_install() {
+post_install() {
 	vlicense LICENSE
-	vbin src/${pkgname}
 }

Re: Hooktftp

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21194#issuecomment-620069367

Comment:
@thypon was OK with it in IRC.

Re: [PR PATCH] [Merged]: Hooktftp

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

There's a merged pull request on the void-packages repository

Hooktftp
https://github.com/void-linux/void-packages/pull/21194

Description:
Side-downgrade to the latest git commit. I've talked to upstream about tagging actual releases so it can be better flagged as out of date. I've also talked about their packaging, and hope to encourage the software becoming more package able.

@thypon can I take maintainership? I found myself using this recently, found bugs in the ancient version we were using.