[PR PATCH] [RFC] vlicense hook

[PR PATCH] [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages vlicense-hook
https://github.com/void-linux/void-packages/pull/21272

[RFC] vlicense hook


A patch file from https://github.com/void-linux/void-packages/pull/21272.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vlicense-hook-21272.patch --]
[-- Type: text/x-diff, Size: 3443 bytes --]

From 6fbf6fa3e8b0503dff0adc428c5edeb19472a6c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx+sgn@gmail.com>
Date: Thu, 23 Apr 2020 22:29:35 +0700
Subject: [PATCH 1/3] hook: post-install: install $license_file

---
 common/hooks/post-install/13-vlicense.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 common/hooks/post-install/13-vlicense.sh

diff --git a/common/hooks/post-install/13-vlicense.sh b/common/hooks/post-install/13-vlicense.sh
new file mode 100644
index 00000000000..8b6724fd72d
--- /dev/null
+++ b/common/hooks/post-install/13-vlicense.sh
@@ -0,0 +1,16 @@
+# This hook install $license_file
+
+hook() {
+	local pair file target
+	cd "$wrksrc" || return 0
+	for pair in $license_file
+	do
+		file=${pair%:*}
+		if [ "$file" = "$pair" ]; then
+			target=
+		else
+			target=${pair#*:}
+		fi
+		vlicense "$file" "$target"
+	done
+}

From b74b4c485864aa70e41839199371e96b46ebbe00 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx+sgn@gmail.com>
Date: Thu, 23 Apr 2020 22:39:36 +0700
Subject: [PATCH 2/3] fortune-mod: show case new vlicense hook

---
 srcpkgs/fortune-mod/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/fortune-mod/template b/srcpkgs/fortune-mod/template
index 0eb27936c07..4ac0d9aed23 100644
--- a/srcpkgs/fortune-mod/template
+++ b/srcpkgs/fortune-mod/template
@@ -7,6 +7,7 @@ makedepends="recode-devel"
 short_desc="Implementation of the BSDGames 'fortune' program"
 maintainer="Tj Vanderpoel (bougyman) <tj@rubyists.com>"
 license="BSD-4-Clause-UC"
+license_file="LICENSE"
 homepage="http://www.redellipse.net/code/fortune"
 distfiles="${DEBIAN_SITE}/main/f/fortune-mod/${pkgname}_${version}.orig.tar.gz"
 checksum=fc51aee1f73c936c885f4e0f8b6b48f4f68103e3896eaddc6a45d2b71e14eace
@@ -35,5 +36,4 @@ do_install() {
 	make prefix=${DESTDIR} FORTDIR=${DESTDIR}/usr/bin \
 		COOKIEDIR=$DESTDIR/usr/share/fortunes \
 		install
-	vlicense LICENSE
 }

From 4bd855ae4b5a6ed040aa4ce8fb83cac2b681364a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx+sgn@gmail.com>
Date: Thu, 23 Apr 2020 22:40:13 +0700
Subject: [PATCH 3/3] lua-zlib: showcase complicated hook for vlicense

---
 srcpkgs/lua-zlib/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/lua-zlib/template b/srcpkgs/lua-zlib/template
index dfb6701cb62..8d35cf3743b 100644
--- a/srcpkgs/lua-zlib/template
+++ b/srcpkgs/lua-zlib/template
@@ -8,6 +8,7 @@ makedepends="lua51-devel lua52-devel lua-devel zlib-devel"
 short_desc="Zlib streamng interface for lua"
 maintainer="John Regan <john@jrjrtech.com>"
 license="MIT"
+license_file="lua53/README:LICENSE"
 homepage="https://github.com/brimworks/lua-zlib/"
 distfiles="${homepage}archive/v${version}.tar.gz"
 checksum=26b813ad39c94fc930b168c3418e2e746af3b2e80b92f94f306f6f954cc31e7d
@@ -53,21 +54,20 @@ do_install() {
 		  ${makejobs} install
 		)
 	done
-	vlicense "lua53/README"
 }
 
 lua51-zlib_package() {
 	short_desc+=" - Lua 5.1"
+	license_file="lua51/README:LICENSE"
 	pkg_install() {
 		vmove usr/lib/lua/5.1
-		vlicense "${wrksrc}/lua51/README"
 	}
 }
 
 lua52-zlib_package() {
 	short_desc+=" - Lua 5.2"
+	license_file="lua52/README:LICENSE"
 	pkg_install() {
 		vmove usr/lib/lua/5.2
-		vlicense "${wrksrc}/lua52/README"
 	}
 }

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618477203

Comment:
I haven't checked if we need to reset `$license_file` in subpkg.

Re: [RFC] vlicense hook

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618494542

Comment:
I don't see a (big) advantage over specifying `vlicense …` somewhere in `do_install()` or `post_install()`. You may save at most 2 lines in a template. And you cannot handle cases where the license file is created in e.g. `post_install()` from cropping some README.md, index.html or other source file.

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618732980

Comment:
On 2020-04-23 09:17:45-0700, Jürgen Buchmüller <notifications@github.com> wrote:
> I don't see a (big) advantage over specifying `vlicense …` somewhere
> in `do_install()` or `post_install()`.

How about using glob for LICENSE/COPYING?

> You may save at most 2 lines
> in a template. And you cannot handle cases where the license file is
> created in e.g. `post_install()` from cropping some README.md,
> index.html or other source file.

I think we should encourage those crops in patch phase instead.

-- 
Danh

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618753240

Comment:
> I don't see a (big) advantage over specifying `vlicense …` somewhere in `do_install()` or `post_install()`. You may save at most 2 lines in a template. And you cannot handle cases where the license file is created in e.g. `post_install()` from cropping some README.md, index.html or other source file.

The license file can still be created in `post_install()`, if `common/hooks/README` is accurate; the license hook will run after `post_install()`.

A `license_file` variable simplifies a very common use case for `post_install()`. Sure, it only saves two lines, but it makes the template a bit easier to read. (Assuming, of course, that the most common goal in reading a template is not to determine how the license is installed, but how the package is build, installed and packaged.) For more complicated license installations, specific templates can still opt to omit `license_file` and manually invoke `vlicense`.

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618753240

Comment:
> I don't see a (big) advantage over specifying `vlicense …` somewhere in `do_install()` or `post_install()`. You may save at most 2 lines in a template. And you cannot handle cases where the license file is created in e.g. `post_install()` from cropping some README.md, index.html or other source file.

The license file can still be created in `post_install()`, if `common/hooks/README` is accurate; the license hook will run after `post_install()`.

A `license_file` variable simplifies a very common use case for `post_install()`. Sure, it only saves two lines, but it makes the template a bit easier to read. (Assuming, of course, that the most common goal in reading a template is not to determine how the license is installed, but how the package is built, installed and packaged.) For more complicated license installations, specific templates can still opt to omit `license_file` and manually invoke `vlicense`.

Re: [RFC] vlicense hook

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618776079

Comment:
I want @leahneukirchen to review before this is merged. I personally think the addition of a human readable variable helps in quickly scanning templates for anything weird.

Re: [RFC] vlicense hook

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618917386

Comment:
I think it cleans up many templates that only need a hook to install the license.

Re: [RFC] vlicense hook

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618937350

Comment:
@Vaelatern are you the only one that decides who reviews and who commits? if so, why?

Re: [RFC] vlicense hook

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-618940342

Comment:
I was supposed to review it because I brought up the idea.

Re: [RFC] vlicense hook

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619031848

Comment:
@xtraeme Are you the only one who calls out what seems to be bad behavior? If so, why?

EUNHELPFUL.

Re: [RFC] vlicense hook

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619033742

Comment:
@Vaelatern because you think you are the owner of everything?

Re: [RFC] vlicense hook

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619038662

Comment:
Sounds like someone I know.

This thread is off topic. Are we merging this?

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619040261

Comment:
+1 to merge

Re: [RFC] vlicense hook

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619121451

Comment:
-1 to merge unless it is capable to replace all vlicense usages. It is missing installation of multiple files by glob, like `xorgproto` or `CLion`.

Re: [RFC] vlicense hook

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619125398

Comment:
I also suggest to use `license_file="SOURCE>TARGET"`.

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619162922

Comment:
On 2020-04-24 09:40:41-0700, Piotr <notifications@github.com> wrote:
> -1 to merge unless it is capable to replace all vlicense usages. It
> is missing installation of multiple files by glob, like `xorgproto`
> or `CLion`.

I think multiple files is handled by now, and glob should be handled,
too (I need to check again, though).

-- 
Danh

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619164236

Comment:
On 2020-04-24 09:48:20-0700, Leah Neukirchen <notifications@github.com> wrote:
> I also suggest to use `license_file="SOURCE>TARGET"`.

s/:/>/ is _NOT_ a big deal,

I'm thinking about the glob. Allowing glob will need shell word
expansion and the consequence for "glob*>target"

-- 
Danh

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619164430

Comment:
> I also suggest to use `license_file="SOURCE>TARGET"`.

I second the greater-than syntax. It parallels its use in `distfiles` to mean "take this and move it here".

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619166057

Comment:
> -1 to merge unless it is capable to replace all vlicense usages. It is missing installation of multiple files by glob, like `xorgproto` or `CLion`.

If `vlicense` remains available, why require that `license_files` be capable of replacing these more complicated uses? Allowing globs will, as @sgn points out, present some challengs for renaming syntax. Also, they will harm, rather than help, the readability that this change is meant to improve.

I think `license_files` makes good syntactic sugar to simplify simple license installations; fall back to manual `vlicense` where complexity demands.

Re: [RFC] vlicense hook

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619170400

Comment:
> I think `license_files` makes good syntactic sugar to simplify simple license installations; fall back to manual `vlicense` where complexity demands.

So is it too confusing to have two ways to do things? I think not: distfiles works similarly, you can fetch if you must.

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619172951

Comment:
> > I think `license_files` makes good syntactic sugar to simplify simple license installations; fall back to manual `vlicense` where complexity demands.
> 
> So is it too confusing to have two ways to do things? I think not: distfiles works similarly, you can fetch if you must.

No, to the contrary, I think having `license_files` as an alternative to manual `vinstall` is a beneficial change. But I don't think the `license_files` variable needs to handle globs and things. Make each space-separated component of  `license_files` a single file to be installed, possibly with a rename indicated by '>'.

But if it makes sense to do something more complicated like glob matching for installing multiple license files in one pass, leave that for manual work in one of the build/install hooks.

Re: [RFC] vlicense hook

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619189658

Comment:
I like that `license_files` is placed close to `license`, so its easy to verify, but if we are leave vlicense as option, we'll end up with most of old templates using vlicense, half of new using license_files and half of new using vlicense, i.e. a mess that do not ease reviewing.

I prefer single solution; either staying with vlicense because it works well; or introducing license_files that handles almost all cases, i.e files and globs, banning vlicense and using vinstall (possibly with $LICENSEDIR) for corner cases; over another TIMTOWTDI.

Re: [RFC] vlicense hook

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619291031

Comment:
Or maybe we could teach vinstall to install directories, what will be useful on its own, then copy licenses by glob, and put directory into license_files.

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-619463536

Comment:
> Or maybe we could teach vinstall to install directories,
> what will be useful on its own, then copy licenses by glob,
> and put directory into license_files.

Is this over-complicated?

If we decide to do glob, I'll do it in `license_files` instead.

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621552115

Comment:
Thinking about it now.
I think the glob is too complicated and may not worth our effort.

I think we should add checksum for $license_files instead.
It will force people check if license was changed, it's unusual to change LICENSE file, except bump year, or change license.
This is used by Open Embedded.

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621593783

Comment:
Is license change a common enough problem that it's worth adding a checksum? The point of `license_files` is to simplify license installation, not increase the burden.

Re: [RFC] vlicense hook

[Anachron]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621613193

Comment:
I've seen examples of "sed"ed License files from the source. Just a FYI that those might be one of the corner cases.

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621682684

Comment:
> Is license change a common enough problem that
> it's worth adding a checksum? The point of `license_files` is
> to simplify license installation, not increase the burden.

The point is: license should be changed _very_ rarely.
If there's a change in LICENSE, we need to know and update the license field.
Hence, I think adding a checksum makes more sense to me.

Re: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621683342

Comment:
> I've seen examples of "sed"ed License files from the source.
> Just a FYI that those might be one of the corner cases.

Yes, it's one common case, I've made some LICENSE like that.
We could put that `sed` into `post_patch`.

Re: [RFC] vlicense hook

[travankor]

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621772055

Comment:
>I think we should add checksum for $license_files instead.
It will force people check if license was changed, it's unusual to change LICENSE file, except bump year, or change license.
This is used by Open Embedded.

I don't like this approach, personally.
This will make too many false positives if they change contributors or update the year. Additionally, it increases work for all packages for a not 100% reliable detection check.

>If there's a change in LICENSE, we need to know and update the license field.
Hence, I think adding a checksum makes more sense to me.

If a project relicenses, this must be noted in the changelog, and updaters have to read the changelog. Relicensing only happens rarely (e.g. Openssl -> Apache, LLVM -> Apache), too.

Re: [RFC] vlicense hook

[travankor]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621773891

Comment:
>Thinking about it now.
I think the glob is too complicated and may not worth our effort.

I don't think if it's implementation is complicated it is bad. As long as the template is simple for packagers, I am fine. xbps-src and bash have complex implementations already.

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621778708

Comment:
> > Is license change a common enough problem that
> > it's worth adding a checksum? The point of `license_files` is
> > to simplify license installation, not increase the burden.
> 
> The point is: license should be changed _very_ rarely.
> If there's a change in LICENSE, we need to know and update the license field.
> Hence, I think adding a checksum makes more sense to me.

The rarity of relicensing militates against adding a checksum. Adding more burden on the packagers just to catch some corner cases doesn't seem to be worthwhile.

Furthermore, this would only be an issue if a project changed the license from something that shouldn't be installed (e.g., Apache-2.0 or one of the GPL versions) to something that should be installed. Most of those cases would be moving away from GPL (6933 templates in `void-packages` reference GPL; only 702 reference Apache; only 105 reference GFDL), but I suspect (based purely on anecdotes) that almost no projects that adopt the GPL tend to move away from it---license churn seems to happen more among other licenses.

If a package already requires `vlicense` and changes to another license, the package metadata may be wrong, but the package will still install the correct license on disk.

This seems like a practical non-issue to me.

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621781940

Comment:
> Thinking about it now.
> I think the glob is too complicated and may not worth our effort.

I'm lukewarm on glob support in `license_files`. Sure, there is some appeal in being able to say
```
license_file="LICENSE*.txt"
```
but is it worth complicating the implementation?

If glob support is a must, I certainly wouldn't try to support renames during the globs. Either the matches are copied with their original names, or indiviual files can be listed with `source>dest` pairs. Trying to batch-rename globs is a recipe for disaster.

Re: [RFC] vlicense hook

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621781940

Comment:
> Thinking about it now.
> I think the glob is too complicated and may not worth our effort.

I'm lukewarm on glob support in `license_files`. Sure, there is some appeal in being able to say
```
license_files="LICENSE*.txt"
```
but is it worth complicating the implementation?

If glob support is a must, I certainly wouldn't try to support renames during the globs. Either the matches are copied with their original names, or indiviual files can be listed with `source>dest` pairs. Trying to batch-rename globs is a recipe for disaster.

Re: [RFC] vlicense hook

[travankor]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

New comment by travankor on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621773891

Comment:
>Thinking about it now.
I think the glob is too complicated and may not worth our effort.

I don't think if its implementation is complicated it is bad. As long as the template is simple for packagers, I am fine. xbps-src and bash have complex implementations already.

Re: [RFC] vlicense hook

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-621899675

Comment:
I'd rather the hook be used for simple cases, and vlicense whenever anything gets complicated. Not supporting complicated things that just increase work for all like checksumming or globbing.

Re: [RFC] vlicense hook

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-622010268

Comment:
> I'd rather the hook be used for simple cases, and vlicense whenever anything gets complicated.
> So is it too confusing to have two ways to do things?

Yes, I think having two ways is too complicated. There will be need to look for license files in two parts of template while reviewing.
People are used to call vlicense, so they will be calling it in new templates: should we accept this? Will existing vlicense calls stay? Hook seem to work with sedding, but is it simple case?

Below is hook mod that handle globs. It fails if no file is matched by glob.

``` bash
# This hook install $license_file

hook() {
	local pair file target found
	cd "$wrksrc" || return 0
	for pair in $license_file
	do
		file=${pair%:*}
		if [ "$file" = "$pair" ]; then
			for i in $file; do
				vlicense "$i"
				found=yes
			done
		else
			target=${pair#*:}
			vlicense "$file" "$target"
		fi
	done
}
```

Re: [RFC] vlicense hook

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-622010268

Comment:
> I'd rather the hook be used for simple cases, and vlicense whenever anything gets complicated.
> So is it too confusing to have two ways to do things?

Yes, I think having two ways is too complicated. There will be need to look for license files in two parts of template while reviewing.
People are used to call vlicense, so they will be calling it in new templates: should we accept this? Will existing vlicense calls stay? Hook seem to work with sedding, but is it simple case?

Below is hook mod that handle globs. It fails if no file is matched by glob.

``` bash
# This hook install $license_file

hook() {
	local pair file target
	cd "$wrksrc" || return 0
	for pair in $license_file
	do
		file=${pair%:*}
		if [ "$file" = "$pair" ]; then
			for i in $file; do
				vlicense "$i"
			done
		else
			target=${pair#*:}
			vlicense "$file" "$target"
		fi
	done
}
```

Re: [RFC] vlicense hook

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-622025268

Comment:
Oh. In fact, hook already handles globs, as they are expanded under for.

Re: [RFC] vlicense hook

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21272#issuecomment-622010268

Comment:
> I'd rather the hook be used for simple cases, and vlicense whenever anything gets complicated.
> So is it too confusing to have two ways to do things?

Yes, I think having two ways is too complicated. There will be need to look for license files in two parts of template while reviewing.
People are used to call vlicense, so they will be calling it in new templates: should we accept this? Will existing vlicense calls stay? Hook seem to work with sedding, but is it simple case?

~Below is hook mod that handle globs. It fails if no file is matched by glob.~

Re: [PR PATCH] [Closed]: [RFC] vlicense hook

[sgn]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

There's a closed pull request on the void-packages repository

[RFC] vlicense hook
https://github.com/void-linux/void-packages/pull/21272

Description: