[ISSUE] Minio runit script changes permissions of shared directories

[ISSUE] Minio runit script changes permissions of shared directories

[ObscureScience]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

New issue by ObscureScience on void-packages repository

https://github.com/void-linux/void-packages/issues/21589

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.6.8_1 x86_64-musl GenuineIntel uptodate rFF
* package:  
  minio-2020.04.28_1 Object storage server compatible with Amazon S3

### Expected behavior
Service to fail when no granted sufficient permissons to provided data
### Actual behavior
On every `sv start minio` the script first recusively changes ownership of shared data to _minio:_minio. Not only does this seem excessive and often unwanted, it can also take very long time depending on the nature of the shared data.
### Steps to reproduce the behavior
`xbps-install minio`
`ln -s /etc/sv/minio /var/service/`
`sv start minio`
Quick link to the [runscript](https://github.com/void-linux/void-packages/blob/4a00d41d3d4757f443b56899010f420f718a4672/srcpkgs/minio/files/minio/run)

Re: Minio runit script changes permissions of shared directories

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/21589#issuecomment-623213765

Comment:
@arete I'll push this:
```diff
 srcpkgs/minio/files/minio/run |  3 +--
 srcpkgs/minio/template        | 10 ++++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/minio/files/minio/run b/srcpkgs/minio/files/minio/run
index af23959022..ecea96356c 100755
--- a/srcpkgs/minio/files/minio/run
+++ b/srcpkgs/minio/files/minio/run
@@ -1,5 +1,4 @@
 #!/bin/sh
 . /etc/default/minio
 : ${MINIO_VOLUMES:="/var/lib/minio/data/"}
-chown -R  _minio:_minio $MINIO_VOLUMES
-exec chpst -u _minio:_minio minio -C /etc/minio/ server $MINIO_VOLUMES 
+exec chpst -u _minio:_minio minio -C /etc/minio/ server "$MINIO_VOLUMES"
diff --git a/srcpkgs/minio/template b/srcpkgs/minio/template
index 94f69fb269..92650294b9 100644
--- a/srcpkgs/minio/template
+++ b/srcpkgs/minio/template
@@ -1,15 +1,12 @@
 # Template file for 'minio'
 pkgname=minio
 version=2020.04.28
-revision=1
+revision=2
 _version="${version//./-}T23-56-56Z"
 wrksrc=${pkgname}-RELEASE.${_version}
 build_style=go
 go_import_path="github.com/minio/minio"
-_minio_homedir="/var/lib/minio"
-_minio_descr="Minio Daemon User"
 conf_files="/etc/default/minio /etc/minio/config.json"
-make_dirs="/etc/minio 0755 _minio _minio /var/lib/minio 0755 _minio _minio"
 hostmakedepends="git"
 short_desc="Object storage server compatible with Amazon S3"
 maintainer="Gerardo Di Iorio <arete74@gmail.com>"
@@ -18,6 +15,11 @@ homepage="https://github.com/minio/minio"
 distfiles="${homepage}/archive/RELEASE.${_version}.tar.gz"
 checksum=40c4e0da91c176351381da42f6f9cf8a8ff548d67668baf1a838138e4c2bd5d5
 system_accounts="_minio"
+_minio_homedir="/var/lib/minio"
+_minio_descr="Minio Daemon User"
+make_dirs="/etc/minio 0755 _minio _minio
+ /var/lib/minio 0755 _minio _minio
+ /var/lib/minio/data 0755 _minio _minio"
 
 do_check() {
 	:
```

Re: Minio runit script changes permissions of shared directories

[sgn]

[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/21589#issuecomment-623213765

Comment:
@arete I'll push this (if you don't have any objection):
```diff
 srcpkgs/minio/files/minio/run |  3 +--
 srcpkgs/minio/template        | 10 ++++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/minio/files/minio/run b/srcpkgs/minio/files/minio/run
index af23959022..ecea96356c 100755
--- a/srcpkgs/minio/files/minio/run
+++ b/srcpkgs/minio/files/minio/run
@@ -1,5 +1,4 @@
 #!/bin/sh
 . /etc/default/minio
 : ${MINIO_VOLUMES:="/var/lib/minio/data/"}
-chown -R  _minio:_minio $MINIO_VOLUMES
-exec chpst -u _minio:_minio minio -C /etc/minio/ server $MINIO_VOLUMES 
+exec chpst -u _minio:_minio minio -C /etc/minio/ server "$MINIO_VOLUMES"
diff --git a/srcpkgs/minio/template b/srcpkgs/minio/template
index 94f69fb269..92650294b9 100644
--- a/srcpkgs/minio/template
+++ b/srcpkgs/minio/template
@@ -1,15 +1,12 @@
 # Template file for 'minio'
 pkgname=minio
 version=2020.04.28
-revision=1
+revision=2
 _version="${version//./-}T23-56-56Z"
 wrksrc=${pkgname}-RELEASE.${_version}
 build_style=go
 go_import_path="github.com/minio/minio"
-_minio_homedir="/var/lib/minio"
-_minio_descr="Minio Daemon User"
 conf_files="/etc/default/minio /etc/minio/config.json"
-make_dirs="/etc/minio 0755 _minio _minio /var/lib/minio 0755 _minio _minio"
 hostmakedepends="git"
 short_desc="Object storage server compatible with Amazon S3"
 maintainer="Gerardo Di Iorio <arete74@gmail.com>"
@@ -18,6 +15,11 @@ homepage="https://github.com/minio/minio"
 distfiles="${homepage}/archive/RELEASE.${_version}.tar.gz"
 checksum=40c4e0da91c176351381da42f6f9cf8a8ff548d67668baf1a838138e4c2bd5d5
 system_accounts="_minio"
+_minio_homedir="/var/lib/minio"
+_minio_descr="Minio Daemon User"
+make_dirs="/etc/minio 0755 _minio _minio
+ /var/lib/minio 0755 _minio _minio
+ /var/lib/minio/data 0755 _minio _minio"
 
 do_check() {
 	:
```

Re: [ISSUE] [CLOSED] Minio runit script changes permissions of shared directories

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

Closed issue by ObscureScience on void-packages repository

https://github.com/void-linux/void-packages/issues/21589

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.6.8_1 x86_64-musl GenuineIntel uptodate rFF
* package:  
  minio-2020.04.28_1 Object storage server compatible with Amazon S3

### Expected behavior
Service to fail when not granted sufficient permissons to provided data
### Actual behavior
On every `sv start minio` the script first recusively changes ownership of shared/exported data to _minio:_minio. Not only does this seem excessive and often unwanted, it can also take very long time depending on the nature of the shared data.
### Steps to reproduce the behavior
`xbps-install minio`
`ln -s /etc/sv/minio /var/service/`
`sv start minio`
Quick link to the [runscript](https://github.com/void-linux/void-packages/blob/4a00d41d3d4757f443b56899010f420f718a4672/srcpkgs/minio/files/minio/run)