[PR PATCH] iverilog: fix crash in lxt2 dump.

[PR PATCH] iverilog: fix crash in lxt2 dump.

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is a new pull request by jnbr against master on the void-packages repository

https://github.com/jnbr/void-packages iverilog
https://github.com/void-linux/void-packages/pull/21896

iverilog: fix crash in lxt2 dump.


A patch file from https://github.com/void-linux/void-packages/pull/21896.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iverilog-21896.patch --]
[-- Type: text/x-diff, Size: 1924 bytes --]

From fd340af3c5cd5b08838c302e5235ba9fcc7958fe Mon Sep 17 00:00:00 2001
From: Johannes <johannes.brechtmann@gmail.com>
Date: Tue, 12 May 2020 22:02:13 +0200
Subject: [PATCH] iverilog: fix crash in lxt2 dump.

---
 srcpkgs/iverilog/patches/lxt2.patch | 15 +++++++++++++++
 srcpkgs/iverilog/template           |  4 ++--
 2 files changed, 17 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/iverilog/patches/lxt2.patch

diff --git a/srcpkgs/iverilog/patches/lxt2.patch b/srcpkgs/iverilog/patches/lxt2.patch
new file mode 100644
index 00000000000..ae1918a7138
--- /dev/null
+++ b/srcpkgs/iverilog/patches/lxt2.patch
@@ -0,0 +1,15 @@
+vcd_work_terminate() calls pthread_join() on a static thread.
+Do not call vcd_work_terminate() in close_dumpfile() because it was already
+called before, leading to a second call to pthread_join() on the same pthread,
+which is undefined behaviour.
+
+--- vpi/sys_lxt2.c.orig	2020-05-13 00:25:45.070186668 +0200
++++ vpi/sys_lxt2.c	2020-05-13 00:26:09.721185704 +0200
+@@ -472,7 +472,6 @@
+ 
+ static void *close_dumpfile(void)
+ {
+-      vcd_work_terminate();
+       lxt2_wr_close(dump_file);
+       dump_file = NULL;
+       return NULL;
diff --git a/srcpkgs/iverilog/template b/srcpkgs/iverilog/template
index 971cf2a8e12..44f1c8e0ae8 100644
--- a/srcpkgs/iverilog/template
+++ b/srcpkgs/iverilog/template
@@ -1,13 +1,13 @@
 # Template file for 'iverilog'
 pkgname=iverilog
 version=10.3
-revision=1
+revision=2
 wrksrc="${pkgname}-${version/./_}"
 build_style=gnu-configure
 hostmakedepends="automake flex gperf"
 makedepends="readline-devel zlib-devel"
 short_desc="Verilog simulation and synthesis tool"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Johannes <johannes.brechtmann@gmail.com>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
 homepage="http://iverilog.icarus.com/"
 distfiles="https://github.com/steveicarus/iverilog/archive/v${version/./_}.tar.gz"

Re: [PR PATCH] [Merged]: iverilog: fix crash in lxt2 dump.

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

There's a merged pull request on the void-packages repository

iverilog: fix crash in lxt2 dump.
https://github.com/void-linux/void-packages/pull/21896

Description: