* [PR PATCH] bookworm: add missing dependencies
@ 2020-05-16 7:56 not-chicken
2020-05-16 8:52 ` [PR PATCH] [Merged]: " Chocimier
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: not-chicken @ 2020-05-16 7:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
There is a new pull request by not-chicken against master on the void-packages repository
https://github.com/not-chicken/void-packages book
https://github.com/void-linux/void-packages/pull/22005
bookworm: add missing dependencies
- `unzip` is needed for unpacking `epub` , `cbz` and `fb2` files.
- `unar` is needed for unpacking `cbr` files.
Upstream has added support for python 3 but there hasn't been a new release yet. So adding comment alongside `python_version` as a reminder.
Issue was reported on reddit: https://www.reddit.com/r/voidlinux/comments/gkjcue/bookworm/
A patch file from https://github.com/void-linux/void-packages/pull/22005.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-book-22005.patch --]
[-- Type: text/x-diff, Size: 1250 bytes --]
From 6f085e0f618f157a258e191fe61e3a7567f757cc Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sat, 16 May 2020 13:11:25 +0530
Subject: [PATCH] bookworm: add missing dependencies
---
srcpkgs/bookworm/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/bookworm/template b/srcpkgs/bookworm/template
index 9dc0d982067..65eafc35512 100644
--- a/srcpkgs/bookworm/template
+++ b/srcpkgs/bookworm/template
@@ -1,17 +1,17 @@
# Template file for 'bookworm'
pkgname=bookworm
version=1.1.2
-revision=1
+revision=2
build_style=meson
hostmakedepends="pkg-config glib-devel vala"
makedepends="gtk+3-devel libgee08-devel granite-devel
webkit2gtk-devel sqlite-devel poppler-glib-devel
libxml2-devel glib-devel"
-depends="poppler"
+depends="poppler unzip unar"
short_desc="Simple, focused eBook reader"
maintainer="Giuseppe Fierro <gspe@ae-design.ws>"
license="GPL-3.0-or-later"
homepage="https://babluboy.github.io/bookworm"
distfiles="https://github.com/babluboy/${pkgname}/archive/${version}.tar.gz"
checksum=6d27e55697debfa08f7cc15805413b74c94c55111cdf2d333b306228eccad824
-python_version=2 #unverified
+python_version=2 # Should be set to python3 when updated to version > 1.1.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: bookworm: add missing dependencies
2020-05-16 7:56 [PR PATCH] bookworm: add missing dependencies not-chicken
@ 2020-05-16 8:52 ` Chocimier
2020-05-16 20:49 ` q66
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-05-16 8:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
There's a merged pull request on the void-packages repository
bookworm: add missing dependencies
https://github.com/void-linux/void-packages/pull/22005
Description:
- `unzip` is needed for unpacking `epub` , `cbz` and `fb2` files.
- `unar` is needed for unpacking `cbr` files.
Edit: Should I python2 as a rundep for the time being? `mobi` files won't open if it ain't installed.
Upstream has added support for python 3 but there hasn't been a new release yet. So adding comment alongside `python_version` as a reminder.
Issue was reported on reddit: https://www.reddit.com/r/voidlinux/comments/gkjcue/bookworm/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bookworm: add missing dependencies
2020-05-16 7:56 [PR PATCH] bookworm: add missing dependencies not-chicken
2020-05-16 8:52 ` [PR PATCH] [Merged]: " Chocimier
@ 2020-05-16 20:49 ` q66
2020-05-16 20:56 ` Chocimier
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: q66 @ 2020-05-16 20:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/22005#issuecomment-629703933
Comment:
this means the package won't build on musl anymore (unar is missing)
so either that should be fixed, or someone should clean the old version from musl repos
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bookworm: add missing dependencies
2020-05-16 7:56 [PR PATCH] bookworm: add missing dependencies not-chicken
2020-05-16 8:52 ` [PR PATCH] [Merged]: " Chocimier
2020-05-16 20:49 ` q66
@ 2020-05-16 20:56 ` Chocimier
2020-05-16 21:04 ` Chocimier
2020-05-16 21:42 ` not-chicken
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-05-16 20:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/22005#issuecomment-629704745
Comment:
Let it not depend on unar on musl then.
I got tricked by travis' green mark.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bookworm: add missing dependencies
2020-05-16 7:56 [PR PATCH] bookworm: add missing dependencies not-chicken
` (2 preceding siblings ...)
2020-05-16 20:56 ` Chocimier
@ 2020-05-16 21:04 ` Chocimier
2020-05-16 21:42 ` not-chicken
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-05-16 21:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/22005#issuecomment-629705543
Comment:
unar is also nocross, maybe it should be back optional.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: bookworm: add missing dependencies
2020-05-16 7:56 [PR PATCH] bookworm: add missing dependencies not-chicken
` (3 preceding siblings ...)
2020-05-16 21:04 ` Chocimier
@ 2020-05-16 21:42 ` not-chicken
4 siblings, 0 replies; 6+ messages in thread
From: not-chicken @ 2020-05-16 21:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
New comment by not-chicken on void-packages repository
https://github.com/void-linux/void-packages/pull/22005#issuecomment-629709628
Comment:
oopsie! Green fooled me too.
> unar is also nocross, maybe it should be back optional.
That seems like the best course of action here to me.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-16 21:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-16 7:56 [PR PATCH] bookworm: add missing dependencies not-chicken
2020-05-16 8:52 ` [PR PATCH] [Merged]: " Chocimier
2020-05-16 20:49 ` q66
2020-05-16 20:56 ` Chocimier
2020-05-16 21:04 ` Chocimier
2020-05-16 21:42 ` not-chicken
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).