Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] libglvnd: remove excess devel deps, grep license
@ 2020-05-16  9:15 st3r4g
  2020-05-16 10:14 ` Chocimier
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16  9:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

There is a new pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages libglvnd-remove-devel-deps
https://github.com/void-linux/void-packages/pull/22008

libglvnd: remove excess devel deps, grep license
Tested building `glu` and `mesa`

A patch file from https://github.com/void-linux/void-packages/pull/22008.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libglvnd-remove-devel-deps-22008.patch --]
[-- Type: text/x-diff, Size: 1189 bytes --]

From 727d8654bad103d2ccacd6655c579b3638336261 Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Sat, 16 May 2020 10:56:27 +0200
Subject: [PATCH] libglvnd: remove excess devel deps, grep license

---
 srcpkgs/libglvnd/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libglvnd/template b/srcpkgs/libglvnd/template
index b12cb41e6d5..08be3a8ffa7 100644
--- a/srcpkgs/libglvnd/template
+++ b/srcpkgs/libglvnd/template
@@ -1,7 +1,7 @@
 # Template file for 'libglvnd'
 pkgname=libglvnd
 version=1.3.1
-revision=1
+revision=2
 wrksrc="libglvnd-v${version}"
 build_style=meson
 hostmakedepends="pkg-config"
@@ -27,12 +27,12 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 post_install() {
-	$XBPS_FETCH_CMD "https://git.archlinux.org/svntogit/packages.git/plain/trunk/LICENSE?h=packages/libglvnd>LICENSE"
+	grep -A 25 "Copyright (c) 2013, NVIDIA CORPORATION." README.md > LICENSE
 	vlicense LICENSE
 }
 
 libglvnd-devel_package() {
-	depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}-${version}_${revision}"
 	conflicts="MesaLib-devel<19.2.5_2"
 	short_desc+=" - development files"
 	pkg_install() {

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
@ 2020-05-16 10:14 ` Chocimier
  2020-05-16 10:33 ` st3r4g
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2020-05-16 10:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629622502

Comment:
makedepends are usually added to depends of -devel, because headers include headers from that packages. What's different here?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
  2020-05-16 10:14 ` Chocimier
@ 2020-05-16 10:33 ` st3r4g
  2020-05-16 10:33 ` st3r4g
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 10:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629624807

Comment:
Sorry, removing all `${makedepends}` is wrong, `libX11-devel` is indeed required. In general though not all `mekedepends` necessarily are required as deps for the devel package, I'll see if the other two actually are

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
  2020-05-16 10:14 ` Chocimier
  2020-05-16 10:33 ` st3r4g
@ 2020-05-16 10:33 ` st3r4g
  2020-05-16 10:33 ` st3r4g
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 10:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629624807

Comment:
Sorry, removing all `${makedepends}` is wrong, `libX11-devel` is indeed required. In general though not all `makedepends` necessarily are required as deps for the devel package, I'll see if the other two actually are

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (2 preceding siblings ...)
  2020-05-16 10:33 ` st3r4g
@ 2020-05-16 10:33 ` st3r4g
  2020-05-16 10:41 ` st3r4g
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 10:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629624807

Comment:
Sorry, removing all `${makedepends}` is wrong, at least `libX11-devel` is indeed required. In general though not all `makedepends` necessarily are required as deps for the devel package, I'll see if the other two actually are

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (3 preceding siblings ...)
  2020-05-16 10:33 ` st3r4g
@ 2020-05-16 10:41 ` st3r4g
  2020-05-16 10:41 ` st3r4g
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 10:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629624807

Comment:
Sorry, removing all `${makedepends}` is wrong, at least `libX11-devel` is indeed required. In general though not all `makedepends` necessarily are required as deps for the devel package, I'll see if the other two actually are. Also I should test an actual application doing GLX calls and not just libraries

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (4 preceding siblings ...)
  2020-05-16 10:41 ` st3r4g
@ 2020-05-16 10:41 ` st3r4g
  2020-05-16 11:57 ` st3r4g
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 10:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629624807

Comment:
Sorry, removing all `${makedepends}` is wrong, at least `libX11-devel` is indeed required. In general though not all `makedepends` necessarily are required as deps for the devel package, I'll see if the other two actually are. Also I should test compiling an actual application doing GLX calls and not just libraries

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (5 preceding siblings ...)
  2020-05-16 10:41 ` st3r4g
@ 2020-05-16 11:57 ` st3r4g
  2020-05-16 12:23 ` st3r4g
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 11:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629634493

Comment:
I think `libXext-devel xorgproto` are required internally and not propagated to public headers, but meaningful testing is annoying because these are also pulled in by other -devel dependencies (when trying to build e.g. `mesa-demos`)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (6 preceding siblings ...)
  2020-05-16 11:57 ` st3r4g
@ 2020-05-16 12:23 ` st3r4g
  2020-05-16 12:39 ` st3r4g
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 12:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629634493

Comment:
I think `libXext-devel xorgproto` are required internally and not propagated to public headers, but meaningful testing is annoying because these are also pulled in by other -devel dependencies (when trying to build e.g. `mesa-demos`) EDIT: `mesa-demos` requires xext by itself, so useless to test with it

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (7 preceding siblings ...)
  2020-05-16 12:23 ` st3r4g
@ 2020-05-16 12:39 ` st3r4g
  2020-05-16 12:42 ` [PR PATCH] [Updated] " st3r4g
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629634493

Comment:
I think `libXext-devel xorgproto` are required internally and not propagated to public headers, but meaningful testing is annoying because these are also pulled in by other -devel dependencies (when trying to build e.g. `mesa-demos`) EDIT: `mesa-demos` requires xext by itself, so useless to test with it, tested `xdriinfo` and `glmark2`

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (8 preceding siblings ...)
  2020-05-16 12:39 ` st3r4g
@ 2020-05-16 12:42 ` st3r4g
  2020-05-16 12:43 ` st3r4g
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 12:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

There is an updated pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages libglvnd-remove-devel-deps
https://github.com/void-linux/void-packages/pull/22008

libglvnd: remove excess devel deps, grep license
Tested building `glu` and `mesa`

A patch file from https://github.com/void-linux/void-packages/pull/22008.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libglvnd-remove-devel-deps-22008.patch --]
[-- Type: text/x-diff, Size: 1189 bytes --]

From fbf081991306481851e2ca83b44b036c6a375300 Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Sat, 16 May 2020 10:56:27 +0200
Subject: [PATCH] libglvnd: remove excess devel deps, grep license

---
 srcpkgs/libglvnd/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libglvnd/template b/srcpkgs/libglvnd/template
index b12cb41e6d5..08be3a8ffa7 100644
--- a/srcpkgs/libglvnd/template
+++ b/srcpkgs/libglvnd/template
@@ -1,7 +1,7 @@
 # Template file for 'libglvnd'
 pkgname=libglvnd
 version=1.3.1
-revision=1
+revision=2
 wrksrc="libglvnd-v${version}"
 build_style=meson
 hostmakedepends="pkg-config"
@@ -27,12 +27,12 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 post_install() {
-	$XBPS_FETCH_CMD "https://git.archlinux.org/svntogit/packages.git/plain/trunk/LICENSE?h=packages/libglvnd>LICENSE"
+	grep -A 25 "Copyright (c) 2013, NVIDIA CORPORATION." README.md > LICENSE
 	vlicense LICENSE
 }
 
 libglvnd-devel_package() {
-	depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+	depends="${sourcepkg}-${version}_${revision}"
 	conflicts="MesaLib-devel<19.2.5_2"
 	short_desc+=" - development files"
 	pkg_install() {

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (9 preceding siblings ...)
  2020-05-16 12:42 ` [PR PATCH] [Updated] " st3r4g
@ 2020-05-16 12:43 ` st3r4g
  2020-05-16 12:46 ` st3r4g
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 12:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

There is an updated pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages libglvnd-remove-devel-deps
https://github.com/void-linux/void-packages/pull/22008

libglvnd: remove excess devel deps, grep license
Tested building `glu` and `mesa`

A patch file from https://github.com/void-linux/void-packages/pull/22008.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libglvnd-remove-devel-deps-22008.patch --]
[-- Type: text/x-diff, Size: 1202 bytes --]

From 37b05f9d4c89be9f479e37868f57e479a8a31e3e Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Sat, 16 May 2020 10:56:27 +0200
Subject: [PATCH] libglvnd: remove excess devel deps, grep license

---
 srcpkgs/libglvnd/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libglvnd/template b/srcpkgs/libglvnd/template
index b12cb41e6d5..28a666d66e2 100644
--- a/srcpkgs/libglvnd/template
+++ b/srcpkgs/libglvnd/template
@@ -1,7 +1,7 @@
 # Template file for 'libglvnd'
 pkgname=libglvnd
 version=1.3.1
-revision=1
+revision=2
 wrksrc="libglvnd-v${version}"
 build_style=meson
 hostmakedepends="pkg-config"
@@ -27,12 +27,12 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 post_install() {
-	$XBPS_FETCH_CMD "https://git.archlinux.org/svntogit/packages.git/plain/trunk/LICENSE?h=packages/libglvnd>LICENSE"
+	grep -A 25 "Copyright (c) 2013, NVIDIA CORPORATION." README.md > LICENSE
 	vlicense LICENSE
 }
 
 libglvnd-devel_package() {
-	depends="${makedepends} ${sourcepkg}-${version}_${revision}"
+	depends="libX11-devel ${sourcepkg}-${version}_${revision}"
 	conflicts="MesaLib-devel<19.2.5_2"
 	short_desc+=" - development files"
 	pkg_install() {

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (10 preceding siblings ...)
  2020-05-16 12:43 ` st3r4g
@ 2020-05-16 12:46 ` st3r4g
  2020-05-16 12:47 ` st3r4g
  2020-10-01 13:15 ` [PR PATCH] [Closed]: " st3r4g
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 12:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629634493

Comment:
I think `libXext-devel xorgproto` are required internally and not propagated to public headers, but meaningful testing is annoying because these are also pulled in by other -devel dependencies (when trying to build e.g. `mesa-demos`) EDIT: `mesa-demos` requires xext by itself, so useless to test with it, tested compiling `xdriinfo` and `glmark2`

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (11 preceding siblings ...)
  2020-05-16 12:46 ` st3r4g
@ 2020-05-16 12:47 ` st3r4g
  2020-10-01 13:15 ` [PR PATCH] [Closed]: " st3r4g
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-05-16 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/22008#issuecomment-629634493

Comment:
I think `libXext-devel xorgproto` are required internally and not propagated to public headers, but meaningful testing is annoying because these are also pulled in by other -devel dependencies (when trying to build e.g. `mesa-demos`) EDIT: `mesa-demos` requires xext by itself, so useless to test with it, tested compiling `xdriinfo` and `glmark2` (with `MesaLib-devel` replaced by `libglvnd-devel`)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Closed]: libglvnd: remove excess devel deps, grep license
  2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
                   ` (12 preceding siblings ...)
  2020-05-16 12:47 ` st3r4g
@ 2020-10-01 13:15 ` st3r4g
  13 siblings, 0 replies; 15+ messages in thread
From: st3r4g @ 2020-10-01 13:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

There's a closed pull request on the void-packages repository

libglvnd: remove excess devel deps, grep license
https://github.com/void-linux/void-packages/pull/22008

Description:
Tested building `glu` and `mesa`

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2020-10-01 13:15 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-16  9:15 [PR PATCH] libglvnd: remove excess devel deps, grep license st3r4g
2020-05-16 10:14 ` Chocimier
2020-05-16 10:33 ` st3r4g
2020-05-16 10:33 ` st3r4g
2020-05-16 10:33 ` st3r4g
2020-05-16 10:41 ` st3r4g
2020-05-16 10:41 ` st3r4g
2020-05-16 11:57 ` st3r4g
2020-05-16 12:23 ` st3r4g
2020-05-16 12:39 ` st3r4g
2020-05-16 12:42 ` [PR PATCH] [Updated] " st3r4g
2020-05-16 12:43 ` st3r4g
2020-05-16 12:46 ` st3r4g
2020-05-16 12:47 ` st3r4g
2020-10-01 13:15 ` [PR PATCH] [Closed]: " st3r4g

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).