[PR PATCH] postgresql: allow for proper shutdown

[PR PATCH] postgresql: allow for proper shutdown

[steinex]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

There is a new pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages postgresql
https://github.com/void-linux/void-packages/pull/22075

postgresql: allow for proper shutdown
runit sends TERM per default if it wants to down a service.
For postgres this means it will go into "smart shutdown mode" [1] and
wait until the last client disconnects and only then shut down. This
can lead to unproper termination of postgres, especially on
shutdowns/reboots.

This change overrides runits default beharviour by sending INT instead
so postgres will go into "fast shutdown mode" [1], which will make
postgres exit as promptly as possible.

[1] https://www.postgresql.org/docs/9.6/server-shutdown.html

cc @jnbr 

A patch file from https://github.com/void-linux/void-packages/pull/22075.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-postgresql-22075.patch --]
[-- Type: text/x-diff, Size: 1664 bytes --]

From a9672e42f6bfa062b833796719ba9e3a3a0a29b2 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Mon, 18 May 2020 11:09:53 +0200
Subject: [PATCH] postgresql: allow for proper shutdown

runit sends TERM per default if it wants to down a service.
For postgres this means it will go into "smart shutdown mode" [1] and
wait until the last client disconnects and only then shut down. This
can lead to unproper termination of postgres, especially on
shutdowns/reboots.

This change overrides runits default beharviour by sending INT instead
so postgres will go into "fast shutdown mode" [1], which will make
postgres exit as promptly as possible.

[1] https://www.postgresql.org/docs/9.6/server-shutdown.html
---
 srcpkgs/postgresql/files/postgresql/control/t | 2 ++
 srcpkgs/postgresql/template                   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
 create mode 100755 srcpkgs/postgresql/files/postgresql/control/t

diff --git a/srcpkgs/postgresql/files/postgresql/control/t b/srcpkgs/postgresql/files/postgresql/control/t
new file mode 100755
index 00000000000..b0026e5661b
--- /dev/null
+++ b/srcpkgs/postgresql/files/postgresql/control/t
@@ -0,0 +1,2 @@
+#!/bin/sh
+/usr/bin/kill -INT `/usr/bin/head -1 /run/runit/supervise.postgresql/pid`
diff --git a/srcpkgs/postgresql/template b/srcpkgs/postgresql/template
index 14ba9e7d50f..9e9db0bd68e 100644
--- a/srcpkgs/postgresql/template
+++ b/srcpkgs/postgresql/template
@@ -1,7 +1,7 @@
 # Template file for 'postgresql'
 pkgname=postgresql
 version=9.6.18
-revision=1
+revision=2
 build_style=gnu-configure
 make_build_target=world
 configure_args="--with-openssl --with-python

Re: postgresql: allow for proper shutdown

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/22075#issuecomment-630385407

Comment:
Thank you.

Re: [PR PATCH] [Merged]: postgresql: allow for proper shutdown

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

There's a merged pull request on the void-packages repository

postgresql: allow for proper shutdown
https://github.com/void-linux/void-packages/pull/22075

Description:
runit sends TERM per default if it wants to down a service.
For postgres this means it will go into "smart shutdown mode" [1] and
wait until the last client disconnects and only then shut down. This
can lead to unproper termination of postgres, especially on
shutdowns/reboots.

This change overrides runits default beharviour by sending INT instead
so postgres will go into "fast shutdown mode" [1], which will make
postgres exit as promptly as possible.

[1] https://www.postgresql.org/docs/9.6/server-shutdown.html

cc @jnbr