[PR PATCH] transmission: update to 3.00

[PR PATCH] transmission: update to 3.00

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

There is a new pull request by kartikynwa against master on the void-packages repository

https://github.com/kartikynwa/void-packages transmission-update
https://github.com/void-linux/void-packages/pull/22280

transmission: update to 3.00


A patch file from https://github.com/void-linux/void-packages/pull/22280.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-transmission-update-22280.patch --]
[-- Type: text/x-diff, Size: 1778 bytes --]

From e5ace090451a6ab0b17e4fad968dfdc1231ae62c Mon Sep 17 00:00:00 2001
From: Kartik Singh <kartik.ynwa@gmail.com>
Date: Mon, 25 May 2020 14:56:30 +0530
Subject: [PATCH] transmission: update to 3.00

---
 srcpkgs/transmission/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/transmission/template b/srcpkgs/transmission/template
index 7519854d5c2..0bfa526d9d6 100644
--- a/srcpkgs/transmission/template
+++ b/srcpkgs/transmission/template
@@ -1,7 +1,7 @@
 # Template file for 'transmission'
 pkgname=transmission
-version=2.94
-revision=5
+version=3.00
+revision=1
 build_style=gnu-configure
 configure_args="--enable-nls --enable-cli --enable-daemon --enable-utp
  --without-systemd-daemon"
@@ -13,7 +13,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT, GPL-2.0-or-later"
 homepage="https://www.transmissionbt.com"
 distfiles="https://github.com/transmission/transmission-releases/raw/master/${pkgname}-${version}.tar.xz"
-checksum=35442cc849f91f8df982c3d0d479d650c6ca19310a994eccdaa79a4af3916b7d
+checksum=9144652fe742f7f7dd6657716e378da60b751aaeda8bef8344b3eefc4db255f2
 
 # Create transmission system user/group
 system_accounts="transmission"
@@ -38,13 +38,13 @@ post_configure() {
 }
 
 do_build() {
-	make CXXFLAGS="${CXXFLAGS} -std=c++11" LDFLAGS="${LDFLAGS}" ${makejobs}
+	make CXXFLAGS="${CXXFLAGS} -std=c++17" LDFLAGS="${LDFLAGS}" ${makejobs}
 	if [ -z "$CROSS_BUILD" ]; then
 		# Build the Qt frontend
 		cd qt
 		qmake-qt5 MOC=moc-qt5 QMAKE_CXXFLAGS="${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" qtr.pro
 		lrelease-qt5 translations/*.ts
-		make ${makejobs} CXXFLAGS="${CXXFLAGS} -fPIC -std=c++11" LDFLAGS="${LDFLAGS}"
+		make ${makejobs} CXXFLAGS="${CXXFLAGS} -fPIC -std=c++17" LDFLAGS="${LDFLAGS}"
 	fi
 }
 

Re: transmission: update to 3.00

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22280#issuecomment-633584729

Comment:
Have you checked out their CMake build? Seems to be the recommended version nowadays. And they specify that the std should be `-std=gnu++17`, too. If it compiled I don't think it needs to be changed, though.

Re: transmission: update to 3.00

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/22280#issuecomment-633596691

Comment:
@ericonr sure I can try making a cmake template. I will try tonight and update on how it goes.

Re: transmission: update to 3.00

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22280#issuecomment-633598055

Comment:
If it doesn't cross build successfully I think we can stick to the current build_style, but if it works it would be great, I think.

Re: transmission: update to 3.00

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/pull/22280#issuecomment-633647089

Comment:
CMake build fails because the release tarball in transmission/transmission-releases is missing some files. [Link to issue.](https://github.com/transmission/transmission/issues/1248)

And the release on transmission/transmission is missing submodules so cmake doesn't work with that either.

We can wait for them to update the tarball then I can file a new PR if I can get it to work.

Re: transmission: update to 3.00

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22280#issuecomment-633683200

Comment:
Shame. Hope they get a new tarball out soon :)

Re: [PR PATCH] [Merged]: transmission: update to 3.00

[Hoshpak]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

There's a merged pull request on the void-packages repository

transmission: update to 3.00
https://github.com/void-linux/void-packages/pull/22280

Description:

Re: transmission: update to 3.00

[floppym]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New comment by floppym on void-packages repository

https://github.com/void-linux/void-packages/pull/22280#issuecomment-633712717

Comment:
I ended up rolling my own tarball with the fix applied.

https://dev.gentoo.org/~floppym/dist/transmission-3.00.tar.xz