* [PR PATCH] Manual.md: Clarify quality requirements.
@ 2020-07-05 10:53 flexibeast
2020-07-05 12:19 ` [PR PATCH] [Updated] " flexibeast
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: flexibeast @ 2020-07-05 10:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
There is a new pull request by flexibeast against master on the void-packages repository
https://github.com/flexibeast/void-packages modify-manual
https://github.com/void-linux/void-packages/pull/23395
Manual.md: Clarify quality requirements.
Further to discussion at #23290, following @Bleznudd's [suggestion](https://github.com/void-linux/void-packages/pull/23290#issuecomment-651171717).
A patch file from https://github.com/void-linux/void-packages/pull/23395.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-modify-manual-23395.patch --]
[-- Type: text/x-diff, Size: 1180 bytes --]
From 4e8bf3f61270d2981e83dc74e4b66c69b43593ae Mon Sep 17 00:00:00 2001
From: Alexis <flexibeast@gmail.com>
Date: Sun, 5 Jul 2020 20:49:14 +1000
Subject: [PATCH] Manual.md: Clarify quality requirements.
---
Manual.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Manual.md b/Manual.md
index c612479ec73..4aa5dd65153 100644
--- a/Manual.md
+++ b/Manual.md
@@ -127,7 +127,7 @@ exception, start a PR and make an argument for why that particular piece of
software, while not meeting any of the following requirements, is a good candidate for
the Void packages system.
-1. System: The software should be installed system-wide, not per-user.
+1. System: The software should be installed system-wide, and must not be per-user installable.
1. Compiled: The software needs to be compiled before being used, even if it is
software that is not needed by the whole system.
@@ -135,6 +135,8 @@ the Void packages system.
1. Required: Another package either within the repository or pending inclusion
requires the package.
+In particular, new themes and fonts are highly unlikely to be accepted.
+
<a id="buildphase"></a>
### Package build phases
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR PATCH] [Updated] Manual.md: Clarify quality requirements.
2020-07-05 10:53 [PR PATCH] Manual.md: Clarify quality requirements flexibeast
@ 2020-07-05 12:19 ` flexibeast
2020-07-06 20:23 ` [PR REVIEW] " Chocimier
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: flexibeast @ 2020-07-05 12:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
There is an updated pull request by flexibeast against master on the void-packages repository
https://github.com/flexibeast/void-packages modify-manual
https://github.com/void-linux/void-packages/pull/23395
Manual.md: Clarify quality requirements.
Further to discussion at #23290, following @Bleznudd's [suggestion](https://github.com/void-linux/void-packages/pull/23290#issuecomment-651171717).
A patch file from https://github.com/void-linux/void-packages/pull/23395.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-modify-manual-23395.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]
From 81c120a429c0360b7257585672a7dbac831d9d36 Mon Sep 17 00:00:00 2001
From: Alexis <flexibeast@gmail.com>
Date: Sun, 5 Jul 2020 20:49:14 +1000
Subject: [PATCH] Manual.md: Clarify quality requirements.
---
Manual.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Manual.md b/Manual.md
index c612479ec73..daed38869b5 100644
--- a/Manual.md
+++ b/Manual.md
@@ -127,7 +127,7 @@ exception, start a PR and make an argument for why that particular piece of
software, while not meeting any of the following requirements, is a good candidate for
the Void packages system.
-1. System: The software should be installed system-wide, not per-user.
+1. System: The software is best suited to system-wide, rather than per-user, installation.
1. Compiled: The software needs to be compiled before being used, even if it is
software that is not needed by the whole system.
@@ -135,6 +135,8 @@ the Void packages system.
1. Required: Another package either within the repository or pending inclusion
requires the package.
+In particular, new themes and fonts are highly unlikely to be accepted.
+
<a id="buildphase"></a>
### Package build phases
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR REVIEW] Manual.md: Clarify quality requirements.
2020-07-05 10:53 [PR PATCH] Manual.md: Clarify quality requirements flexibeast
2020-07-05 12:19 ` [PR PATCH] [Updated] " flexibeast
@ 2020-07-06 20:23 ` Chocimier
2020-07-06 20:23 ` Chocimier
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-07-06 20:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/23395#discussion_r450457999
Comment:
This don't seem to clarify anything, I would leave as is.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR REVIEW] Manual.md: Clarify quality requirements.
2020-07-05 10:53 [PR PATCH] Manual.md: Clarify quality requirements flexibeast
2020-07-05 12:19 ` [PR PATCH] [Updated] " flexibeast
2020-07-06 20:23 ` [PR REVIEW] " Chocimier
@ 2020-07-06 20:23 ` Chocimier
2020-07-07 7:53 ` [PR PATCH] [Updated] " flexibeast
2020-07-07 8:12 ` flexibeast
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-07-06 20:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/23395#discussion_r450459583
Comment:
Also small shell scripts. Fonts are welcome if they provide value beyond aesthethic, eg. contains glyphs for script missing in already packaged fonts.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] Manual.md: Clarify quality requirements.
2020-07-05 10:53 [PR PATCH] Manual.md: Clarify quality requirements flexibeast
` (2 preceding siblings ...)
2020-07-06 20:23 ` Chocimier
@ 2020-07-07 7:53 ` flexibeast
2020-07-07 8:12 ` flexibeast
4 siblings, 0 replies; 6+ messages in thread
From: flexibeast @ 2020-07-07 7:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
There is an updated pull request by flexibeast against master on the void-packages repository
https://github.com/flexibeast/void-packages modify-manual
https://github.com/void-linux/void-packages/pull/23395
Manual.md: Clarify quality requirements.
Further to discussion at #23290, following @Bleznudd's [suggestion](https://github.com/void-linux/void-packages/pull/23290#issuecomment-651171717).
A patch file from https://github.com/void-linux/void-packages/pull/23395.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-modify-manual-23395.patch --]
[-- Type: text/x-diff, Size: 804 bytes --]
From 6abfaedf8631abb32533821882d86db4ac6e6654 Mon Sep 17 00:00:00 2001
From: Alexis <flexibeast@gmail.com>
Date: Sun, 5 Jul 2020 20:49:14 +1000
Subject: [PATCH] Manual.md: Clarify quality requirements.
---
Manual.md | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Manual.md b/Manual.md
index c612479ec73..fbd1518711e 100644
--- a/Manual.md
+++ b/Manual.md
@@ -135,6 +135,11 @@ the Void packages system.
1. Required: Another package either within the repository or pending inclusion
requires the package.
+In particular, new themes and small shell scripts are highly unlikely
+to be accepted. New fonts are welcome if they provide value beyond
+aesthetics (e.g. they contain glyphs for a script missing in already
+packaged fonts).
+
<a id="buildphase"></a>
### Package build phases
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Manual.md: Clarify quality requirements.
2020-07-05 10:53 [PR PATCH] Manual.md: Clarify quality requirements flexibeast
` (3 preceding siblings ...)
2020-07-07 7:53 ` [PR PATCH] [Updated] " flexibeast
@ 2020-07-07 8:12 ` flexibeast
4 siblings, 0 replies; 6+ messages in thread
From: flexibeast @ 2020-07-07 8:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
New comment by flexibeast on void-packages repository
https://github.com/void-linux/void-packages/pull/23395#issuecomment-654678214
Comment:
PR updated with requested changes.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-07 8:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-05 10:53 [PR PATCH] Manual.md: Clarify quality requirements flexibeast
2020-07-05 12:19 ` [PR PATCH] [Updated] " flexibeast
2020-07-06 20:23 ` [PR REVIEW] " Chocimier
2020-07-06 20:23 ` Chocimier
2020-07-07 7:53 ` [PR PATCH] [Updated] " flexibeast
2020-07-07 8:12 ` flexibeast
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).