Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gummiboot : patched to permit kernel cmdline parameter passing.
@ 2020-07-06 10:34 pandom79
  2020-07-06 13:10 ` ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: pandom79 @ 2020-07-06 10:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

There is a new pull request by pandom79 against master on the void-packages repository

https://github.com/pandom79/void-packages gummiboot
https://github.com/void-linux/void-packages/pull/23412

gummiboot : patched to permit kernel cmdline parameter passing.
The actual version doesn't work. See [here](https://github.com/systemd/systemd/blob/master/src/boot/efi/stub.c) at 66 line. Tested on my machine (Dell xps 9380)


A patch file from https://github.com/void-linux/void-packages/pull/23412.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gummiboot-23412.patch --]
[-- Type: text/x-diff, Size: 1165 bytes --]

From 771c6cfe7e75c3088f3b7da28ed2fcde17df176c Mon Sep 17 00:00:00 2001
From: Domenico Panella <pandom79@gmail.com>
Date: Mon, 6 Jul 2020 12:27:07 +0200
Subject: [PATCH] gummiboot : patched to permit kernel cmdline parameter
 passing.

---
 srcpkgs/gummiboot/patches/stub.patch | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/gummiboot/patches/stub.patch

diff --git a/srcpkgs/gummiboot/patches/stub.patch b/srcpkgs/gummiboot/patches/stub.patch
new file mode 100644
index 00000000000..ee1ab58d74c
--- /dev/null
+++ b/srcpkgs/gummiboot/patches/stub.patch
@@ -0,0 +1,12 @@
+--- src/efi/stub.c	2015-03-12 00:50:35.000000000 +0100
++++ src/efi/stub.c	2020-07-06 12:32:55.985327487 +0200
+@@ -83,7 +83,7 @@
+         cmdline_len = szs[0];
+ 
+         /* if we are not in secure boot mode, accept a custom command line and replace the built-in one */
+-        if (!secure && loaded_image->LoadOptionsSize > 0) {
++        if ((!secure || cmdline_len == 0) && loaded_image->LoadOptionsSize > 0 && *(CHAR16 *)loaded_image->LoadOptions > 0x1F) {
+                 CHAR16 *options;
+                 CHAR8 *line;
+                 UINTN i;
+

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: gummiboot : patched to permit kernel cmdline parameter passing.
  2020-07-06 10:34 [PR PATCH] gummiboot : patched to permit kernel cmdline parameter passing pandom79
@ 2020-07-06 13:10 ` ericonr
  2020-07-06 13:17 ` ericonr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-07-06 13:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23412#issuecomment-654226679

Comment:
Needs a revbump

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: gummiboot : patched to permit kernel cmdline parameter passing.
  2020-07-06 10:34 [PR PATCH] gummiboot : patched to permit kernel cmdline parameter passing pandom79
  2020-07-06 13:10 ` ericonr
@ 2020-07-06 13:17 ` ericonr
  2020-07-21 14:36 ` ahesford
  2020-07-21 14:37 ` [PR PATCH] [Closed]: " ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-07-06 13:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23412#issuecomment-654226679

Comment:
Needs a revbump in order to be rebuilt.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: gummiboot : patched to permit kernel cmdline parameter passing.
  2020-07-06 10:34 [PR PATCH] gummiboot : patched to permit kernel cmdline parameter passing pandom79
  2020-07-06 13:10 ` ericonr
  2020-07-06 13:17 ` ericonr
@ 2020-07-21 14:36 ` ahesford
  2020-07-21 14:37 ` [PR PATCH] [Closed]: " ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-07-21 14:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23412#issuecomment-661900469

Comment:
Merged in a4cbcfbbd04b9f493989a6ccb48d7590105246d6 with a revbump.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: gummiboot : patched to permit kernel cmdline parameter passing.
  2020-07-06 10:34 [PR PATCH] gummiboot : patched to permit kernel cmdline parameter passing pandom79
                   ` (2 preceding siblings ...)
  2020-07-21 14:36 ` ahesford
@ 2020-07-21 14:37 ` ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-07-21 14:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

There's a closed pull request on the void-packages repository

gummiboot : patched to permit kernel cmdline parameter passing.
https://github.com/void-linux/void-packages/pull/23412

Description:
The actual version doesn't work. See [here](https://github.com/systemd/systemd/blob/master/src/boot/efi/stub.c) at 66 line. Tested on my machine (Dell xps 9380)


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-21 14:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 10:34 [PR PATCH] gummiboot : patched to permit kernel cmdline parameter passing pandom79
2020-07-06 13:10 ` ericonr
2020-07-06 13:17 ` ericonr
2020-07-21 14:36 ` ahesford
2020-07-21 14:37 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).