[PR PATCH] nawk: update to 20200702

[PR PATCH] nawk: update to 20200702

[mmnmnnmnmm]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

There is a new pull request by mmnmnnmnmm against master on the void-packages repository

https://github.com/mmnmnnmnmm/void-packages nawk
https://github.com/void-linux/void-packages/pull/23621

nawk: update to 20200702
xlint says that the short_desc should not start with an article, but in this circumstance that would change the meaning of the sentence.

If you want me to change it I suggest something like
"Version of awk as described in The AWK Programming Language".

A patch file from https://github.com/void-linux/void-packages/pull/23621.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nawk-23621.patch --]
[-- Type: text/x-diff, Size: 1850 bytes --]

From 21f02af4eaf1d31cedc27ba5aac44a4d144b436e Mon Sep 17 00:00:00 2001
From: mmnmnnmnmm <45293514+mmnmnnmnmm@users.noreply.github.com>
Date: Fri, 17 Jul 2020 19:21:27 +0100
Subject: [PATCH] nawk: update to 20200702

---
 srcpkgs/nawk/template | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/nawk/template b/srcpkgs/nawk/template
index 48678359d06..6f73b6aea9e 100644
--- a/srcpkgs/nawk/template
+++ b/srcpkgs/nawk/template
@@ -1,16 +1,17 @@
 # Template file for 'nawk'
 pkgname=nawk
-version=20180827
+version=20200702
 revision=1
-wrksrc="awk-${version}"
+_commit=2a4146ec3027d12e375209e03ed1c5a9ab230da4
+wrksrc="awk-${_commit}"
 hostmakedepends="bison"
 short_desc="The one, true implementation of AWK"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="mmnmnnmnmm <mnnnm@disroot.org>"
 license="SMLNJ"
 homepage="https://github.com/onetrueawk/awk"
 changelog="https://raw.githubusercontent.com/onetrueawk/awk/master/ChangeLog"
-distfiles="https://github.com/onetrueawk/awk/archive/${version}.tar.gz"
-checksum=c9232d23410c715234d0c26131a43ae6087462e999a61f038f1790598ce4807f
+distfiles="https://github.com/onetrueawk/awk/archive/${_commit}.tar.gz"
+checksum=5b882509ed2d84fcbdff38316db11fbd6f1682bb948f7e9761ffcd1115bae058
 
 provides="awk-0_1"
 alternatives="
@@ -18,13 +19,14 @@ alternatives="
  awk:awk.1:/usr/share/man/man1/nawk.1"
 
 do_configure() {
-	sed -i '/maketab/{s/CC/BUILD_CC/;s/CFLAGS/BUILD_CFLAGS/}' makefile
-	sed -i '/YACC = yacc -d -S/ s|^|#|' makefile
-	sed -i 's/-lm/$(LDFLAGS) &/' makefile
+	vsed -i '/maketab/{s/HOSTCC/BUILD_CC/;s/CFLAGS/BUILD_CFLAGS/}' makefile
+	vsed -i 's/-lm/$(LDFLAGS) &/' makefile
 }
+
 do_build() {
 	make CC=$CC CFLAGS="$CFLAGS" CPPFLAGS="$CPPFLAGS -DHAS_ISBLANK" LDFLAGS="$LDFLAGS"
 }
+
 do_install() {
 	vbin a.out nawk
 	vman awk.1 nawk.1

Re: nawk: update to 20200702

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-660292015

Comment:
We do not package random revisions from VCS. Ask upstream for release if you want to update.
On short_desc: xlint serve us, not the other way. Just ignore warning.

Re: nawk: update to 20200702

[mmnmnnmnmm]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

New comment by mmnmnnmnmm on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-660306034

Comment:
> On short_desc: xlint serve us, not the other way. Just ignore warning.

That makes sense, thanks.

> We do not package random revisions from VCS. Ask upstream for release if you want to update.

I understand, but unfortunately upstream does not want to do releases.  I thought this package might get some leniency as it was already in the repo and is a quite widely used piece of software.

Re: nawk: update to 20200702

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-660437697

Comment:
I don't think its that widely used piece of software. I don't get why they won't release. I'm going to open another issue. This is something we are quite strict on, afaik.

Re: nawk: update to 20200702

[flexibeast]

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

New comment by flexibeast on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-660440577

Comment:
Just as a heads-up, the main contributor to the repo is [Arnold Robbins](http://www.skeeve.com/), a maintainer of gawk and a co-author of "[AWK Language Programming](https://en.wikisource.org/wiki/AWK_Language_Programming)"; in an "[open letter](http://www.skeeve.com/fork-my-code.html)", Robbins (and Chet Ramey) write:

> We are not on a schedule. We each have lives (day jobs, families, even other interests), and we do not have to produce releases just because someone else is working to release a distribution that includes our code. (We may try to accommodate them, but we don't have to.)

Re: nawk: update to 20200702

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-660441171

Comment:
Hm. Guess I'm not opening an issue after all, since this person is making it clear what they think of it.

Re: nawk: update to 20200702

[mmnmnnmnmm]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

New comment by mmnmnnmnmm on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-660469955

Comment:
> I don't think its that widely used piece of software.

We all have different interpretations of "widely" :).  I meant rather, it is used as the implementation of awk in the *BSDs and is the reference awk, which makes it quite useful for testing portable awk scripts.

I also forgot to make clear that the last "release" of nawk was just a singular tagged commit.  They have never done releases; you can see in the git history of this file that the template previously used arbitrary commits before that "release".

plan9port is in the same situation where upstream doesn't make releases for similar reasons but new versions from git commits still get merged by some of the maintainers, so I don't know how the Void team wants to handle this.

Re: nawk: update to 20200702

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-769499404

Comment:
@mmnmnnmnmm given that before this specific tag, we used to use a specific (but rather random) commit, I don't think it'd be incorrect to do an update to a new commit.

Since nothing depends directly on this, it should be a mostly safe update path.

Re: nawk: update to 20200702

[mmnmnnmnmm]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

New comment by mmnmnnmnmm on void-packages repository

https://github.com/void-linux/void-packages/pull/23621#issuecomment-769819846

Comment:
On Thu, 28 Jan 2021 16:59:35 -0800
Érico Nogueira Rolim <notifications@github.com> wrote:

> @mmnmnnmnmm given that before this specific tag, we used to use a specific (but rather random) commit, I don't think it'd be incorrect to do an update to a new commit.
> 
> Since nothing depends directly on this, it should be a mostly safe update path.
> 

Conveniently I updated it to latest commit just yesterday, I'll push it now.

Re: [PR PATCH] [Updated] nawk: update to 20200702

[mmnmnnmnmm]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

There is an updated pull request by mmnmnnmnmm against master on the void-packages repository

https://github.com/mmnmnnmnmm/void-packages nawk
https://github.com/void-linux/void-packages/pull/23621

nawk: update to 20200702
xlint says that the short_desc should not start with an article, but in this circumstance that would change the meaning of the sentence.

If you want me to change it I suggest something like
"Version of awk as described in The AWK Programming Language".

A patch file from https://github.com/void-linux/void-packages/pull/23621.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nawk-23621.patch --]
[-- Type: text/x-diff, Size: 1850 bytes --]

From 141c79a71663c8c7998b09ae5172064133276831 Mon Sep 17 00:00:00 2001
From: mmnmnnmnmm <45293514+mmnmnnmnmm@users.noreply.github.com>
Date: Fri, 17 Jul 2020 19:21:27 +0100
Subject: [PATCH] nawk: update to 20210110

---
 srcpkgs/nawk/template | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/nawk/template b/srcpkgs/nawk/template
index 48678359d06..6fd5510733b 100644
--- a/srcpkgs/nawk/template
+++ b/srcpkgs/nawk/template
@@ -1,16 +1,17 @@
 # Template file for 'nawk'
 pkgname=nawk
-version=20180827
+version=20210110
 revision=1
-wrksrc="awk-${version}"
+_commit=178f660b5a4fde6f39e8065185373166f55b6e0c
+wrksrc="awk-${_commit}"
 hostmakedepends="bison"
 short_desc="The one, true implementation of AWK"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="mmnmnnmnmm <mnnnm@disroot.org>"
 license="SMLNJ"
 homepage="https://github.com/onetrueawk/awk"
 changelog="https://raw.githubusercontent.com/onetrueawk/awk/master/ChangeLog"
-distfiles="https://github.com/onetrueawk/awk/archive/${version}.tar.gz"
-checksum=c9232d23410c715234d0c26131a43ae6087462e999a61f038f1790598ce4807f
+distfiles="https://github.com/onetrueawk/awk/archive/${_commit}.tar.gz"
+checksum=57bca56b5e84e2148e4ba600f5dcdd376a1a5d374bafe426a386dc17e25ead45
 
 provides="awk-0_1"
 alternatives="
@@ -18,13 +19,14 @@ alternatives="
  awk:awk.1:/usr/share/man/man1/nawk.1"
 
 do_configure() {
-	sed -i '/maketab/{s/CC/BUILD_CC/;s/CFLAGS/BUILD_CFLAGS/}' makefile
-	sed -i '/YACC = yacc -d -S/ s|^|#|' makefile
-	sed -i 's/-lm/$(LDFLAGS) &/' makefile
+	vsed -i '/maketab/{s/HOSTCC/BUILD_CC/;s/CFLAGS/BUILD_CFLAGS/}' makefile
+	vsed -i 's/-lm/$(LDFLAGS) &/' makefile
 }
+
 do_build() {
 	make CC=$CC CFLAGS="$CFLAGS" CPPFLAGS="$CPPFLAGS -DHAS_ISBLANK" LDFLAGS="$LDFLAGS"
 }
+
 do_install() {
 	vbin a.out nawk
 	vman awk.1 nawk.1