[PR PATCH] adom: remove package

[PR PATCH] adom: remove package

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

There is a new pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages adom
https://github.com/void-linux/void-packages/pull/23691

adom: remove package
This is a proprietary game that abuses a `libncurses.so.5` symlink to `/usr/lib/libncursesw.so.6` to work, albeit with a warning about shared object versioning. The software consists of a single executable and a few readme files. This doesn't seem to meet quality standards and abuses `shlib_provides` to work around the `libncurses.so.5` dependency.

Let users fetch the tarball and make the `libncurses` symlinks if they really want to play.

The template is also wrong for ARM, as the ARM executable is static and doesn't depend on `ncurses`.

A patch file from https://github.com/void-linux/void-packages/pull/23691.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-adom-23691.patch --]
[-- Type: text/x-diff, Size: 2017 bytes --]

From 51aee08b1ea176728e037188d2324547a3f8f231 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Tue, 21 Jul 2020 12:55:50 -0400
Subject: [PATCH] adom: remove package

---
 srcpkgs/adom/template | 53 -------------------------------------------
 1 file changed, 53 deletions(-)
 delete mode 100644 srcpkgs/adom/template

diff --git a/srcpkgs/adom/template b/srcpkgs/adom/template
deleted file mode 100644
index 9526508a790..00000000000
--- a/srcpkgs/adom/template
+++ /dev/null
@@ -1,53 +0,0 @@
-# Template file for 'adom'
-pkgname=adom
-reverts=60_1
-version=3.3.3
-revision=1
-wrksrc=${pkgname}
-depends="ncurses"
-short_desc="Roguelike game with a quest-centric, plot driven structure"
-maintainer="Diogo Leal <diogo@diogoleal.com>"
-license="Proprietary"
-homepage="http://www.adom.de"
-_download_url="https://www.adom.de/home/download/current"
-nopie=yes
-nostrip=yes
-repository=nonfree
-shlib_provides="libncurses.so.5"
-
-case "${XBPS_TARGET_MACHINE}" in
-	*-musl)
-		broken="Platform not supported."
-		;;
-	x86_64)
-		distfiles="${_download_url}/adom_linux_debian_64_${version}.tar.gz"
-		checksum=b74a310e4180633d75ef26742933796261b475252a4123c6c492ee4ce96d48dd
-		;;
-	i686)
-		distfiles="${_download_url}/adom_linux_debian_32_${version}.tar.gz"
-		checksum=20a900c425236205668db3fb052491d9c4fd3ff30765b1281802ff8a7cc374dd
-		;;
-	arm*)
-		distfiles="${_download_url}/adom_linux_arm_${version}.tar.gz"
-		checksum=8a674bf077f816856ceda3e6312c4721435fc529dbd0bc95897828c887755c6f
-		;;
-	*)
-		broken="Platform not supported."
-		;;
-esac
-
-do_install() {
-	vdoc docs/adomfaq.txt
-	vdoc docs/manual.txt
-	vdoc docs/readme1st.txt
-	vmkdir usr/lib/adom
-	vcopy adom usr/lib/adom
-	ln -s ../libncursesw.so.6 ${DESTDIR}/usr/lib/adom/libtinfo.so.5
-	ln -s ../libncursesw.so.6 ${DESTDIR}/usr/lib/adom/libncurses.so.5
-	vmkdir usr/bin
-	cat > ${DESTDIR}/usr/bin/adom << _EOF
-#! /bin/sh
-LD_LIBRARY_PATH=/usr/lib/adom /usr/lib/adom/adom "\$@"
-_EOF
-	chmod 755 ${DESTDIR}/usr/bin/adom
-}

Re: [PR PATCH] [Merged]: adom: remove package

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

There's a merged pull request on the void-packages repository

adom: remove package
https://github.com/void-linux/void-packages/pull/23691

Description:
This is a proprietary game that abuses a `libncurses.so.5` symlink to `/usr/lib/libncursesw.so.6` to work, albeit with a warning about shared object versioning. The software consists of a single executable and a few readme files. This doesn't seem to meet quality standards and abuses `shlib_provides` to work around the `libncurses.so.5` dependency.

Let users fetch the tarball and make the `libncurses` symlinks if they really want to play.

The template is also wrong for ARM, as the ARM executable is static and doesn't depend on `ncurses`.