Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] apache-storm: cleanup
@ 2020-07-21 20:22 Piraty
  2020-07-22  8:44 ` pullmoll
  2020-07-22  8:46 ` [PR PATCH] [Merged]: " Piraty
  0 siblings, 2 replies; 3+ messages in thread
From: Piraty @ 2020-07-21 20:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

There is a new pull request by Piraty against master on the void-packages repository

https://github.com/Piraty/void-packages apache-storm-cleanup
https://github.com/void-linux/void-packages/pull/23694

apache-storm: cleanup
* set noarch
* add missing storm.py (`/usr/bin/storm` bash script execs it)
* should be python3 compatible, judging from comments in storm.py
* remove commented vcopy

@pullmoll @bougyman @Kistelini

A patch file from https://github.com/void-linux/void-packages/pull/23694.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apache-storm-cleanup-23694.patch --]
[-- Type: text/x-diff, Size: 1629 bytes --]

From 8aebb4ed81b4b8b14b9c4d4b092450b5e71f8238 Mon Sep 17 00:00:00 2001
From: Piraty <piraty1@inbox.ru>
Date: Tue, 21 Jul 2020 22:16:42 +0200
Subject: [PATCH] apache-storm: cleanup

* set noarch
* add missing storm.py (`/usr/bin/storm` bash script execs it)
* should be python3 compatible, judging from comments in storm.py
* remove commented vcopy
---
 srcpkgs/apache-storm/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/apache-storm/template b/srcpkgs/apache-storm/template
index b6a54e13235..6ae346a0557 100644
--- a/srcpkgs/apache-storm/template
+++ b/srcpkgs/apache-storm/template
@@ -1,15 +1,16 @@
 # Template file for 'apache-storm'
 pkgname=apache-storm
 version=2.2.0
-revision=1
-depends="virtual?java-runtime python"
+revision=2
+archs=noarch
+depends="virtual?java-runtime python3 bash"
 short_desc="Distributed realtime computation system"
 maintainer="bougyman <bougyman@voidlinux.org>"
 license="Apache-2.0"
 homepage="https://storm.apache.org/"
 distfiles="http://apache.osuosl.org/storm/apache-storm-${version}/apache-storm-${version}.tar.gz"
 checksum=f621163f349a8e85130bc3d2fbb34e3b08f9c039ccac5474f3724e47a3a38675
-python_version=2 #unverified
+python_version=3
 system_accounts="storm"
 storm_homedir="/var/lib/apache-storm"
 storm_shell="/bin/bash"
@@ -17,8 +18,8 @@ storm_descr="unprivileged user to run apache-storm java classes"
 
 do_install() {
 	vbin bin/storm
+	vbin bin/storm.py
 	vmkdir var/lib/apache-storm
-	# vcopy logback var/lib/apache-storm
 	vcopy public var/lib/apache-storm
 	vmkdir usr/lib/apache-storm
 	vcopy external usr/lib/apache-storm

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: apache-storm: cleanup
  2020-07-21 20:22 [PR PATCH] apache-storm: cleanup Piraty
@ 2020-07-22  8:44 ` pullmoll
  2020-07-22  8:46 ` [PR PATCH] [Merged]: " Piraty
  1 sibling, 0 replies; 3+ messages in thread
From: pullmoll @ 2020-07-22  8:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/23694#issuecomment-662326676

Comment:
:+1:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: apache-storm: cleanup
  2020-07-21 20:22 [PR PATCH] apache-storm: cleanup Piraty
  2020-07-22  8:44 ` pullmoll
@ 2020-07-22  8:46 ` Piraty
  1 sibling, 0 replies; 3+ messages in thread
From: Piraty @ 2020-07-22  8:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There's a merged pull request on the void-packages repository

apache-storm: cleanup
https://github.com/void-linux/void-packages/pull/23694

Description:
* set noarch
* add missing storm.py (`/usr/bin/storm` bash script execs it)
* should be python3 compatible, judging from comments in storm.py
* remove commented vcopy

@pullmoll @bougyman @Kistelini

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-22  8:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 20:22 [PR PATCH] apache-storm: cleanup Piraty
2020-07-22  8:44 ` pullmoll
2020-07-22  8:46 ` [PR PATCH] [Merged]: " Piraty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).