Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] fcft: update to 2.2.3.
@ 2020-07-29 15:43 ifreund
  2020-07-29 15:47 ` [PR REVIEW] " ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: ifreund @ 2020-07-29 15:43 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

There is a new pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages bump-fcft
https://github.com/void-linux/void-packages/pull/23928

fcft: update to 2.2.3.
No need for any revbumps, this release is ABI compatible.

A patch file from https://github.com/void-linux/void-packages/pull/23928.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bump-fcft-23928.patch --]
[-- Type: text/x-diff, Size: 1633 bytes --]

From 39ab453d5e9b4e462d962a60a995218175bf9c15 Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Wed, 29 Jul 2020 17:41:59 +0200
Subject: [PATCH] fcft: update to 2.2.3.

No need for any revbumps, this release is ABI compatible.
---
 srcpkgs/fcft/template | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/fcft/template b/srcpkgs/fcft/template
index 2cb74392aec..05ed1f7a314 100644
--- a/srcpkgs/fcft/template
+++ b/srcpkgs/fcft/template
@@ -1,6 +1,6 @@
 # Template file for 'fcft'
 pkgname=fcft
-version=2.2.2
+version=2.2.3
 revision=1
 wrksrc=$pkgname
 build_style=meson
@@ -10,14 +10,11 @@ short_desc="Simple library for font loading and glyph rasterization"
 maintainer="Isaac Freund <ifreund@ifreund.xyz>"
 license="MIT"
 homepage="https://codeberg.org/dnkl/fcft"
-distfiles="${homepage}/archive/${version}.tar.gz
- ${homepage}/raw/branch/master/LICENSE"
-checksum="9bc54b5ccb637f6c8270697c886e3e86cb4ffb6042b1d4a32eaaee854fb0837d
- d534a23a31500a0ac958d9634b84f532bd73ff1aca1bb8f7debbcbebc16ff39a"
-skip_extraction=LICENSE
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=be6b44a84f798c15a4e903dd7579b7468b79c8928c73f4c29dd4d1b6e94bb4e2
 
 post_install() {
-	vlicense ${XBPS_SRCDISTDIR}/${pkgname}-${version}/LICENSE
+	vlicense LICENSE
 }
 
 fcft-devel_package() {
@@ -27,6 +24,10 @@ fcft-devel_package() {
 		vmove usr/include
 		vmove usr/lib/pkgconfig
 		vmove "usr/lib/*.so"
+		vmove usr/share/doc
 		vmove usr/share/man/man3
+
+		# The license is already installed by the base package
+		rm ${PKGDESTDIR}/usr/share/doc/${sourcepkg}/LICENSE
 	}
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] fcft: update to 2.2.3.
  2020-07-29 15:43 [PR PATCH] fcft: update to 2.2.3 ifreund
@ 2020-07-29 15:47 ` ericonr
  2020-07-29 15:50 ` ifreund
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-07-29 15:47 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23928#discussion_r462401810

Comment:
Does this need to be deleted? I don't see an issue with having it there.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] fcft: update to 2.2.3.
  2020-07-29 15:43 [PR PATCH] fcft: update to 2.2.3 ifreund
  2020-07-29 15:47 ` [PR REVIEW] " ericonr
@ 2020-07-29 15:50 ` ifreund
  2020-07-29 17:11 ` ericonr
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ifreund @ 2020-07-29 15:50 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/23928#discussion_r462404336

Comment:
Is it not strange to have a license in the doc folder when we have a license folder? Is it not redundant to have the license in both `fcft` and `fcft-devel`?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] fcft: update to 2.2.3.
  2020-07-29 15:43 [PR PATCH] fcft: update to 2.2.3 ifreund
  2020-07-29 15:47 ` [PR REVIEW] " ericonr
  2020-07-29 15:50 ` ifreund
@ 2020-07-29 17:11 ` ericonr
  2020-07-29 17:12 ` ericonr
  2020-07-29 17:26 ` ifreund
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-07-29 17:11 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23928#discussion_r462455997

Comment:
I agree with both those points, it's mostly that I don't know if they make it worth having one more thing in the template. But you're the maintainer for it, so it definitely makes sense for you to make the decision on that :p 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] fcft: update to 2.2.3.
  2020-07-29 15:43 [PR PATCH] fcft: update to 2.2.3 ifreund
                   ` (2 preceding siblings ...)
  2020-07-29 17:11 ` ericonr
@ 2020-07-29 17:12 ` ericonr
  2020-07-29 17:26 ` ifreund
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2020-07-29 17:12 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23928#discussion_r462455997

Comment:
I agree with both those points, it's mostly that I don't know if they make it worth having one more thing in the template. But you're the maintainer for it, so it definitely makes sense for you to make the decision on that :p 

I can't find the resolve issue button, so I can't close this thread, sorry.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] fcft: update to 2.2.3.
  2020-07-29 15:43 [PR PATCH] fcft: update to 2.2.3 ifreund
                   ` (3 preceding siblings ...)
  2020-07-29 17:12 ` ericonr
@ 2020-07-29 17:26 ` ifreund
  4 siblings, 0 replies; 6+ messages in thread
From: ifreund @ 2020-07-29 17:26 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/23928#discussion_r462465347

Comment:
> I can't find the resolve issue button, so I can't close this thread, sorry.

No worries I managed to find it :D

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 15:43 [PR PATCH] fcft: update to 2.2.3 ifreund
2020-07-29 15:47 ` [PR REVIEW] " ericonr
2020-07-29 15:50 ` ifreund
2020-07-29 17:11 ` ericonr
2020-07-29 17:12 ` ericonr
2020-07-29 17:26 ` ifreund

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git