Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: e16-1.0.22
@ 2020-08-04  5:57 brihadeesh
  2020-08-04 11:41 ` [PR REVIEW] " ahesford
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: brihadeesh @ 2020-08-04  5:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

There is a new pull request by brihadeesh against master on the void-packages repository

https://github.com/brihadeesh/void-packages enlightenment16
https://github.com/void-linux/void-packages/pull/24040

New package: e16-1.0.22
New package: e16-1.0.22 (enlightenment DR16 window manager; current release).

These lines in `post_install()` seem to have no purpose but the kde and gnome session scripts provided by e16 might be of use to some:

```
vbin "misc/Xclients.e16-gnome.sh" e16-gnome
vbin "misc/Xclients.e16-kde.sh" e16-kde
```
I'm also uncertain as to whether this is the right usage of the vbin function.

PS: this is like my first PR ever!!

A patch file from https://github.com/void-linux/void-packages/pull/24040.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-enlightenment16-24040.patch --]
[-- Type: text/x-diff, Size: 1491 bytes --]

From c2758e68064759897fab7262a84677bc82e7d449 Mon Sep 17 00:00:00 2001
From: Brihadeesh <brihadeesh.santharam@gmail.com>
Date: Tue, 4 Aug 2020 11:18:06 +0530
Subject: [PATCH] New package: e16-1.0.22

New package:e16-1.0.22
---
 srcpkgs/e16/template | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 srcpkgs/e16/template

diff --git a/srcpkgs/e16/template b/srcpkgs/e16/template
new file mode 100644
index 00000000000..d64249fd3b2
--- /dev/null
+++ b/srcpkgs/e16/template
@@ -0,0 +1,27 @@
+# Template file for 'e16'
+pkgname=e16
+version=1.0.22
+revision=1
+archs="i686 x86_64"
+build_style=gnu-configure
+configure_args="--prefix=/usr --sysconfdir=/etc --enable-sound=alsa"
+# make_install_args="--exec-prefix=/usr"
+#make_build_args=""
+hostmakedepends="pkg-config tar"
+makedepends="perl pango-devel libXinerama-devel libXrandr-devel imlib2-devel libXcomposite-devel alsa-lib-devel libsndfile-devel"
+short_desc="Enlightenment DR16 window manager"
+maintainer="Brihadeesh <brihadeesh@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://enlightenment.org"
+distfiles="$SOURCEFORGE_SITE/enlightenment/${pkgname}-${version}.tar.gz"
+checksum=b07d301a0a67ac020974afcbe779e1d48b376eab2e477fb189277c13b76d4a67
+
+post_install() {
+	# install gnome and kde session scripts
+	vbin "misc/Xclients.e16-gnome.sh" e16-gnome
+	vbin "misc/Xclients.e16-kde.sh" e16-kde
+
+	# licences for e16 and fonts(?)
+	vlicense COPYING
+	vlicense fonts/COPYRIGHT.Vera
+}

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
@ 2020-08-04 11:41 ` ahesford
  2020-08-04 11:41 ` ahesford
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2020-08-04 11:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24040#discussion_r464981165

Comment:
Should be https://www.enlightenment.org/e16

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
                   ` (2 preceding siblings ...)
  2020-08-04 11:41 ` ahesford
@ 2020-08-04 11:41 ` ahesford
  2020-08-04 11:41 ` ahesford
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2020-08-04 11:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24040#discussion_r464981312

Comment:
Remove commented lines

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
  2020-08-04 11:41 ` [PR REVIEW] " ahesford
@ 2020-08-04 11:41 ` ahesford
  2020-08-04 11:41 ` ahesford
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2020-08-04 11:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24040#discussion_r464987679

Comment:
Remove `--prefix` argument. It is provided by the build style.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
                   ` (3 preceding siblings ...)
  2020-08-04 11:41 ` ahesford
@ 2020-08-04 11:41 ` ahesford
  2020-08-04 16:33 ` [PR PATCH] [Updated] " brihadeesh
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2020-08-04 11:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24040#discussion_r464988284

Comment:
Remove `perl`. The package seems to build fine without it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
  2020-08-04 11:41 ` [PR REVIEW] " ahesford
  2020-08-04 11:41 ` ahesford
@ 2020-08-04 11:41 ` ahesford
  2020-08-04 11:41 ` ahesford
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2020-08-04 11:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24040#discussion_r464987234

Comment:
Remove. This seems to build at least on `armv7l` and there's no reason it shouldn't build on all architectures.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
                   ` (4 preceding siblings ...)
  2020-08-04 11:41 ` ahesford
@ 2020-08-04 16:33 ` brihadeesh
  2020-08-04 16:47 ` brihadeesh
  2020-08-04 17:30 ` [PR PATCH] [Closed]: " ahesford
  7 siblings, 0 replies; 9+ messages in thread
From: brihadeesh @ 2020-08-04 16:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

There is an updated pull request by brihadeesh against master on the void-packages repository

https://github.com/brihadeesh/void-packages enlightenment16
https://github.com/void-linux/void-packages/pull/24040

New package: e16-1.0.22
New package: e16-1.0.22 (enlightenment DR16 window manager; current release).

These lines in `post_install()` seem to have no purpose but the kde and gnome session scripts provided by e16 might be of use to some:

```
vbin "misc/Xclients.e16-gnome.sh" e16-gnome
vbin "misc/Xclients.e16-kde.sh" e16-kde
```
I'm also uncertain as to whether this is the right usage of the vbin function.

PS: this is like my first PR ever!!

A patch file from https://github.com/void-linux/void-packages/pull/24040.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-enlightenment16-24040.patch --]
[-- Type: text/x-diff, Size: 1370 bytes --]

From 4e9241c61717e233c9159b7685c9d05085c28226 Mon Sep 17 00:00:00 2001
From: Brihadeesh <brihadeesh.santharam@gmail.com>
Date: Tue, 4 Aug 2020 11:18:06 +0530
Subject: [PATCH] New package: e16-1.0.22

---
 srcpkgs/e16/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/e16/template

diff --git a/srcpkgs/e16/template b/srcpkgs/e16/template
new file mode 100644
index 00000000000..1afa4d34d9b
--- /dev/null
+++ b/srcpkgs/e16/template
@@ -0,0 +1,24 @@
+# Template file for 'e16'
+pkgname=e16
+version=1.0.22
+revision=1
+build_style=gnu-configure
+configure_args="--sysconfdir=/etc --enable-sound=alsa"
+hostmakedepends="pkg-config tar"
+makedepends="pango-devel libXinerama-devel libXrandr-devel imlib2-devel libXcomposite-devel alsa-lib-devel libsndfile-devel"
+short_desc="Enlightenment DR16 window manager"
+maintainer="Brihadeesh <brihadeesh@protonmail.com>"
+license="BSD-2-Clause"
+homepage="https://www.enlightenment.org/e16"
+distfiles="$SOURCEFORGE_SITE/enlightenment/${pkgname}-${version}.tar.gz"
+checksum=b07d301a0a67ac020974afcbe779e1d48b376eab2e477fb189277c13b76d4a67
+
+post_install() {
+	# install gnome and kde session scripts
+	vbin "misc/Xclients.e16-gnome.sh" e16-gnome
+	vbin "misc/Xclients.e16-kde.sh" e16-kde
+
+	# licences for e16 and fonts(?)
+	vlicense COPYING
+	vlicense fonts/COPYRIGHT.Vera
+}

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
                   ` (5 preceding siblings ...)
  2020-08-04 16:33 ` [PR PATCH] [Updated] " brihadeesh
@ 2020-08-04 16:47 ` brihadeesh
  2020-08-04 17:30 ` [PR PATCH] [Closed]: " ahesford
  7 siblings, 0 replies; 9+ messages in thread
From: brihadeesh @ 2020-08-04 16:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by brihadeesh on void-packages repository

https://github.com/void-linux/void-packages/pull/24040#issuecomment-668706188

Comment:
Incorporated all requested changes.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Closed]: New package: e16-1.0.22
  2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
                   ` (6 preceding siblings ...)
  2020-08-04 16:47 ` brihadeesh
@ 2020-08-04 17:30 ` ahesford
  7 siblings, 0 replies; 9+ messages in thread
From: ahesford @ 2020-08-04 17:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

There's a closed pull request on the void-packages repository

New package: e16-1.0.22
https://github.com/void-linux/void-packages/pull/24040

Description:
New package: e16-1.0.22 (enlightenment DR16 window manager; current release).

These lines in `post_install()` seem to have no purpose but the kde and gnome session scripts provided by e16 might be of use to some:

```
vbin "misc/Xclients.e16-gnome.sh" e16-gnome
vbin "misc/Xclients.e16-kde.sh" e16-kde
```
I'm also uncertain as to whether this is the right usage of the vbin function.

PS: this is like my first PR ever!!

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-08-04 17:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04  5:57 [PR PATCH] New package: e16-1.0.22 brihadeesh
2020-08-04 11:41 ` [PR REVIEW] " ahesford
2020-08-04 11:41 ` ahesford
2020-08-04 11:41 ` ahesford
2020-08-04 11:41 ` ahesford
2020-08-04 11:41 ` ahesford
2020-08-04 16:33 ` [PR PATCH] [Updated] " brihadeesh
2020-08-04 16:47 ` brihadeesh
2020-08-04 17:30 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).