[ISSUE] flameshot: fail to build

[ISSUE] flameshot: fail to build

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 9425 bytes --]

New issue by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/issues/24127

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.7.13_1 x86_64 GenuineIntel notuptodate rFFFF
* package:  
  `flameshot_0.6.0_2`

### Expected behaviour
The package compiles and packages successfully
### Actual behaviour
```
$ ./xbps-src pkg flameshot
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> flameshot-0.6.0_2: removing autodeps, please wait...
=> flameshot-0.6.0_2: building [qmake] for x86_64...
   [target] qt5-svg-devel-5.15.0_2: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] desktop-file-utils-0.26_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] qt5-svg-5.15.0_2: found (https://alpha.de.repo.voidlinux.org/current)
=> flameshot-0.6.0_2: installing target dependencies: qt5-svg-devel-5.15.0_2 ...
=> flameshot-0.6.0_2: running do-fetch hook: 00-distfiles ...
=> flameshot-0.6.0_2: fetching distfile 'v0.6.0.tar.gz'...
v0.6.0.tar.gz: [0B 0%] 32MB/s ETA: unknown
v0.6.0.tar.gz: [0B 0%] 146KB/s ETA: unknown
v0.6.0.tar.gz: 627KB [avg rate: 5707KB/s]
=> flameshot-0.6.0_2: verifying checksum for distfile 'v0.6.0.tar.gz'... OK.
=> flameshot-0.6.0_2: running do-extract hook: 00-distfiles ...
=> flameshot-0.6.0_2: extracting distfile(s), please wait...
=> flameshot-0.6.0_2: running do-patch hook: 00-patches ...
=> flameshot-0.6.0_2: running pre-configure hook: 00-gnu-configure-asneeded ...
=> flameshot-0.6.0_2: running pre-configure hook: 01-override-config ...
=> flameshot-0.6.0_2: running pre-configure hook: 02-script-wrapper ...
=> flameshot-0.6.0_2: running do_configure ...
Info: creating stash file /builddir/flameshot-0.6.0/.qmake.stash
sh: git: command not found
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_es.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_es.qm'...
    Generated 149 translation(s) (149 finished and 0 unfinished)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_ca.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_ca.qm'...
    Generated 126 translation(s) (124 finished and 2 unfinished)
    Ignored 22 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_ru.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_ru.qm'...
    Generated 133 translation(s) (132 finished and 1 unfinished)
    Ignored 21 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_zh_CN.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_zh_CN.qm'...
    Generated 154 translation(s) (154 finished and 0 unfinished)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_zh_TW.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_zh_TW.qm'...
    Generated 132 translation(s) (129 finished and 3 unfinished)
    Ignored 22 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_tr.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_tr.qm'...
    Generated 149 translation(s) (148 finished and 1 unfinished)
    Ignored 5 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_ka.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_ka.qm'...
    Generated 132 translation(s) (129 finished and 3 unfinished)
    Ignored 22 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_fr.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_fr.qm'...
    Generated 133 translation(s) (132 finished and 1 unfinished)
    Ignored 15 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_pl.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_pl.qm'...
    Generated 146 translation(s) (146 finished and 0 unfinished)
    Ignored 2 untranslated source text(s)
=> flameshot-0.6.0_2: running pre-build hook: 02-script-wrapper ...
=> flameshot-0.6.0_2: running do_build ...
g++ -c -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -O2 -std=gnu++11 -Wall -Wextra -D_REENTRANT -fPIC -DAPP_VERSION=\"v0.6.0\" -DQT_DEPRECATED_WARNINGS -DQAPPLICATION_CLASS=QApplication -DAPP_PREFIX=\"/usr\" -DIMGUR_CLIENT_ID=\"313baf0c7b4d3ff\" -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_DBUS_LIB -DQT_CORE_LIB -I. -Isrc/third-party/singleapplication -Isrc/third-party/Qt-Color-Widgets/src -Isrc/third-party/Qt-Color-Widgets/include -I /usr/include/qt5 -I /usr/include/qt5/QtSvg -I /usr/include/qt5/QtWidgets -I /usr/include/qt5/QtGui -I /usr/include/qt5/QtNetwork -I /usr/include/qt5/QtDBus -I /usr/include/qt5/QtCore -I. -I/usr/lib/qt5/mkspecs/linux-g++ -o singleapplication.o src/third-party/singleapplication/singleapplication.cpp
src/third-party/singleapplication/singleapplication.cpp: In member function 'void SingleApplicationPrivate::genBlockServerName(int)':
src/third-party/singleapplication/singleapplication.cpp:110:33: warning: 'void QProcess::start(const QString&, QIODevice::OpenMode)' is deprecated: Use QProcess::start(const QString &program, const QStringList &arguments,OpenMode mode = ReadWrite) instead [-Wdeprecated-declarations]
  110 |         process.start( "whoami" );
      |                                 ^
In file included from /usr/include/qt5/QtCore/QProcess:1,
                 from src/third-party/singleapplication/singleapplication.cpp:26:
/usr/include/qt5/QtCore/qprocess.h:168:10: note: declared here
  168 |     void start(const QString &command, OpenMode mode = ReadWrite);
      |          ^~~~~
g++ -c -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -O2 -std=gnu++11 -Wall -Wextra -D_REENTRANT -fPIC -DAPP_VERSION=\"v0.6.0\" -DQT_DEPRECATED_WARNINGS -DQAPPLICATION_CLASS=QApplication -DAPP_PREFIX=\"/usr\" -DIMGUR_CLIENT_ID=\"313baf0c7b4d3ff\" -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_DBUS_LIB -DQT_CORE_LIB -I. -Isrc/third-party/singleapplication -Isrc/third-party/Qt-Color-Widgets/src -Isrc/third-party/Qt-Color-Widgets/include -I /usr/include/qt5 -I /usr/include/qt5/QtSvg -I /usr/include/qt5/QtWidgets -I /usr/include/qt5/QtGui -I /usr/include/qt5/QtNetwork -I /usr/include/qt5/QtDBus -I /usr/include/qt5/QtCore -I. -I/usr/lib/qt5/mkspecs/linux-g++ -o color_wheel.o src/third-party/Qt-Color-Widgets/src/color_wheel.cpp
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp: In constructor 'color_widgets::ColorWheel::Private::Private(color_widgets::ColorWheel*)':
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:68:55: warning: 'const QBrush& QPalette::background() const' is deprecated: Use QPalette::window() instead [-Wdeprecated-declarations]
   68 |         QColor bgColor = widget->palette().background().color();
      |                                                       ^
In file included from /usr/include/qt5/QtWidgets/qwidget.h:48,
                 from /usr/include/qt5/QtWidgets/QWidget:1,
                 from src/third-party/Qt-Color-Widgets/include/color_wheel.hpp:25,
                 from src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:22:
/usr/include/qt5/QtGui/qpalette.h:149:26: note: declared here
  149 |     inline const QBrush &background() const { return window(); }
      |                          ^~~~~~~~~~
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp: In member function 'virtual void color_widgets::ColorWheel::paintEvent(QPaintEvent*)':
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:350:22: error: aggregate 'QPainterPath clip' has incomplete type and cannot be defined
  350 |         QPainterPath clip;
      |                      ^~~~
make: *** [Makefile:1351: color_wheel.o] Error 1
=> ERROR: flameshot-0.6.0_2: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target} CC="$CC" CXX="$CXX" LINK="$CXX"' exited with 2
=> ERROR:   in do_build() at common/build-style/qmake.sh:134
```
### Steps to reproduce the behavior

Clone the repository and run `./xbps-src pkg flameshot`

Re: flameshot: fail to build

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/24127#issuecomment-670549300

Comment:
Qt5 changed their headers, so you'd have to find/create a patch that has the missing include. Quite a few packages we needed to rebuild for some reason have those.

Re: flameshot: fail to build

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/24127#issuecomment-677502521

Comment:
Ran into a weird issue to flameshot today, 99% sure it is related to this in some way.

Re: flameshot: fail to build

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/24127#issuecomment-677503620

Comment:
Here, steal this debian patch: https://salsa.debian.org/debian/flameshot/-/raw/master/debian/patches/0004-Missing-include-fix.patch

Add something like from debian at the top of the patch.

Re: flameshot: fail to build

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/24127#issuecomment-677503620

Comment:
Here, steal this debian patch: https://salsa.debian.org/debian/flameshot/-/raw/master/debian/patches/0004-Missing-include-fix.patch

Add something like from debian at the top of the patch.

EDIT: also see https://github.com/lupoDharkael/flameshot/pull/757 and the other part of the patch in the PR

Re: flameshot: fail to build

[biopsin]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New comment by biopsin on void-packages repository

https://github.com/void-linux/void-packages/issues/24127#issuecomment-745138766

Comment:
@ericonr
Seems fixed https://github.com/flameshot-org/flameshot/pull/757 ; https://github.com/flameshot-org/flameshot/issues/756#issuecomment-687220716

Re: flameshot: fail to build

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/24127#issuecomment-745292914

Comment:
Yup, we have flameshot 0.8.5 now. Thanks!

Re: [ISSUE] [CLOSED] flameshot: fail to build

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 9428 bytes --]

Closed issue by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/issues/24127

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.7.13_1 x86_64 GenuineIntel notuptodate rFFFF
* package:  
  `flameshot_0.6.0_2`

### Expected behaviour
The package compiles and packages successfully
### Actual behaviour
```
$ ./xbps-src pkg flameshot
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> flameshot-0.6.0_2: removing autodeps, please wait...
=> flameshot-0.6.0_2: building [qmake] for x86_64...
   [target] qt5-svg-devel-5.15.0_2: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] desktop-file-utils-0.26_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] qt5-svg-5.15.0_2: found (https://alpha.de.repo.voidlinux.org/current)
=> flameshot-0.6.0_2: installing target dependencies: qt5-svg-devel-5.15.0_2 ...
=> flameshot-0.6.0_2: running do-fetch hook: 00-distfiles ...
=> flameshot-0.6.0_2: fetching distfile 'v0.6.0.tar.gz'...
v0.6.0.tar.gz: [0B 0%] 32MB/s ETA: unknown
v0.6.0.tar.gz: [0B 0%] 146KB/s ETA: unknown
v0.6.0.tar.gz: 627KB [avg rate: 5707KB/s]
=> flameshot-0.6.0_2: verifying checksum for distfile 'v0.6.0.tar.gz'... OK.
=> flameshot-0.6.0_2: running do-extract hook: 00-distfiles ...
=> flameshot-0.6.0_2: extracting distfile(s), please wait...
=> flameshot-0.6.0_2: running do-patch hook: 00-patches ...
=> flameshot-0.6.0_2: running pre-configure hook: 00-gnu-configure-asneeded ...
=> flameshot-0.6.0_2: running pre-configure hook: 01-override-config ...
=> flameshot-0.6.0_2: running pre-configure hook: 02-script-wrapper ...
=> flameshot-0.6.0_2: running do_configure ...
Info: creating stash file /builddir/flameshot-0.6.0/.qmake.stash
sh: git: command not found
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_es.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_es.qm'...
    Generated 149 translation(s) (149 finished and 0 unfinished)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_ca.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_ca.qm'...
    Generated 126 translation(s) (124 finished and 2 unfinished)
    Ignored 22 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_ru.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_ru.qm'...
    Generated 133 translation(s) (132 finished and 1 unfinished)
    Ignored 21 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_zh_CN.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_zh_CN.qm'...
    Generated 154 translation(s) (154 finished and 0 unfinished)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_zh_TW.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_zh_TW.qm'...
    Generated 132 translation(s) (129 finished and 3 unfinished)
    Ignored 22 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_tr.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_tr.qm'...
    Generated 149 translation(s) (148 finished and 1 unfinished)
    Ignored 5 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_ka.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_ka.qm'...
    Generated 132 translation(s) (129 finished and 3 unfinished)
    Ignored 22 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_fr.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_fr.qm'...
    Generated 133 translation(s) (132 finished and 1 unfinished)
    Ignored 15 untranslated source text(s)
Updating '/builddir/flameshot-0.6.0/translations/Internationalization_pl.qm'...
Removing translations equal to source text in '/builddir/flameshot-0.6.0/translations/Internationalization_pl.qm'...
    Generated 146 translation(s) (146 finished and 0 unfinished)
    Ignored 2 untranslated source text(s)
=> flameshot-0.6.0_2: running pre-build hook: 02-script-wrapper ...
=> flameshot-0.6.0_2: running do_build ...
g++ -c -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -O2 -std=gnu++11 -Wall -Wextra -D_REENTRANT -fPIC -DAPP_VERSION=\"v0.6.0\" -DQT_DEPRECATED_WARNINGS -DQAPPLICATION_CLASS=QApplication -DAPP_PREFIX=\"/usr\" -DIMGUR_CLIENT_ID=\"313baf0c7b4d3ff\" -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_DBUS_LIB -DQT_CORE_LIB -I. -Isrc/third-party/singleapplication -Isrc/third-party/Qt-Color-Widgets/src -Isrc/third-party/Qt-Color-Widgets/include -I /usr/include/qt5 -I /usr/include/qt5/QtSvg -I /usr/include/qt5/QtWidgets -I /usr/include/qt5/QtGui -I /usr/include/qt5/QtNetwork -I /usr/include/qt5/QtDBus -I /usr/include/qt5/QtCore -I. -I/usr/lib/qt5/mkspecs/linux-g++ -o singleapplication.o src/third-party/singleapplication/singleapplication.cpp
src/third-party/singleapplication/singleapplication.cpp: In member function 'void SingleApplicationPrivate::genBlockServerName(int)':
src/third-party/singleapplication/singleapplication.cpp:110:33: warning: 'void QProcess::start(const QString&, QIODevice::OpenMode)' is deprecated: Use QProcess::start(const QString &program, const QStringList &arguments,OpenMode mode = ReadWrite) instead [-Wdeprecated-declarations]
  110 |         process.start( "whoami" );
      |                                 ^
In file included from /usr/include/qt5/QtCore/QProcess:1,
                 from src/third-party/singleapplication/singleapplication.cpp:26:
/usr/include/qt5/QtCore/qprocess.h:168:10: note: declared here
  168 |     void start(const QString &command, OpenMode mode = ReadWrite);
      |          ^~~~~
g++ -c -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -O2 -std=gnu++11 -Wall -Wextra -D_REENTRANT -fPIC -DAPP_VERSION=\"v0.6.0\" -DQT_DEPRECATED_WARNINGS -DQAPPLICATION_CLASS=QApplication -DAPP_PREFIX=\"/usr\" -DIMGUR_CLIENT_ID=\"313baf0c7b4d3ff\" -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_DBUS_LIB -DQT_CORE_LIB -I. -Isrc/third-party/singleapplication -Isrc/third-party/Qt-Color-Widgets/src -Isrc/third-party/Qt-Color-Widgets/include -I /usr/include/qt5 -I /usr/include/qt5/QtSvg -I /usr/include/qt5/QtWidgets -I /usr/include/qt5/QtGui -I /usr/include/qt5/QtNetwork -I /usr/include/qt5/QtDBus -I /usr/include/qt5/QtCore -I. -I/usr/lib/qt5/mkspecs/linux-g++ -o color_wheel.o src/third-party/Qt-Color-Widgets/src/color_wheel.cpp
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp: In constructor 'color_widgets::ColorWheel::Private::Private(color_widgets::ColorWheel*)':
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:68:55: warning: 'const QBrush& QPalette::background() const' is deprecated: Use QPalette::window() instead [-Wdeprecated-declarations]
   68 |         QColor bgColor = widget->palette().background().color();
      |                                                       ^
In file included from /usr/include/qt5/QtWidgets/qwidget.h:48,
                 from /usr/include/qt5/QtWidgets/QWidget:1,
                 from src/third-party/Qt-Color-Widgets/include/color_wheel.hpp:25,
                 from src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:22:
/usr/include/qt5/QtGui/qpalette.h:149:26: note: declared here
  149 |     inline const QBrush &background() const { return window(); }
      |                          ^~~~~~~~~~
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp: In member function 'virtual void color_widgets::ColorWheel::paintEvent(QPaintEvent*)':
src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:350:22: error: aggregate 'QPainterPath clip' has incomplete type and cannot be defined
  350 |         QPainterPath clip;
      |                      ^~~~
make: *** [Makefile:1351: color_wheel.o] Error 1
=> ERROR: flameshot-0.6.0_2: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target} CC="$CC" CXX="$CXX" LINK="$CXX"' exited with 2
=> ERROR:   in do_build() at common/build-style/qmake.sh:134
```
### Steps to reproduce the behavior

Clone the repository and run `./xbps-src pkg flameshot`