Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] cross-vpkg-dummy: remove musl-legacy-compat.
@ 2020-08-10 14:04 ericonr
  2020-08-13  1:33 ` [PR PATCH] [Merged]: " sgn
  0 siblings, 1 reply; 2+ messages in thread
From: ericonr @ 2020-08-10 14:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages cross
https://github.com/void-linux/void-packages/pull/24198

cross-vpkg-dummy: remove musl-legacy-compat.
musl-legacy-compat was removed from base-chroot-musl in
75eca1b03e453d9e643b809550d5157717e46738, meaning that all templates
that depend on it had to add it as makedepends for native musl builds.
Therefore, for consistency, cross-vpkg-dummy shouldn't pull it either.

--

This template has a few stylistic issues and shouldn't pass xlint. Should I solve those?

A patch file from https://github.com/void-linux/void-packages/pull/24198.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cross-24198.patch --]
[-- Type: text/x-diff, Size: 1293 bytes --]

From 954e6497a0b2fb7664a239d7f69e0f4ca2852682 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 10 Aug 2020 10:56:57 -0300
Subject: [PATCH] cross-vpkg-dummy: remove musl-legacy-compat.

musl-legacy-compat was removed from base-chroot-musl in
75eca1b03e453d9e643b809550d5157717e46738, meaning that all templates
that depend on it had to add it as makedepends for native musl builds.
Therefore, for consistency, cross-vpkg-dummy shouldn't pull it either.
---
 srcpkgs/cross-vpkg-dummy/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/cross-vpkg-dummy/template b/srcpkgs/cross-vpkg-dummy/template
index fd8d84f8d64..e2a08d2404d 100644
--- a/srcpkgs/cross-vpkg-dummy/template
+++ b/srcpkgs/cross-vpkg-dummy/template
@@ -1,6 +1,6 @@
 # Template file for 'cross-vpkg-dummy'
 pkgname=cross-vpkg-dummy
-version=0.34
+version=0.35
 revision=1
 build_style=meta
 short_desc="Dummy meta-pkg for cross building packages with xbps-src"
@@ -60,8 +60,7 @@ shlib_provides="
 	libgfortran.so.5"
 
 case "$XBPS_TARGET_MACHINE" in
-*-musl) depends+=" musl-legacy-compat"
-	provides+=" musl-9999_1 musl-devel-9999_1"
+*-musl) provides+=" musl-9999_1 musl-devel-9999_1"
 	conflicts+=" musl>=0"
 	shlib_provides+=" libc.so"
 	;;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: cross-vpkg-dummy: remove musl-legacy-compat.
  2020-08-10 14:04 [PR PATCH] cross-vpkg-dummy: remove musl-legacy-compat ericonr
@ 2020-08-13  1:33 ` sgn
  0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2020-08-13  1:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

There's a merged pull request on the void-packages repository

cross-vpkg-dummy: remove musl-legacy-compat.
https://github.com/void-linux/void-packages/pull/24198

Description:
musl-legacy-compat was removed from base-chroot-musl in
75eca1b03e453d9e643b809550d5157717e46738, meaning that all templates
that depend on it had to add it as makedepends for native musl builds.
Therefore, for consistency, cross-vpkg-dummy shouldn't pull it either.

---

This template has a few stylistic issues and shouldn't pass xlint. Should I solve those?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-13  1:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 14:04 [PR PATCH] cross-vpkg-dummy: remove musl-legacy-compat ericonr
2020-08-13  1:33 ` [PR PATCH] [Merged]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).