[PR PATCH] busybox: enable cttyhack applet

[PR PATCH] busybox: enable cttyhack applet

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

There is a new pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages busybox
https://github.com/void-linux/void-packages/pull/24238

busybox: enable cttyhack applet


A patch file from https://github.com/void-linux/void-packages/pull/24238.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-busybox-24238.patch --]
[-- Type: text/x-diff, Size: 1153 bytes --]

From 929870bcd727d8831b1773254678e8331f3428ed Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Tue, 11 Aug 2020 22:44:45 -0500
Subject: [PATCH] busybox: enable cttyhack applet

---
 srcpkgs/busybox/files/dotconfig | 2 +-
 srcpkgs/busybox/template        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/busybox/files/dotconfig b/srcpkgs/busybox/files/dotconfig
index 7ffa16501c9..68876b0821a 100644
--- a/srcpkgs/busybox/files/dotconfig
+++ b/srcpkgs/busybox/files/dotconfig
@@ -1110,7 +1110,7 @@ CONFIG_ASH_TEST=y
 CONFIG_ASH_HELP=y
 CONFIG_ASH_GETOPTS=y
 CONFIG_ASH_CMDCMD=y
-# CONFIG_CTTYHACK is not set
+CONFIG_CTTYHACK=y
 # CONFIG_HUSH is not set
 # CONFIG_HUSH_BASH_COMPAT is not set
 # CONFIG_HUSH_BRACE_EXPANSION is not set
diff --git a/srcpkgs/busybox/template b/srcpkgs/busybox/template
index 986397d992b..9dc90e4daf1 100644
--- a/srcpkgs/busybox/template
+++ b/srcpkgs/busybox/template
@@ -1,7 +1,7 @@
 # Template file for 'busybox'
 pkgname=busybox
 version=1.31.1
-revision=1
+revision=2
 hostmakedepends="perl"
 checkdepends="zip"
 short_desc="Swiss Army Knife of Embedded Linux"

Re: busybox: enable cttyhack applet

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24238#issuecomment-672833276

Comment:
why?

Re: busybox: enable cttyhack applet

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24238#issuecomment-672833276

Comment:
why? possible side-effects?

Re: busybox: enable cttyhack applet

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24238#issuecomment-672839466

Comment:
It can be used to enable job-control in dracut's emergency shell.

Re: busybox: enable cttyhack applet

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/24238#issuecomment-672889224

Comment:
> why? possible side-effects?

I'd like to use that busybox applet/module in other software I create. I don't believe there are any side-effects to enabling another built-in module - I tested it locally without any problems.

Re: busybox: enable cttyhack applet

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24238#issuecomment-673334846

Comment:
I was under the impression that the "no job control" issue in initramfs was due to insufficient bind mounts

Re: busybox: enable cttyhack applet

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24238#issuecomment-673334846

Comment:
~I was under the impression that the "no job control" issue in initramfs was due to insufficient bind mounts~
https://busybox.net/FAQ.html#job_control

Re: [PR PATCH] [Merged]: busybox: enable cttyhack applet

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

There's a merged pull request on the void-packages repository

busybox: enable cttyhack applet
https://github.com/void-linux/void-packages/pull/24238

Description: