[PR PATCH] base-files: modify kernel listing in vkpurge

[PR PATCH] base-files: modify kernel listing in vkpurge

[Ypnose]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

There is a new pull request by Ypnose against master on the void-packages repository

https://github.com/Ypnose/void-packages master
https://github.com/void-linux/void-packages/pull/24310

base-files: modify kernel listing in vkpurge
By default, kernel listing is not done by version, For example :

4.19.131_1
5.4.18_1
5.4.50_1
5.4.5_1
5.4.9_1
5.4.11_1

Using 'version-sort' option, it shows older versions before recent versions :
4.19.131_1
5.4.5_1
5.4.9_1
5.4.11_1
5.4.18_1
5.4.50_1

A patch file from https://github.com/void-linux/void-packages/pull/24310.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24310.patch --]
[-- Type: text/x-diff, Size: 909 bytes --]

From 72a51d340595c06d8fa8d26342923088918f9819 Mon Sep 17 00:00:00 2001
From: Ypnose <Ypnose@users.noreply.github.com>
Date: Sun, 16 Aug 2020 17:01:26 +0200
Subject: [PATCH] base-files: modify kernel listing in vkpurge

By default, kernel listing is not done by version, For example :

4.19.131_1
5.4.18_1
5.4.50_1
5.4.5_1
5.4.9_1
5.4.11_1

Using 'version-sort' option, it shows older versions before recent versions :
4.19.131_1
5.4.5_1
5.4.9_1
5.4.11_1
5.4.18_1
5.4.50_1
---
 srcpkgs/base-files/files/vkpurge | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/base-files/files/vkpurge b/srcpkgs/base-files/files/vkpurge
index 5519147b905..c7c6a78f6b2 100644
--- a/srcpkgs/base-files/files/vkpurge
+++ b/srcpkgs/base-files/files/vkpurge
@@ -33,7 +33,7 @@ list_kernels() {
 				$pattern) printf "%s\n" "$kver" ;;
 			esac
 		done
-	done | sort -u
+	done | sort -uV
 }
 
 run_hooks() {

Re: [PR PATCH] [Updated] base-files: modify kernel listing in vkpurge

[Ypnose]

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

There is an updated pull request by Ypnose against master on the void-packages repository

https://github.com/Ypnose/void-packages master
https://github.com/void-linux/void-packages/pull/24310

base-files: modify kernel listing in vkpurge
By default, kernel listing is not done by version. For example :

    4.19.131_1
    5.4.18_1
    5.4.50_1
    5.4.5_1
    5.4.9_1
    5.4.11_1

Using 'version-sort' option, it shows older versions before recent versions :

    4.19.131_1
    5.4.5_1
    5.4.9_1
    5.4.11_1
    5.4.18_1
    5.4.50_1

A patch file from https://github.com/void-linux/void-packages/pull/24310.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24310.patch --]
[-- Type: text/x-diff, Size: 1577 bytes --]

From 72a51d340595c06d8fa8d26342923088918f9819 Mon Sep 17 00:00:00 2001
From: Ypnose <Ypnose@users.noreply.github.com>
Date: Sun, 16 Aug 2020 17:01:26 +0200
Subject: [PATCH 1/2] base-files: modify kernel listing in vkpurge

By default, kernel listing is not done by version, For example :

4.19.131_1
5.4.18_1
5.4.50_1
5.4.5_1
5.4.9_1
5.4.11_1

Using 'version-sort' option, it shows older versions before recent versions :
4.19.131_1
5.4.5_1
5.4.9_1
5.4.11_1
5.4.18_1
5.4.50_1
---
 srcpkgs/base-files/files/vkpurge | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/base-files/files/vkpurge b/srcpkgs/base-files/files/vkpurge
index 5519147b905..c7c6a78f6b2 100644
--- a/srcpkgs/base-files/files/vkpurge
+++ b/srcpkgs/base-files/files/vkpurge
@@ -33,7 +33,7 @@ list_kernels() {
 				$pattern) printf "%s\n" "$kver" ;;
 			esac
 		done
-	done | sort -u
+	done | sort -uV
 }
 
 run_hooks() {

From 2d94a245cf88702ea295b512a8e4d2f9cdde2c8d Mon Sep 17 00:00:00 2001
From: Ypnose <Ypnose@users.noreply.github.com>
Date: Sun, 16 Aug 2020 17:06:44 +0200
Subject: [PATCH 2/2] base-files: update revision

---
 srcpkgs/base-files/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/base-files/template b/srcpkgs/base-files/template
index 6b503690606..b34c40c697a 100644
--- a/srcpkgs/base-files/template
+++ b/srcpkgs/base-files/template
@@ -1,7 +1,7 @@
 # Template file for 'base-files'
 pkgname=base-files
 version=0.141
-revision=2
+revision=3
 bootstrap=yes
 depends="xbps-triggers"
 short_desc="Void Linux base system files"

Re: base-files: modify kernel listing in vkpurge

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-677742444

Comment:
Please rebase, `base-files` has already been revbumped.

Re: base-files: modify kernel listing in vkpurge

[Ypnose]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

New comment by Ypnose on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-678052709

Comment:
I did that pull request using web interface. You can directly rebase when you accept the pull request :
https://github.blog/2016-09-26-rebase-and-merge-pull-requests/

Re: [PR PATCH] [Closed]: base-files: modify kernel listing in vkpurge

[sgn]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

There's a closed pull request on the void-packages repository

base-files: modify kernel listing in vkpurge
https://github.com/void-linux/void-packages/pull/24310

Description:
By default, kernel listing is not done by version. For example :

    4.19.131_1
    5.4.18_1
    5.4.50_1
    5.4.5_1
    5.4.9_1
    5.4.11_1

Using 'version-sort' option, it shows older versions before recent versions :

    4.19.131_1
    5.4.5_1
    5.4.9_1
    5.4.11_1
    5.4.18_1
    5.4.50_1

Re: base-files: modify kernel listing in vkpurge

[q66]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-678245389

Comment:
version sort is not standard in POSIX, so this might break depending on which implementation of sort people are using

Re: base-files: modify kernel listing in vkpurge

[sgn]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-678256649

Comment:
It seems like I messed up again.

Re: base-files: modify kernel listing in vkpurge

[q66]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-678284283

Comment:
it's probably fine, as the common implementations have it (gnu sort, busybox sort, freebsd sort), just pointing out that this is not POSIX

Re: base-files: modify kernel listing in vkpurge

[Ypnose]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

New comment by Ypnose on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-678450927

Comment:
On Void Linux, `sort` is provided by `GNU coreutils`. I assume people will use this variant. The idea here is not to support every `sort` implementation. Even `OpenBSD` which is known to be restrictive, supports this option. I do not understand how your comment helps us here. If Void Linux needs to stick to POSIX which is totally fine, please provide me a link where it is specified. In that case, this PR can be ignored.

Re: base-files: modify kernel listing in vkpurge

[Ypnose]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by Ypnose on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-679244005

Comment:
@sgn May I know why this pull request was closed and therefore refused ?

Re: base-files: modify kernel listing in vkpurge

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-679244932

Comment:
The pull request was closed by merging your change (with the revbump).

Re: base-files: modify kernel listing in vkpurge

[sgn]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-679425029

Comment:
On 2020-08-24 09:50:59-0700, Ypnose <notifications@github.com> wrote:
> @sgn May I know why this pull request was closed and therefore refused ?

It's merged, but not with the button:
https://github.com/void-linux/void-packages/commit/7bffaa5d0ec074cae8c4948810e3212a6f29754d

Re: base-files: modify kernel listing in vkpurge

[Ypnose]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by Ypnose on void-packages repository

https://github.com/void-linux/void-packages/pull/24310#issuecomment-683381833

Comment:
My apologies, I didn't notice.