[ISSUE] XBPS_PKG_OPTIONS_<package> isn't working

[ISSUE] XBPS_PKG_OPTIONS_<package> isn't working

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/24313

Description:
### Expected behavior

Setting `XBPS_PKG_OPTIONS_execline=static` in `etc/conf` and running `./xbps-src pkg execline` should build a statically linked `execline` package.

### Actual behavior

The package is built normally, as if no option had been selected.

---

Need to take a look through the code to see where the variable is lost.

Re: XBPS_PKG_OPTIONS_<package> isn't working

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/issues/24313#issuecomment-675161920

Comment:
Is this even meant to work? I can't find *any* reference to `XBPS_PKG_OPTIONS_package` in the repository.

Re: XBPS_PKG_OPTIONS_<package> isn't working

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/24313#issuecomment-675165829

Comment:
From `README.md`

```
Permanent global package build options can be set via `XBPS_PKG_OPTIONS` variable in the
`etc/conf` configuration file. Per package build options can be set via
`XBPS_PKG_OPTIONS_<pkgname>`.
```

And from `common/xbps-src/shutils/common.sh`:

```
        _pkgname=${pkgname//[^A-Za-z0-9_]/_}
        eval pkgopts="\$XBPS_PKG_OPTIONS_${_pkgname}"
        if [ -z "$pkgopts" -o "$pkgopts" = "" ]; then
            pkgopts=${XBPS_PKG_OPTIONS}
        fi
```

Re: XBPS_PKG_OPTIONS_<package> isn't working

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/24313#issuecomment-678583149

Comment:
```
% ./xbps-src show-options execline
=> execline-2.6.1.0_1: the following build options are set:
   static: Enable static linking (OFF)

% echo "XBPS_PKG_OPTIONS_execline=static >> etc/conf

% ./xbps-src show-options execline
=> execline-2.6.1.0_1: the following build options are set:
   static: Enable static linking (ON)
```
This looks more like a problem of `execline` not honoring the build option than an XBPS issue.

Re: XBPS_PKG_OPTIONS_<package> isn't working

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/24313#issuecomment-678585057

Comment:
It doesn't work for runit either, and can be seen when building a package.

```
$ ./xbps-src pkg runit
=> xbps-src: updating repositories for host (x86_64-musl)...
[*] Updating repository `https://mirror.clarkson.edu/voidlinux/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://mirror.clarkson.edu/voidlinux/current/musl/nonfree/x86_64-musl-repodata' ...
[*] Updating repository `https://mirror.clarkson.edu/voidlinux/current/musl/debug/x86_64-musl-repodata' ...
[*] Updating repository `https://repo.voidlinux.de/i686-musl//x86_64-musl-repodata' ...
ERROR: [reposync] failed to fetch file `https://repo.voidlinux.de/i686-musl//x86_64-musl-repodata': Not Found
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> runit-2.1.2_11: removing autodeps, please wait...
=> runit-2.1.2_11: the following build options are set:
   static: Enable static linking (OFF)
=> runit-2.1.2_11: building [gnu-makefile] for x86_64-musl...
```

Re: XBPS_PKG_OPTIONS_<package> isn't working

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/24313#issuecomment-678589324

Comment:
It seems to be affecting the build, but `xbps-src` forgets about the build option somewhere, because building `runit` as above actually makes it static.

Re: [ISSUE] [CLOSED] XBPS_PKG_OPTIONS_<package> isn't working

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Closed issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/24313

Description:
### Expected behavior

Setting `XBPS_PKG_OPTIONS_execline=static` in `etc/conf` and running `./xbps-src pkg execline` should build a statically linked `execline` package.

### Actual behavior

The package is built normally, as if no option had been selected.

---

Need to take a look through the code to see where the variable is lost.