[PR PATCH] chroot-style/uchroot: add -t parameter to command.

[PR PATCH] chroot-style/uchroot: add -t parameter to command.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages uchroot
https://github.com/void-linux/void-packages/pull/24314

chroot-style/uchroot: add -t parameter to command.
Without it, using xbps-src with overlay errors out with the message
below:

ERROR: failed to mount overlayfs on
/home/ericonr/void/void-packages/masterdir.XXXXdMemKO/masterdir (Invalid
argument)

---

I don't know if I'm the only one seeing this.

A patch file from https://github.com/void-linux/void-packages/pull/24314.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-uchroot-24314.patch --]
[-- Type: text/x-diff, Size: 1014 bytes --]

From 2060598c5083ced08b3926be563a3990b03394cb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 16 Aug 2020 23:52:52 -0300
Subject: [PATCH] chroot-style/uchroot: add -t parameter to command.

Without it, using xbps-src with overlay errors out with the message
below:

ERROR: failed to mount overlayfs on
/home/ericonr/void/void-packages/masterdir.XXXXdMemKO/masterdir (Invalid
argument)
---
 common/chroot-style/uchroot.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/chroot-style/uchroot.sh b/common/chroot-style/uchroot.sh
index 2f9dbb2d45f..074fd1cae88 100755
--- a/common/chroot-style/uchroot.sh
+++ b/common/chroot-style/uchroot.sh
@@ -18,4 +18,4 @@ if [ -z "$MASTERDIR" -o -z "$DISTDIR" ]; then
 	exit 1
 fi
 
-exec xbps-uchroot $EXTRA_ARGS -b $DISTDIR:/void-packages ${HOSTDIR:+-b $HOSTDIR:/host} -- $MASTERDIR $CMD $@
+exec xbps-uchroot -t $EXTRA_ARGS -b $DISTDIR:/void-packages ${HOSTDIR:+-b $HOSTDIR:/host} -- $MASTERDIR $CMD $@

Re: chroot-style/uchroot: add -t parameter to command.

[q66]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24314#issuecomment-686455429

Comment:
overlayfs is not supported on zfs

Re: [PR PATCH] [Closed]: chroot-style/uchroot: add -t parameter to command.

[q66]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There's a closed pull request on the void-packages repository

chroot-style/uchroot: add -t parameter to command.
https://github.com/void-linux/void-packages/pull/24314

Description:
Without it, using xbps-src with overlay errors out with the message
below:

ERROR: failed to mount overlayfs on
/home/ericonr/void/void-packages/masterdir.XXXXdMemKO/masterdir (Invalid
argument)

---

I don't know if I'm the only one seeing this.

Re: chroot-style/uchroot: add -t parameter to command.

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24314#issuecomment-686583901

Comment:
Perhaps `chroot-style/uchroot` can check the mount point's filesystem and error out if with a explicit message.
Some lines using `findmnt` from `util-linux` can be used to tell a path's file system:
```
#!/bin/bash
path=$PWD
while [ -z "$FSTYPE" -a ! -z "$path" ]; do
	eval $(findmnt -P "$path")
	path=${path%/*}
done
echo "$FSTYPE"
```

Re: chroot-style/uchroot: add -t parameter to command.

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24314#issuecomment-686583901

Comment:
Perhaps `chroot-style/uchroot` can check the mount point's filesystem and error out if with an explicit message.
Some lines using `findmnt` from `util-linux` can be used to tell a path's file system:
```
#!/bin/bash
path=$PWD
while [ -z "$FSTYPE" -a ! -z "$path" ]; do
	eval $(findmnt -P "$path")
	path=${path%/*}
done
echo "$FSTYPE"
```

Re: chroot-style/uchroot: add -t parameter to command.

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24314#issuecomment-686583901

Comment:
Perhaps `chroot-style/uchroot` can check the mount point's filesystem and error out if with an explicit message.
Some lines using `findmnt` from `util-linux` can be used to tell a path's file system:
```
#!/bin/bash
path=$PWD
while [ -z "$FSTYPE" -a ! -z "$path" ]; do
	eval $(findmnt -P "$path")
	path="${path%/*}"
done
echo "$FSTYPE"
```

Re: chroot-style/uchroot: add -t parameter to command.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24314#issuecomment-686598886

Comment:
@pullmoll perhaps to avoid adding complexity to the script itself, we could add a message that `-t` might not work on all filesystems...

Re: chroot-style/uchroot: add -t parameter to command.

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24314#issuecomment-686611192

Comment:
@ericonr Agree.