* [PR PATCH] milkytracker: added rtmidi for midi support.
@ 2020-08-22 21:34 telamon
2020-08-22 22:51 ` [PR PATCH] [Updated] " telamon
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: telamon @ 2020-08-22 21:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
There is a new pull request by telamon against master on the void-packages repository
https://github.com/telamon/void-packages milkytracker-rtmidi
https://github.com/void-linux/void-packages/pull/24427
milkytracker: added rtmidi for midi support.
Recompiled with librtmidi to enable support for midi-devices.
A patch file from https://github.com/void-linux/void-packages/pull/24427.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-milkytracker-rtmidi-24427.patch --]
[-- Type: text/x-diff, Size: 1020 bytes --]
From 6788018cf41ebdad7d46946f5bee576a3fa7d68c Mon Sep 17 00:00:00 2001
From: Tony Ivanov <telamohn@pm.me>
Date: Sat, 22 Aug 2020 23:30:57 +0200
Subject: [PATCH] Recompiled with librtmidi to enable support for midi-devices
---
srcpkgs/milkytracker/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/milkytracker/template b/srcpkgs/milkytracker/template
index f9a985b7997..a85cc055d0c 100644
--- a/srcpkgs/milkytracker/template
+++ b/srcpkgs/milkytracker/template
@@ -1,12 +1,12 @@
# Template file for 'milkytracker'
pkgname=milkytracker
version=1.02.00
-revision=1
+revision=2
build_style=cmake
wrksrc=MilkyTracker-${version}
configure_args="--with-alsa --with-jack"
-makedepends="SDL2-devel zlib-devel jack-devel alsa-lib-devel"
-depends="libjack"
+makedepends="SDL2-devel zlib-devel jack-devel alsa-lib-devel rtmidi-devel"
+depends="libjack rtmidi"
short_desc="Fast Tracker II inspired music tracker"
maintainer="bra1nwave <brainwave@openmailbox.org>"
license="GPL-3"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] milkytracker: added rtmidi for midi support.
2020-08-22 21:34 [PR PATCH] milkytracker: added rtmidi for midi support telamon
@ 2020-08-22 22:51 ` telamon
2020-08-27 14:30 ` ahesford
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: telamon @ 2020-08-22 22:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by telamon against master on the void-packages repository
https://github.com/telamon/void-packages milkytracker-rtmidi
https://github.com/void-linux/void-packages/pull/24427
milkytracker: added rtmidi for midi support.
Recompiled with librtmidi to enable support for midi-devices.
A patch file from https://github.com/void-linux/void-packages/pull/24427.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-milkytracker-rtmidi-24427.patch --]
[-- Type: text/x-diff, Size: 2130 bytes --]
From 6788018cf41ebdad7d46946f5bee576a3fa7d68c Mon Sep 17 00:00:00 2001
From: Tony Ivanov <telamohn@pm.me>
Date: Sat, 22 Aug 2020 23:30:57 +0200
Subject: [PATCH 1/2] Recompiled with librtmidi to enable support for
midi-devices
---
srcpkgs/milkytracker/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/milkytracker/template b/srcpkgs/milkytracker/template
index f9a985b7997..a85cc055d0c 100644
--- a/srcpkgs/milkytracker/template
+++ b/srcpkgs/milkytracker/template
@@ -1,12 +1,12 @@
# Template file for 'milkytracker'
pkgname=milkytracker
version=1.02.00
-revision=1
+revision=2
build_style=cmake
wrksrc=MilkyTracker-${version}
configure_args="--with-alsa --with-jack"
-makedepends="SDL2-devel zlib-devel jack-devel alsa-lib-devel"
-depends="libjack"
+makedepends="SDL2-devel zlib-devel jack-devel alsa-lib-devel rtmidi-devel"
+depends="libjack rtmidi"
short_desc="Fast Tracker II inspired music tracker"
maintainer="bra1nwave <brainwave@openmailbox.org>"
license="GPL-3"
From 49828ea7f8174e92a5d98cc8ab8e0cb974340fc9 Mon Sep 17 00:00:00 2001
From: Tony Ivanov <telamohn@pm.me>
Date: Sun, 23 Aug 2020 00:51:45 +0200
Subject: [PATCH 2/2] Fixed xlint complaints
---
srcpkgs/milkytracker/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/milkytracker/template b/srcpkgs/milkytracker/template
index a85cc055d0c..9f5cffd6130 100644
--- a/srcpkgs/milkytracker/template
+++ b/srcpkgs/milkytracker/template
@@ -2,14 +2,14 @@
pkgname=milkytracker
version=1.02.00
revision=2
-build_style=cmake
wrksrc=MilkyTracker-${version}
+build_style=cmake
configure_args="--with-alsa --with-jack"
makedepends="SDL2-devel zlib-devel jack-devel alsa-lib-devel rtmidi-devel"
depends="libjack rtmidi"
short_desc="Fast Tracker II inspired music tracker"
maintainer="bra1nwave <brainwave@openmailbox.org>"
-license="GPL-3"
+license="GPL-3.0-only"
homepage="http://milkytracker.titandemo.org/"
distfiles="https://github.com/milkytracker/MilkyTracker/archive/v${version}.tar.gz"
checksum=6bcb6e74ee333e831137435a25c0f2f3da6e1462864deec9e693ef7d23a16023
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: milkytracker: added rtmidi for midi support.
2020-08-22 21:34 [PR PATCH] milkytracker: added rtmidi for midi support telamon
2020-08-22 22:51 ` [PR PATCH] [Updated] " telamon
@ 2020-08-27 14:30 ` ahesford
2020-09-02 7:33 ` telamon
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-08-27 14:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24427#issuecomment-681985932
Comment:
Please squash thes commits into one. Should this be a build option rather than a compulsory dependency?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: milkytracker: added rtmidi for midi support.
2020-08-22 21:34 [PR PATCH] milkytracker: added rtmidi for midi support telamon
2020-08-22 22:51 ` [PR PATCH] [Updated] " telamon
2020-08-27 14:30 ` ahesford
@ 2020-09-02 7:33 ` telamon
2020-09-02 16:02 ` ahesford
2020-09-06 21:37 ` [PR PATCH] [Merged]: " ahesford
4 siblings, 0 replies; 6+ messages in thread
From: telamon @ 2020-09-02 7:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
New comment by telamon on void-packages repository
https://github.com/void-linux/void-packages/pull/24427#issuecomment-685412188
Comment:
@ahesford I'll fix the squash, as for the build option I can't really say.
Using milky-tracker without midi-hardware is quite hardcore-retro. Having this as a build option will be a bit hit-and-miss just the same as force enabling the rtmidi dependency would be.
I believe chances are equally high that whoever has an opinion about this item is going to be forced to recompile milky from source.
If I understand the milky-docs correctly then `rtmidi` is it's sole dependency to interact with a midi-signal, there are no other options.
Rtmidi compulsory dependency **pros**
Newbies can just plug in their midi-keyboard, xbps-install milky, start it up and use `aconnect` to patch the midisignal into milkytracker.
**Cons**
People that still use milky without midi-hardware (if-exists) will experience a few extra kilobytes of binary installation size.
Thoughts anyone???
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: milkytracker: added rtmidi for midi support.
2020-08-22 21:34 [PR PATCH] milkytracker: added rtmidi for midi support telamon
` (2 preceding siblings ...)
2020-09-02 7:33 ` telamon
@ 2020-09-02 16:02 ` ahesford
2020-09-06 21:37 ` [PR PATCH] [Merged]: " ahesford
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-09-02 16:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24427#issuecomment-685834272
Comment:
Based on your argument, I don't have a problem with adding `rtmidi` as a hard dependency, unless maintainer @bra1nwave has an objection.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: milkytracker: added rtmidi for midi support.
2020-08-22 21:34 [PR PATCH] milkytracker: added rtmidi for midi support telamon
` (3 preceding siblings ...)
2020-09-02 16:02 ` ahesford
@ 2020-09-06 21:37 ` ahesford
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-09-06 21:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
There's a merged pull request on the void-packages repository
milkytracker: added rtmidi for midi support.
https://github.com/void-linux/void-packages/pull/24427
Description:
Recompiled with librtmidi to enable support for midi-devices.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-06 21:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 21:34 [PR PATCH] milkytracker: added rtmidi for midi support telamon
2020-08-22 22:51 ` [PR PATCH] [Updated] " telamon
2020-08-27 14:30 ` ahesford
2020-09-02 7:33 ` telamon
2020-09-02 16:02 ` ahesford
2020-09-06 21:37 ` [PR PATCH] [Merged]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).