[PR PATCH] Add general localized man pages, remove hook that removes them.

[PR PATCH] Add general localized man pages, remove hook that removes them.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages l10n
https://github.com/void-linux/void-packages/pull/24443

Add general localized man pages, remove hook that removes them.
Why does this hook exist? `mdocml` doesn't seem to support localized pages, but `man-db` does.

I need some help on the `manpages-l10n` package, since setting `build_style=meta` would force me to manually specify a lot of functions for no gain, and the license shouldn't be `vlicense`d. So `xbps-src` is complaining the package is empty :/ 



A patch file from https://github.com/void-linux/void-packages/pull/24443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-l10n-24443.patch --]
[-- Type: text/x-diff, Size: 4487 bytes --]

From d6cce362eb535f7d5d8309afaa5c21a0cdbc34f4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 23 Aug 2020 20:27:21 -0300
Subject: [PATCH 1/2] remove-localized-manpages: remove hook.

---
 .../01-remove-localized-manpages.sh           | 20 -------------------
 1 file changed, 20 deletions(-)
 delete mode 100644 common/hooks/post-install/01-remove-localized-manpages.sh

diff --git a/common/hooks/post-install/01-remove-localized-manpages.sh b/common/hooks/post-install/01-remove-localized-manpages.sh
deleted file mode 100644
index bee8d9d84e6..00000000000
--- a/common/hooks/post-install/01-remove-localized-manpages.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-# This hook removes localized man(1) files
-
-hook() {
-	local section mandir=${PKGDESTDIR}/usr/share/man
-
-	for section in ${mandir}/*; do
-		if ! [ -d ${section} ]; then
-			continue
-		fi
-
-		case ${section} in
-			${mandir}/man[0-9n]|${mandir}/man[013][fp])
-				continue;;
-			${mandir}/cat[0-9n]|${mandir}/cat[013][fp])
-				continue;;
-		esac
-
-		rm -rf ${section}
-	done
-}

From cce30c1fa11733a7ab60bd2da4776d55ce9ae46c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 23 Aug 2020 20:27:44 -0300
Subject: [PATCH 2/2] New package: manpages-l10n-4.1.0.

---
 srcpkgs/manpages-de            |  1 +
 srcpkgs/manpages-fr            |  1 +
 srcpkgs/manpages-l10n/template | 52 ++++++++++++++++++++++++++++++++++
 srcpkgs/manpages-nl            |  1 +
 srcpkgs/manpages-pl            |  1 +
 srcpkgs/manpages-pt-br         |  1 +
 srcpkgs/manpages-ro            |  1 +
 7 files changed, 58 insertions(+)
 create mode 120000 srcpkgs/manpages-de
 create mode 120000 srcpkgs/manpages-fr
 create mode 100644 srcpkgs/manpages-l10n/template
 create mode 120000 srcpkgs/manpages-nl
 create mode 120000 srcpkgs/manpages-pl
 create mode 120000 srcpkgs/manpages-pt-br
 create mode 120000 srcpkgs/manpages-ro

diff --git a/srcpkgs/manpages-de b/srcpkgs/manpages-de
new file mode 120000
index 00000000000..5eb955f7668
--- /dev/null
+++ b/srcpkgs/manpages-de
@@ -0,0 +1 @@
+manpages-l10n
\ No newline at end of file
diff --git a/srcpkgs/manpages-fr b/srcpkgs/manpages-fr
new file mode 120000
index 00000000000..5eb955f7668
--- /dev/null
+++ b/srcpkgs/manpages-fr
@@ -0,0 +1 @@
+manpages-l10n
\ No newline at end of file
diff --git a/srcpkgs/manpages-l10n/template b/srcpkgs/manpages-l10n/template
new file mode 100644
index 00000000000..49d35a6a873
--- /dev/null
+++ b/srcpkgs/manpages-l10n/template
@@ -0,0 +1,52 @@
+# Template file for 'manpages-l10n'
+pkgname=manpages-l10n
+version=4.1.0
+revision=1
+wrksrc=${pkgname}-v${version}
+build_style=gnu-configure
+make_build_args="comp_extension= compressor=cat"
+hostmakedepends="po4a"
+makedepends=""
+depends=""
+short_desc="Translations of manpages"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://manpages-l10n-team.pages.debian.net/manpages-l10n/"
+distfiles="https://salsa.debian.org/manpages-l10n-team/${pkgname}/-/archive/v${version}/${pkgname}-v${version}.tar.gz"
+checksum=c85ec2f74b6cbc29c6eb30b5787c02e58b8213283222ac19b05845ee6c7d0b02
+
+manpages-pt-br_package() {
+	pkg_install() {
+		vmove usr/share/man/pt_BR
+	}
+}
+
+manpages-nl_package() {
+	pkg_install() {
+		vmove usr/share/man/nl
+	}
+}
+
+manpages-fr_package() {
+	pkg_install() {
+		vmove usr/share/man/fr
+	}
+}
+
+manpages-de_package() {
+	pkg_install() {
+		vmove usr/share/man/de
+	}
+}
+
+manpages-pl_package() {
+	pkg_install() {
+		vmove usr/share/man/pl
+	}
+}
+
+manpages-ro_package() {
+	pkg_install() {
+		vmove usr/share/man/ro
+	}
+}
diff --git a/srcpkgs/manpages-nl b/srcpkgs/manpages-nl
new file mode 120000
index 00000000000..5eb955f7668
--- /dev/null
+++ b/srcpkgs/manpages-nl
@@ -0,0 +1 @@
+manpages-l10n
\ No newline at end of file
diff --git a/srcpkgs/manpages-pl b/srcpkgs/manpages-pl
new file mode 120000
index 00000000000..5eb955f7668
--- /dev/null
+++ b/srcpkgs/manpages-pl
@@ -0,0 +1 @@
+manpages-l10n
\ No newline at end of file
diff --git a/srcpkgs/manpages-pt-br b/srcpkgs/manpages-pt-br
new file mode 120000
index 00000000000..5eb955f7668
--- /dev/null
+++ b/srcpkgs/manpages-pt-br
@@ -0,0 +1 @@
+manpages-l10n
\ No newline at end of file
diff --git a/srcpkgs/manpages-ro b/srcpkgs/manpages-ro
new file mode 120000
index 00000000000..5eb955f7668
--- /dev/null
+++ b/srcpkgs/manpages-ro
@@ -0,0 +1 @@
+manpages-l10n
\ No newline at end of file

Re: Add general localized man pages, remove hook that removes them.

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24443#issuecomment-679420894

Comment:
Generally the commits for stuff in `common` seems to be `common/hooks: XYZ` or something like `common/hooks/post-install/01-remove-localized-manpages.sh: remove`. TBH I thought there was a package `remove-localized-manpages` when I saw this...

Re: Add general localized man pages, remove hook that removes them.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24443#issuecomment-695799480

Comment:
@void-linux/pkg-committers is there a reason why localized man pages were explicitly removed from packages?

Re: Add general localized man pages, remove hook that removes them.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/24443#issuecomment-696896902

Comment:
> I need some help on the `manpages-l10n` package, since setting `build_style=meta` would force me to manually specify a lot of functions for no gain, and the license shouldn't be `vlicense`d. So `xbps-src` is complaining the package is empty :/

As `manpages-l10n` is empty and depend on nothing, maybe remove it and make one of actual packages main one.

Re: [PR PATCH] [Updated] Add general localized man pages, remove hook that removes them.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages l10n
https://github.com/void-linux/void-packages/pull/24443

Add general localized man pages, remove hook that removes them.
Why does this hook exist? `mdocml` doesn't seem to support localized pages, but `man-db` does.

I need some help on the `manpages-l10n` package, since setting `build_style=meta` would force me to manually specify a lot of functions for no gain, and the license shouldn't be `vlicense`d. So `xbps-src` is complaining the package is empty :/ 

The `short_descs` also still need to be updated.

---

`mdocml` supports this, as long as it's configured in `/etc/man.conf`.


A patch file from https://github.com/void-linux/void-packages/pull/24443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-l10n-24443.patch --]
[-- Type: text/x-diff, Size: 4985 bytes --]

From 9d966105f3bf548f8b629678c383c6ed33872e60 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 23 Aug 2020 20:27:21 -0300
Subject: [PATCH 1/2] common/hooks: remove remove-localized-manpages hook.

Allow packages to include localized man pages. Needed for manpages-l10n.
---
 .../01-remove-localized-manpages.sh           | 20 -------------------
 1 file changed, 20 deletions(-)
 delete mode 100644 common/hooks/post-install/01-remove-localized-manpages.sh

diff --git a/common/hooks/post-install/01-remove-localized-manpages.sh b/common/hooks/post-install/01-remove-localized-manpages.sh
deleted file mode 100644
index bee8d9d84e6..00000000000
--- a/common/hooks/post-install/01-remove-localized-manpages.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-# This hook removes localized man(1) files
-
-hook() {
-	local section mandir=${PKGDESTDIR}/usr/share/man
-
-	for section in ${mandir}/*; do
-		if ! [ -d ${section} ]; then
-			continue
-		fi
-
-		case ${section} in
-			${mandir}/man[0-9n]|${mandir}/man[013][fp])
-				continue;;
-			${mandir}/cat[0-9n]|${mandir}/cat[013][fp])
-				continue;;
-		esac
-
-		rm -rf ${section}
-	done
-}

From 5a5a564dfd6457264eb449f36372028006423c18 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 23 Aug 2020 20:27:44 -0300
Subject: [PATCH 2/2] New package: manpages-pt-br-4.2.0.

Plus subpackages for other languages.
---
 srcpkgs/manpages-de             |  1 +
 srcpkgs/manpages-fr             |  1 +
 srcpkgs/manpages-nl             |  1 +
 srcpkgs/manpages-pl             |  1 +
 srcpkgs/manpages-pt-br/template | 55 +++++++++++++++++++++++++++++++++
 srcpkgs/manpages-pt-br/update   |  2 ++
 srcpkgs/manpages-ro             |  1 +
 7 files changed, 62 insertions(+)
 create mode 120000 srcpkgs/manpages-de
 create mode 120000 srcpkgs/manpages-fr
 create mode 120000 srcpkgs/manpages-nl
 create mode 120000 srcpkgs/manpages-pl
 create mode 100644 srcpkgs/manpages-pt-br/template
 create mode 100644 srcpkgs/manpages-pt-br/update
 create mode 120000 srcpkgs/manpages-ro

diff --git a/srcpkgs/manpages-de b/srcpkgs/manpages-de
new file mode 120000
index 00000000000..3cf72f5bb89
--- /dev/null
+++ b/srcpkgs/manpages-de
@@ -0,0 +1 @@
+manpages-pt-br
\ No newline at end of file
diff --git a/srcpkgs/manpages-fr b/srcpkgs/manpages-fr
new file mode 120000
index 00000000000..3cf72f5bb89
--- /dev/null
+++ b/srcpkgs/manpages-fr
@@ -0,0 +1 @@
+manpages-pt-br
\ No newline at end of file
diff --git a/srcpkgs/manpages-nl b/srcpkgs/manpages-nl
new file mode 120000
index 00000000000..3cf72f5bb89
--- /dev/null
+++ b/srcpkgs/manpages-nl
@@ -0,0 +1 @@
+manpages-pt-br
\ No newline at end of file
diff --git a/srcpkgs/manpages-pl b/srcpkgs/manpages-pl
new file mode 120000
index 00000000000..3cf72f5bb89
--- /dev/null
+++ b/srcpkgs/manpages-pl
@@ -0,0 +1 @@
+manpages-pt-br
\ No newline at end of file
diff --git a/srcpkgs/manpages-pt-br/template b/srcpkgs/manpages-pt-br/template
new file mode 100644
index 00000000000..51a46f0452d
--- /dev/null
+++ b/srcpkgs/manpages-pt-br/template
@@ -0,0 +1,55 @@
+# Template file for 'manpages-pt-br'
+pkgname=manpages-pt-br
+version=4.2.0
+revision=1
+_prjname=manpages-l10n
+wrksrc=${_prjname}-v${version}
+build_style=gnu-configure
+make_build_args="comp_extension= compressor=cat"
+hostmakedepends="po4a"
+_desc="Translations of manpages"
+short_desc="${_desc} - Brazilian Portuguese (Português Brasileiro)"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://manpages-l10n-team.pages.debian.net/manpages-l10n/"
+distfiles="https://salsa.debian.org/manpages-l10n-team/${_prjname}/-/archive/v${version}/${_prjname}-v${version}.tar.gz"
+checksum=efb0cdf72510ca74d6f6172c44059d7726116d2e3839e70f494a2e8e3728f6fb
+
+post_install() {
+	find $DESTDIR -name '*systemd*' -delete
+}
+
+manpages-nl_package() {
+	short_desc="${_desc} - Dutch (Nederlands)"
+	pkg_install() {
+		vmove usr/share/man/nl
+	}
+}
+
+manpages-fr_package() {
+	short_desc="${_desc} - French (Français)"
+	pkg_install() {
+		vmove usr/share/man/fr
+	}
+}
+
+manpages-de_package() {
+	short_desc="${_desc} - German (Deutsch)"
+	pkg_install() {
+		vmove usr/share/man/de
+	}
+}
+
+manpages-pl_package() {
+	short_desc="${_desc} - Polish (Polski)"
+	pkg_install() {
+		vmove usr/share/man/pl
+	}
+}
+
+manpages-ro_package() {
+	short_desc="${_desc} - Romanian (Limba Română)"
+	pkg_install() {
+		vmove usr/share/man/ro
+	}
+}
diff --git a/srcpkgs/manpages-pt-br/update b/srcpkgs/manpages-pt-br/update
new file mode 100644
index 00000000000..43c7e78b44e
--- /dev/null
+++ b/srcpkgs/manpages-pt-br/update
@@ -0,0 +1,2 @@
+pkgname=manpages-l10n
+site="https://salsa.debian.org/manpages-l10n-team/manpages-l10n/-/tags"
diff --git a/srcpkgs/manpages-ro b/srcpkgs/manpages-ro
new file mode 120000
index 00000000000..3cf72f5bb89
--- /dev/null
+++ b/srcpkgs/manpages-ro
@@ -0,0 +1 @@
+manpages-pt-br
\ No newline at end of file

Re: Add general localized man pages, remove hook that removes them.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24443#issuecomment-714934085

Comment:
Fixed the commit message and the empty package situation. Should be good now.

Re: Add general localized man pages, remove hook that removes them.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24443#issuecomment-714934321

Comment:
This will require an entry in docs about enabling man pages in other languages as well.

Re: [PR PATCH] [Merged]: Add general localized man pages, remove hook that removes them.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

There's a merged pull request on the void-packages repository

Add general localized man pages, remove hook that removes them.
https://github.com/void-linux/void-packages/pull/24443

Description:
Why does this hook exist? `mdocml` doesn't seem to support localized pages, but `man-db` does.

I need some help on the `manpages-l10n` package, since setting `build_style=meta` would force me to manually specify a lot of functions for no gain, and the license shouldn't be `vlicense`d. So `xbps-src` is complaining the package is empty :/ 

The `short_descs` also still need to be updated.

---

`mdocml` supports this, as long as it's configured in `/etc/man.conf`.