Github messages for voidlinux
 help / color / mirror / Atom feed
From: CameronNemo <CameronNemo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] dhcpcd: make privsep a build option
Date: Sat, 12 Sep 2020 20:40:00 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24867@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages dhcpcd-privsep-option
https://github.com/void-linux/void-packages/pull/24867

dhcpcd: make privsep a build option
Still forks away from the supervisor :/
But there is no huge process tree, just a launcher and master.

A patch file from https://github.com/void-linux/void-packages/pull/24867.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcpcd-privsep-option-24867.patch --]
[-- Type: text/x-diff, Size: 1467 bytes --]

From 93517a69ff0b5eae472086fd8718a326a0082e68 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 12 Sep 2020 11:38:57 -0700
Subject: [PATCH] dhcpcd: make privsep a build option

---
 srcpkgs/dhcpcd/template | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/dhcpcd/template b/srcpkgs/dhcpcd/template
index 89da9d503bf..4bedf20ab84 100644
--- a/srcpkgs/dhcpcd/template
+++ b/srcpkgs/dhcpcd/template
@@ -1,10 +1,10 @@
 # Template file for 'dhcpcd'
 pkgname=dhcpcd
 version=9.2.0
-revision=1
+revision=2
 build_style=configure
 make_check_target=test
-configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd --privsepuser=_dhcpcd"
+configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd"
 hostmakedepends="ntp pkg-config"
 makedepends="eudev-libudev-devel"
 short_desc="RFC2131 compliant DHCP client"
@@ -15,9 +15,15 @@ distfiles="https://roy.marples.name/downloads/dhcpcd/dhcpcd-${version}.tar.xz"
 checksum=fcb2d19672d445bbfd38678fdee4f556ef967a3ea6bd81092d10545df2cb9666
 lib32disabled=yes
 conf_files=/etc/dhcpcd.conf
-# privsep
-system_accounts="_dhcpcd"
-_dhcpcd_homedir="/var/db/dhcpcd"
+
+build_options="privsep"
+build_options_default="privsep"
+
+if [ "$build_option_privsep" ]; then
+	configure_args+=" --privsepuser=_dhcpcd"
+	system_accounts="_dhcpcd"
+	_dhcpcd_homedir="/var/db/dhcpcd"
+fi
 
 post_install() {
 	vsv dhcpcd

             reply	other threads:[~2020-09-12 18:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12 18:40 CameronNemo [this message]
2020-09-13  0:54 ` [PR REVIEW] " sgn
2020-09-13 10:48 ` sgn
2020-09-15 16:11 ` [PR PATCH] [Updated] " CameronNemo
2020-09-15 18:46 ` [PR REVIEW] " Piraty
2020-09-21  0:34 ` CameronNemo
2020-09-21  0:35 ` [PR PATCH] [Updated] " CameronNemo
2020-09-21  0:35 ` [PR REVIEW] " CameronNemo
2020-09-23  9:54 ` the-maldridge
2020-10-15 14:43 ` [PR PATCH] [Closed]: " CameronNemo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24867@inbox.vuxu.org \
    --to=cameronnemo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).