Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] Change do_check for python modules
@ 2020-09-23 13:15 ericonr
  2020-09-23 15:06 ` sgn
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: ericonr @ 2020-09-23 13:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

New issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/25052

Description:
Running `python3 setup.py test` outputs the following message:

```
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
```

Should we add `tox` to everything instead, or should packagers specify the tools themselves for all templates? In any case, it might make sense to fully remove `test` as a target in `setup.py`.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Change do_check for python modules
  2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
@ 2020-09-23 15:06 ` sgn
  2020-09-23 15:06 ` sgn
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2020-09-23 15:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/25052#issuecomment-697507562

Comment:
No `tox` please, `tox` will check with external dependencies, as far as I understand.
(I added tox in the past, and I keep regret)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Change do_check for python modules
  2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
  2020-09-23 15:06 ` sgn
@ 2020-09-23 15:06 ` sgn
  2020-09-23 15:10 ` ericonr
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2020-09-23 15:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/25052#issuecomment-697507562

Comment:
No `tox` please, `tox` will check with external dependencies, as far as I understand.
(I added tox in the past, and I keep regret)

---
We may need to look into `pytest`

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Change do_check for python modules
  2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
  2020-09-23 15:06 ` sgn
  2020-09-23 15:06 ` sgn
@ 2020-09-23 15:10 ` ericonr
  2020-09-24 18:41 ` Chocimier
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-09-23 15:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/25052#issuecomment-697514697

Comment:
I am using `pytest` in #25050 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Change do_check for python modules
  2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
                   ` (2 preceding siblings ...)
  2020-09-23 15:10 ` ericonr
@ 2020-09-24 18:41 ` Chocimier
  2020-09-24 18:55 ` ericonr
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Chocimier @ 2020-09-24 18:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/issues/25052#issuecomment-698519155

Comment:
setup.py test is popular, behaves well like use system deps and has little dependencies, so more packages can be tested on first build when updated. Please don't remove until it works.

Requiring to specify do_check in all templates would be tedious.

pytest is good candidate for replacement, we could start with calling it in build style if installed (with checkdepends), otherwise do as before.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Change do_check for python modules
  2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
                   ` (3 preceding siblings ...)
  2020-09-24 18:41 ` Chocimier
@ 2020-09-24 18:55 ` ericonr
  2020-12-03  3:46 ` ahesford
  2020-12-09 20:55 ` [ISSUE] [CLOSED] " ahesford
  6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2020-09-24 18:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/25052#issuecomment-698526452

Comment:
> https://github.com/pypa/setuptools/issues/1684

Perhaps even `setup.py install` will be dropped, from what I understood of that issue. I think using pytest if it's available is a good solution.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Change do_check for python modules
  2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
                   ` (4 preceding siblings ...)
  2020-09-24 18:55 ` ericonr
@ 2020-12-03  3:46 ` ahesford
  2020-12-09 20:55 ` [ISSUE] [CLOSED] " ahesford
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-12-03  3:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/25052#issuecomment-737647020

Comment:
See #26901 for a proposed solution.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [ISSUE] [CLOSED] Change do_check for python modules
  2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
                   ` (5 preceding siblings ...)
  2020-12-03  3:46 ` ahesford
@ 2020-12-09 20:55 ` ahesford
  6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-12-09 20:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Closed issue by ericonr on void-packages repository

https://github.com/void-linux/void-packages/issues/25052

Description:
Running `python3 setup.py test` outputs the following message:

```
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
```

Should we add `tox` to everything instead, or should packagers specify the tools themselves for all templates? In any case, it might make sense to fully remove `setup.py test` as something that `do_check` does.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-12-09 20:55 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 13:15 [ISSUE] Change do_check for python modules ericonr
2020-09-23 15:06 ` sgn
2020-09-23 15:06 ` sgn
2020-09-23 15:10 ` ericonr
2020-09-24 18:41 ` Chocimier
2020-09-24 18:55 ` ericonr
2020-12-03  3:46 ` ahesford
2020-12-09 20:55 ` [ISSUE] [CLOSED] " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).