Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] straw-viewer: add missing dependency
@ 2020-09-23 19:02 PaperMountainStudio
  2020-09-23 19:25 ` ericonr
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: PaperMountainStudio @ 2020-09-23 19:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

There is a new pull request by PaperMountainStudio against master on the void-packages repository

https://github.com/PaperMountainStudio/void-packages 0001-straw-viewer-add-missing-dependency.patch
https://github.com/void-linux/void-packages/pull/25056

straw-viewer: add missing dependency
perl-Term-ReadLine-Gnu is needed for interactive input

A patch file from https://github.com/void-linux/void-packages/pull/25056.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-0001-straw-viewer-add-missing-dependency.patch-25056.patch --]
[-- Type: text/x-diff, Size: 993 bytes --]

From 66c7a7869bb91783a7cde7457043e0b5eabdd184 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Wed, 23 Sep 2020 20:59:33 +0200
Subject: [PATCH] straw-viewer: add missing dependency

---
 srcpkgs/straw-viewer/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/straw-viewer/template b/srcpkgs/straw-viewer/template
index 4187150345c..58c7c67f905 100644
--- a/srcpkgs/straw-viewer/template
+++ b/srcpkgs/straw-viewer/template
@@ -1,12 +1,12 @@
 # Template file for 'straw-viewer'
 pkgname=straw-viewer
 version=0.0.9
-revision=1
+revision=2
 build_style=perl-ModuleBuild
 configure_args="--gtk"
 hostmakedepends="perl-Module-Build"
 makedepends="perl"
-depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https"
+depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https perl-Term-ReadLine-Gnu"
 short_desc="Search and stream from YouTube using the API of invidio.us"
 maintainer="Roberto Ricci <ricci@disroot.org>"
 license="Artistic-2.0"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
@ 2020-09-23 19:25 ` ericonr
  2020-09-23 19:39 ` PaperMountainStudio
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2020-09-23 19:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25056#issuecomment-697924081

Comment:
I couldn't reproduce it. Is launching `straw-viewer` enough?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
  2020-09-23 19:25 ` ericonr
@ 2020-09-23 19:39 ` PaperMountainStudio
  2020-09-24  6:32 ` PaperMountainStudio
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: PaperMountainStudio @ 2020-09-23 19:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 266 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/25056#issuecomment-697930925

Comment:
Yes, I just typed `straw-viewer`. It should ask for user input, but it crashed, because this package was missing.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
  2020-09-23 19:25 ` ericonr
  2020-09-23 19:39 ` PaperMountainStudio
@ 2020-09-24  6:32 ` PaperMountainStudio
  2020-09-29  8:36 ` PaperMountainStudio
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: PaperMountainStudio @ 2020-09-24  6:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/25056#issuecomment-698143735

Comment:
This works when I delete my config file, but when I put `history => 1,` in it, this error happens:
```
Can't locate object method "history_list" via package "Term::ReadLine::Stub" at /bin/straw-viewer line 583.
```
This PR fixes it.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
                   ` (2 preceding siblings ...)
  2020-09-24  6:32 ` PaperMountainStudio
@ 2020-09-29  8:36 ` PaperMountainStudio
  2020-09-29 12:07 ` ericonr
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: PaperMountainStudio @ 2020-09-29  8:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/25056#issuecomment-700541479

Comment:
@ericonr can you reproduce it now? I think it's good to go.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
                   ` (3 preceding siblings ...)
  2020-09-29  8:36 ` PaperMountainStudio
@ 2020-09-29 12:07 ` ericonr
  2020-09-29 13:04 ` [PR PATCH] [Updated] " PaperMountainStudio
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2020-09-29 12:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25056#issuecomment-700659083

Comment:
Could reproduce. Would you mind adding this depedency for `youtube-viewer` as well?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
                   ` (4 preceding siblings ...)
  2020-09-29 12:07 ` ericonr
@ 2020-09-29 13:04 ` PaperMountainStudio
  2020-09-29 13:14 ` PaperMountainStudio
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: PaperMountainStudio @ 2020-09-29 13:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

There is an updated pull request by PaperMountainStudio against master on the void-packages repository

https://github.com/PaperMountainStudio/void-packages 0001-straw-viewer-add-missing-dependency.patch
https://github.com/void-linux/void-packages/pull/25056

straw-viewer: add missing dependency
perl-Term-ReadLine-Gnu is needed for interactive input

A patch file from https://github.com/void-linux/void-packages/pull/25056.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-0001-straw-viewer-add-missing-dependency.patch-25056.patch --]
[-- Type: text/x-diff, Size: 2019 bytes --]

From 66c7a7869bb91783a7cde7457043e0b5eabdd184 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Wed, 23 Sep 2020 20:59:33 +0200
Subject: [PATCH 1/2] straw-viewer: add missing dependency

---
 srcpkgs/straw-viewer/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/straw-viewer/template b/srcpkgs/straw-viewer/template
index 4187150345c..58c7c67f905 100644
--- a/srcpkgs/straw-viewer/template
+++ b/srcpkgs/straw-viewer/template
@@ -1,12 +1,12 @@
 # Template file for 'straw-viewer'
 pkgname=straw-viewer
 version=0.0.9
-revision=1
+revision=2
 build_style=perl-ModuleBuild
 configure_args="--gtk"
 hostmakedepends="perl-Module-Build"
 makedepends="perl"
-depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https"
+depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https perl-Term-ReadLine-Gnu"
 short_desc="Search and stream from YouTube using the API of invidio.us"
 maintainer="Roberto Ricci <ricci@disroot.org>"
 license="Artistic-2.0"

From 84bd7176d6777ead34f6aadbabde12685cccbc51 Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Tue, 29 Sep 2020 15:03:28 +0200
Subject: [PATCH 2/2] youtube-viewer: add missing dependency

---
 srcpkgs/youtube-viewer/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/youtube-viewer/template b/srcpkgs/youtube-viewer/template
index 0b4751b722b..9d3c3eb85a4 100644
--- a/srcpkgs/youtube-viewer/template
+++ b/srcpkgs/youtube-viewer/template
@@ -1,13 +1,12 @@
 # Template file for 'youtube-viewer'
 pkgname=youtube-viewer
 version=3.7.9
-revision=1
-archs=noarch
+revision=2
 build_style=perl-ModuleBuild
 configure_args="--gtk"
 hostmakedepends="perl-Module-Build"
 makedepends="perl"
-depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https"
+depends="perl-Data-Dump perl-JSON perl-LWP-Protocol-https perl-Term-ReadLine-Gnu"
 short_desc="Command-line client to search and stream from YouTube"
 maintainer="Duncaen <duncaen@voidlinux.org>"
 license="Artistic-2.0"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
                   ` (5 preceding siblings ...)
  2020-09-29 13:04 ` [PR PATCH] [Updated] " PaperMountainStudio
@ 2020-09-29 13:14 ` PaperMountainStudio
  2020-10-07 21:17 ` ericonr
  2020-10-07 21:17 ` [PR PATCH] [Merged]: " ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: PaperMountainStudio @ 2020-09-29 13:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/25056#issuecomment-700694080

Comment:
done

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
                   ` (6 preceding siblings ...)
  2020-09-29 13:14 ` PaperMountainStudio
@ 2020-10-07 21:17 ` ericonr
  2020-10-07 21:17 ` [PR PATCH] [Merged]: " ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2020-10-07 21:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25056#issuecomment-705198569

Comment:
Sorry for the delay, merging!

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: straw-viewer: add missing dependency
  2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
                   ` (7 preceding siblings ...)
  2020-10-07 21:17 ` ericonr
@ 2020-10-07 21:17 ` ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2020-10-07 21:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

There's a merged pull request on the void-packages repository

straw-viewer: add missing dependency
https://github.com/void-linux/void-packages/pull/25056

Description:
perl-Term-ReadLine-Gnu is needed for interactive input

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-10-07 21:17 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 19:02 [PR PATCH] straw-viewer: add missing dependency PaperMountainStudio
2020-09-23 19:25 ` ericonr
2020-09-23 19:39 ` PaperMountainStudio
2020-09-24  6:32 ` PaperMountainStudio
2020-09-29  8:36 ` PaperMountainStudio
2020-09-29 12:07 ` ericonr
2020-09-29 13:04 ` [PR PATCH] [Updated] " PaperMountainStudio
2020-09-29 13:14 ` PaperMountainStudio
2020-10-07 21:17 ` ericonr
2020-10-07 21:17 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).