* [PR PATCH] vscode: switch to electron10. [ci skip]
@ 2020-10-08 8:00 shizonic
2020-10-08 17:34 ` q66
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: shizonic @ 2020-10-08 8:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
There is a new pull request by shizonic against master on the void-packages repository
https://github.com/shizonic/void-packages vscode
https://github.com/void-linux/void-packages/pull/25437
vscode: switch to electron10. [ci skip]
A patch file from https://github.com/void-linux/void-packages/pull/25437.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-25437.patch --]
[-- Type: text/x-diff, Size: 1039 bytes --]
From 7ba41043d23162748f9fe175ea55e683d33364b4 Mon Sep 17 00:00:00 2001
From: Toby Merz <realtiaz@gmail.com>
Date: Thu, 8 Oct 2020 09:56:42 +0200
Subject: [PATCH] vscode: switch to electron10. [ci skip]
---
srcpkgs/vscode/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index 4037f6db359..02a4f21a19c 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,11 +1,11 @@
# Template file for 'vscode'
pkgname=vscode
version=1.49.3
-revision=1
-_electronver=9.3.1
+revision=2
+_electronver=10.1.3
hostmakedepends="pkg-config python nodejs-lts-10 yarn tar git"
-makedepends="libxkbfile-devel libsecret-devel electron9"
-depends="libXtst libxkbfile nss dejavu-fonts-ttf xdg-utils ripgrep electron9"
+makedepends="libxkbfile-devel libsecret-devel electron10"
+depends="libXtst libxkbfile nss dejavu-fonts-ttf xdg-utils ripgrep electron10"
short_desc="Microsoft Code for Linux"
maintainer="shizonic <realtiaz@gmail.com>"
license="MIT"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vscode: switch to electron10. [ci skip]
2020-10-08 8:00 [PR PATCH] vscode: switch to electron10. [ci skip] shizonic
@ 2020-10-08 17:34 ` q66
2020-10-08 17:39 ` Johnnynator
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: q66 @ 2020-10-08 17:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/25437#issuecomment-705719082
Comment:
has upstream switched to it? we should be using the same version they use
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vscode: switch to electron10. [ci skip]
2020-10-08 8:00 [PR PATCH] vscode: switch to electron10. [ci skip] shizonic
2020-10-08 17:34 ` q66
@ 2020-10-08 17:39 ` Johnnynator
2020-10-08 17:45 ` shizonic
2020-10-08 17:45 ` [PR PATCH] [Closed]: " shizonic
3 siblings, 0 replies; 5+ messages in thread
From: Johnnynator @ 2020-10-08 17:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/25437#issuecomment-705721519
Comment:
Upstream is using 9.x. So I don't see any urgent reason to upgrade our template to 10x.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vscode: switch to electron10. [ci skip]
2020-10-08 8:00 [PR PATCH] vscode: switch to electron10. [ci skip] shizonic
2020-10-08 17:34 ` q66
2020-10-08 17:39 ` Johnnynator
@ 2020-10-08 17:45 ` shizonic
2020-10-08 17:45 ` [PR PATCH] [Closed]: " shizonic
3 siblings, 0 replies; 5+ messages in thread
From: shizonic @ 2020-10-08 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New comment by shizonic on void-packages repository
https://github.com/void-linux/void-packages/pull/25437#issuecomment-705724745
Comment:
Ok. I see. Closed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: vscode: switch to electron10. [ci skip]
2020-10-08 8:00 [PR PATCH] vscode: switch to electron10. [ci skip] shizonic
` (2 preceding siblings ...)
2020-10-08 17:45 ` shizonic
@ 2020-10-08 17:45 ` shizonic
3 siblings, 0 replies; 5+ messages in thread
From: shizonic @ 2020-10-08 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
There's a closed pull request on the void-packages repository
vscode: switch to electron10. [ci skip]
https://github.com/void-linux/void-packages/pull/25437
Description:
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-08 17:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 8:00 [PR PATCH] vscode: switch to electron10. [ci skip] shizonic
2020-10-08 17:34 ` q66
2020-10-08 17:39 ` Johnnynator
2020-10-08 17:45 ` shizonic
2020-10-08 17:45 ` [PR PATCH] [Closed]: " shizonic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).