Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] vdrift: remove unused dependency; minor fixes
@ 2020-10-19  6:10 ev-ermakov
  2020-10-19 14:53 ` sgn
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: ev-ermakov @ 2020-10-19  6:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

There is a new pull request by ev-ermakov against master on the void-packages repository

https://github.com/ev-ermakov/void-packages pkg/vdrift
https://github.com/void-linux/void-packages/pull/25727

vdrift: remove unused dependency; minor fixes
vdrift does not require `asio`. I have no idea why this dependency was included.

A patch file from https://github.com/void-linux/void-packages/pull/25727.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/vdrift-25727.patch --]
[-- Type: text/x-diff, Size: 1390 bytes --]

From 222dbf64365f490c23c402b1f5acee6c4cb57e3f Mon Sep 17 00:00:00 2001
From: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
Date: Mon, 19 Oct 2020 16:58:11 +1100
Subject: [PATCH] vdrift: remove unused dependency; minor fixes

---
 srcpkgs/vdrift/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/vdrift/template b/srcpkgs/vdrift/template
index 290288696f6..5674f951a88 100644
--- a/srcpkgs/vdrift/template
+++ b/srcpkgs/vdrift/template
@@ -1,15 +1,15 @@
 # Template file for 'vdrift'
 pkgname=vdrift
 version=2014.10.20
-revision=9
+revision=10
 wrksrc="$pkgname"
 build_style=scons
 make_build_args="release=1 force_feedback=1 extbullet=1 datadir=share/${pkgname}"
 make_install_args="$make_build_args"
 hostmakedepends="gettext pkg-config"
-makedepends="asio libcurl-devel bullet-devel SDL2_image-devel glew-devel
+makedepends="libcurl-devel bullet-devel SDL2_image-devel glew-devel
  libvorbis-devel libarchive-devel MesaLib-devel"
-depends="vdrift-data-${version}_${revision}"
+depends="desktop-file-utils vdrift-data-${version}_${revision}"
 short_desc="Open source driving simulation made with drift racing in mind"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later"
@@ -35,7 +35,6 @@ post_install() {
 
 vdrift-data_package() {
 	short_desc+=" - data files"
-	archs=noarch
 	pkg_install() {
 		vmove usr/share/vdrift
 	}

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: vdrift: remove unused dependency; minor fixes
  2020-10-19  6:10 [PR PATCH] vdrift: remove unused dependency; minor fixes ev-ermakov
@ 2020-10-19 14:53 ` sgn
  2020-10-21 18:47 ` ev-ermakov
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-10-19 14:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25727#issuecomment-712221657

Comment:
Will be meld into #24448

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: vdrift: remove unused dependency; minor fixes
  2020-10-19  6:10 [PR PATCH] vdrift: remove unused dependency; minor fixes ev-ermakov
  2020-10-19 14:53 ` sgn
@ 2020-10-21 18:47 ` ev-ermakov
  2020-10-25  0:34 ` sgn
  2020-10-25  4:47 ` [PR PATCH] [Closed]: " sgn
  3 siblings, 0 replies; 5+ messages in thread
From: ev-ermakov @ 2020-10-21 18:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by ev-ermakov on void-packages repository

https://github.com/void-linux/void-packages/pull/25727#issuecomment-713798788

Comment:
@sgn, ok. So, should I close this pull request?


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: vdrift: remove unused dependency; minor fixes
  2020-10-19  6:10 [PR PATCH] vdrift: remove unused dependency; minor fixes ev-ermakov
  2020-10-19 14:53 ` sgn
  2020-10-21 18:47 ` ev-ermakov
@ 2020-10-25  0:34 ` sgn
  2020-10-25  4:47 ` [PR PATCH] [Closed]: " sgn
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-10-25  0:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25727#issuecomment-716074207

Comment:
> @sgn, ok. So, should I close this pull request?

Either is fine, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: vdrift: remove unused dependency; minor fixes
  2020-10-19  6:10 [PR PATCH] vdrift: remove unused dependency; minor fixes ev-ermakov
                   ` (2 preceding siblings ...)
  2020-10-25  0:34 ` sgn
@ 2020-10-25  4:47 ` sgn
  3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-10-25  4:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

There's a closed pull request on the void-packages repository

vdrift: remove unused dependency; minor fixes
https://github.com/void-linux/void-packages/pull/25727

Description:
vdrift does not require `asio`. I have no idea why this dependency was included.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-25  4:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19  6:10 [PR PATCH] vdrift: remove unused dependency; minor fixes ev-ermakov
2020-10-19 14:53 ` sgn
2020-10-21 18:47 ` ev-ermakov
2020-10-25  0:34 ` sgn
2020-10-25  4:47 ` [PR PATCH] [Closed]: " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).