* [PR PATCH] ampache: update to 4.2.3
@ 2020-10-27 13:30 aurieh
2020-10-27 13:59 ` [PR REVIEW] " ericonr
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: aurieh @ 2020-10-27 13:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
There is a new pull request by aurieh against master on the void-packages repository
https://github.com/aurieh/void-packages update-ampache
https://github.com/void-linux/void-packages/pull/25915
ampache: update to 4.2.3
Was tragically outdated with several CVEs to its name. This package is likely abandoned.
A patch file from https://github.com/void-linux/void-packages/pull/25915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ampache-25915.patch --]
[-- Type: text/x-diff, Size: 994 bytes --]
From 6ef611263f72517163a14907b921e8cabbc4f232 Mon Sep 17 00:00:00 2001
From: Auri <me@aurieh.me>
Date: Tue, 27 Oct 2020 15:28:38 +0200
Subject: [PATCH] ampache: update to 4.2.3
---
srcpkgs/ampache/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/ampache/template b/srcpkgs/ampache/template
index 3639557449a..09ddf955f92 100644
--- a/srcpkgs/ampache/template
+++ b/srcpkgs/ampache/template
@@ -1,6 +1,6 @@
# Template file for 'ampache'
pkgname=ampache
-version=3.9.0
+version=4.2.3
revision=1
archs=noarch
create_wrksrc=yes
@@ -11,7 +11,7 @@ maintainer="Steve Prybylski <sa.prybylx@gmail.com>"
license="AGPL-3.0-or-later"
homepage="http://ampache.org"
distfiles="https://github.com/ampache/ampache/releases/download/${version}/${pkgname}-${version}_all.zip"
-checksum=2c232e080eb9ea6c77cea7b078b89e94079f5629cfe7b1de578de92c1240b892
+checksum=26e5984d5582c0bd1789626c7b07ce86ada86d64e0e5549baac625236a36e5ad
python_version=2
do_install() {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
@ 2020-10-27 13:59 ` ericonr
2020-10-27 13:59 ` ericonr
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-10-27 13:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#discussion_r512714469
Comment:
Remove noarch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
2020-10-27 13:59 ` [PR REVIEW] " ericonr
@ 2020-10-27 13:59 ` ericonr
2020-10-27 15:11 ` aurieh
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-10-27 13:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#discussion_r512714921
Comment:
Is it still on python 2? :/
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
2020-10-27 13:59 ` [PR REVIEW] " ericonr
2020-10-27 13:59 ` ericonr
@ 2020-10-27 15:11 ` aurieh
2020-10-27 15:22 ` aurieh
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aurieh @ 2020-10-27 15:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by aurieh on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#discussion_r512776937
Comment:
Honestly not sure why that's specified even, I can't find any python scripts in the ampache source tree.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
` (2 preceding siblings ...)
2020-10-27 15:11 ` aurieh
@ 2020-10-27 15:22 ` aurieh
2020-10-27 15:24 ` ericonr
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aurieh @ 2020-10-27 15:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by aurieh on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#discussion_r512786269
Comment:
It's clear now: a few dependencies pulled in by ampache rely on python scripts (`php-openid` specifically), and they're almost exclusively Python 2.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
` (3 preceding siblings ...)
2020-10-27 15:22 ` aurieh
@ 2020-10-27 15:24 ` ericonr
2020-10-27 15:55 ` aurieh
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-10-27 15:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#discussion_r512787473
Comment:
I don't think it should require the line, but I don't fully understand how this part works. If you want, you can try building without the line.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
` (4 preceding siblings ...)
2020-10-27 15:24 ` ericonr
@ 2020-10-27 15:55 ` aurieh
2020-10-27 15:56 ` [PR PATCH] [Updated] " aurieh
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aurieh @ 2020-10-27 15:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
New review comment by aurieh on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#discussion_r512786269
Comment:
It's clear now: a few dependencies pulled in by ampache rely on python scripts (`php-openid`, `sabre/dav` and `naturalselection` specifically), and they're almost exclusively Python 2.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
` (5 preceding siblings ...)
2020-10-27 15:55 ` aurieh
@ 2020-10-27 15:56 ` aurieh
2020-10-27 15:57 ` [PR REVIEW] " aurieh
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aurieh @ 2020-10-27 15:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
There is an updated pull request by aurieh against master on the void-packages repository
https://github.com/aurieh/void-packages update-ampache
https://github.com/void-linux/void-packages/pull/25915
ampache: update to 4.2.3
Was tragically outdated with several CVEs to its name. This package is likely abandoned - I wouldn't mind taking ownership of it as I use the software myself.
A patch file from https://github.com/void-linux/void-packages/pull/25915.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ampache-25915.patch --]
[-- Type: text/x-diff, Size: 1041 bytes --]
From e7fa7e795cfa26e4e9ca4ba0127e72ea955dc1c9 Mon Sep 17 00:00:00 2001
From: Auri <me@aurieh.me>
Date: Tue, 27 Oct 2020 15:28:38 +0200
Subject: [PATCH] ampache: update to 4.2.3
---
srcpkgs/ampache/template | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/ampache/template b/srcpkgs/ampache/template
index 3639557449a..f7f50a256aa 100644
--- a/srcpkgs/ampache/template
+++ b/srcpkgs/ampache/template
@@ -1,8 +1,7 @@
# Template file for 'ampache'
pkgname=ampache
-version=3.9.0
+version=4.2.3
revision=1
-archs=noarch
create_wrksrc=yes
hostmakedepends="unzip"
depends="php mysql"
@@ -11,7 +10,7 @@ maintainer="Steve Prybylski <sa.prybylx@gmail.com>"
license="AGPL-3.0-or-later"
homepage="http://ampache.org"
distfiles="https://github.com/ampache/ampache/releases/download/${version}/${pkgname}-${version}_all.zip"
-checksum=2c232e080eb9ea6c77cea7b078b89e94079f5629cfe7b1de578de92c1240b892
+checksum=26e5984d5582c0bd1789626c7b07ce86ada86d64e0e5549baac625236a36e5ad
python_version=2
do_install() {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
` (6 preceding siblings ...)
2020-10-27 15:56 ` [PR PATCH] [Updated] " aurieh
@ 2020-10-27 15:57 ` aurieh
2020-10-27 16:56 ` ericonr
2020-10-30 1:22 ` [PR PATCH] [Merged]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: aurieh @ 2020-10-27 15:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New review comment by aurieh on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#discussion_r512817496
Comment:
It doesn't build without it (`find` broken pipe error, something `python_version` being unset), so it seems that it is necessary.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
` (7 preceding siblings ...)
2020-10-27 15:57 ` [PR REVIEW] " aurieh
@ 2020-10-27 16:56 ` ericonr
2020-10-30 1:22 ` [PR PATCH] [Merged]: " ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-10-27 16:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25915#issuecomment-717382737
Comment:
@stpx would you like to give the package up for adoption?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Merged]: ampache: update to 4.2.3
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
` (8 preceding siblings ...)
2020-10-27 16:56 ` ericonr
@ 2020-10-30 1:22 ` ericonr
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-10-30 1:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
There's a merged pull request on the void-packages repository
ampache: update to 4.2.3
https://github.com/void-linux/void-packages/pull/25915
Description:
Was tragically outdated with several CVEs to its name. This package is likely abandoned - I wouldn't mind taking ownership of it as I use the software myself.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-10-30 1:22 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 13:30 [PR PATCH] ampache: update to 4.2.3 aurieh
2020-10-27 13:59 ` [PR REVIEW] " ericonr
2020-10-27 13:59 ` ericonr
2020-10-27 15:11 ` aurieh
2020-10-27 15:22 ` aurieh
2020-10-27 15:24 ` ericonr
2020-10-27 15:55 ` aurieh
2020-10-27 15:56 ` [PR PATCH] [Updated] " aurieh
2020-10-27 15:57 ` [PR REVIEW] " aurieh
2020-10-27 16:56 ` ericonr
2020-10-30 1:22 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).