* [PR PATCH] sof-firmware: update to 1.6
@ 2020-10-31 17:05 cinerea0
2020-11-02 2:45 ` cinerea0
` (41 more replies)
0 siblings, 42 replies; 43+ messages in thread
From: cinerea0 @ 2020-10-31 17:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
There is a new pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages sof
https://github.com/void-linux/void-packages/pull/26003
sof-firmware: update to 1.6
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
A patch file from https://github.com/void-linux/void-packages/pull/26003.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-26003.patch --]
[-- Type: text/x-diff, Size: 2370 bytes --]
From 144175da52794e2264da7cb7ecc542d8ef8cc9bd Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Sat, 31 Oct 2020 12:55:56 -0400
Subject: [PATCH] sof-firmware: update to 1.6
---
srcpkgs/sof-firmware/template | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 00dfd262191..e6e44910f6e 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,15 +1,16 @@
# Template file for 'sof-firmware'
pkgname=sof-firmware
-version=1.5.1
+version=1.6
revision=1
+_githash=47b436af36c18c3b4f409e1d9452aea18e17abc8
archs="i686* x86_64*"
-wrksrc=sof-bin-stable-v${version}
+wrksrc=sof-bin-${_githash}
short_desc="Sound Open Firmware and topology binaries"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="BSD-3-Clause"
homepage="https://thesofproject.github.io/latest/index.html"
-distfiles="https://github.com/thesofproject/sof-bin/archive/stable-v${version}.tar.gz"
-checksum=270125fb621b9919de4190f53a86de5dc1163dcf839c349f4b22724a5a9c1fb1
+distfiles="https://github.com/thesofproject/sof-bin/archive/${_githash}.tar.gz"
+checksum=3eb522b25f63a9cff67a4f123ed810d95809471b22c3930912eb70394d53b274
do_install() {
local intel_path="lib/firmware/intel"
@@ -22,12 +23,15 @@ do_install() {
for f in ${intel_path}/sof/v${version}/public-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/public-signed
done
- for arc in {bdw,byt,cht,apl,cnl,icl}; do
+ for arc in {bdw,byt,cht}; do
ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
done
- ln -s sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
+ for arc in {apl,cnl,icl}; do
+ ln -s intel-signed/sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ done
+ ln -s intel-signed/sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
+ ln -s intel-signed/sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
+ ln -s intel-signed/sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
for f in ${intel_path}/sof-tplg-v${version}/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof-tplg
done
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
@ 2020-11-02 2:45 ` cinerea0
2020-11-02 5:21 ` Johnnynator
` (40 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-11-02 2:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-720206691
Comment:
@ericonr Unfortunately, I don't think GitHub will automatically close other PRs, just linked issues. Good news though, the CI for this finally went through!
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
2020-11-02 2:45 ` cinerea0
@ 2020-11-02 5:21 ` Johnnynator
2020-11-06 0:33 ` [PR PATCH] [Updated] " cinerea0
` (39 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: Johnnynator @ 2020-11-02 5:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-720242336
Comment:
They will get autoclosed if you add the Closes #Num to the commit message instead.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR PATCH] [Updated] sof-firmware: update to 1.6
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
2020-11-02 2:45 ` cinerea0
2020-11-02 5:21 ` Johnnynator
@ 2020-11-06 0:33 ` cinerea0
2020-11-06 15:15 ` cinerea0
` (38 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-11-06 0:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages sof
https://github.com/void-linux/void-packages/pull/26003
sof-firmware: update to 1.6
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
Closes #24776
Closes #24271
A patch file from https://github.com/void-linux/void-packages/pull/26003.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-26003.patch --]
[-- Type: text/x-diff, Size: 2400 bytes --]
From 62254e18159fbb3add147186fb62c15b84c93519 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Sat, 31 Oct 2020 12:55:56 -0400
Subject: [PATCH] sof-firmware: update to 1.6, Closes #24776, Closes #24271
---
srcpkgs/sof-firmware/template | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 00dfd262191..e6e44910f6e 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,15 +1,16 @@
# Template file for 'sof-firmware'
pkgname=sof-firmware
-version=1.5.1
+version=1.6
revision=1
+_githash=47b436af36c18c3b4f409e1d9452aea18e17abc8
archs="i686* x86_64*"
-wrksrc=sof-bin-stable-v${version}
+wrksrc=sof-bin-${_githash}
short_desc="Sound Open Firmware and topology binaries"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="BSD-3-Clause"
homepage="https://thesofproject.github.io/latest/index.html"
-distfiles="https://github.com/thesofproject/sof-bin/archive/stable-v${version}.tar.gz"
-checksum=270125fb621b9919de4190f53a86de5dc1163dcf839c349f4b22724a5a9c1fb1
+distfiles="https://github.com/thesofproject/sof-bin/archive/${_githash}.tar.gz"
+checksum=3eb522b25f63a9cff67a4f123ed810d95809471b22c3930912eb70394d53b274
do_install() {
local intel_path="lib/firmware/intel"
@@ -22,12 +23,15 @@ do_install() {
for f in ${intel_path}/sof/v${version}/public-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/public-signed
done
- for arc in {bdw,byt,cht,apl,cnl,icl}; do
+ for arc in {bdw,byt,cht}; do
ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
done
- ln -s sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
+ for arc in {apl,cnl,icl}; do
+ ln -s intel-signed/sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ done
+ ln -s intel-signed/sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
+ ln -s intel-signed/sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
+ ln -s intel-signed/sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
for f in ${intel_path}/sof-tplg-v${version}/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof-tplg
done
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (2 preceding siblings ...)
2020-11-06 0:33 ` [PR PATCH] [Updated] " cinerea0
@ 2020-11-06 15:15 ` cinerea0
2020-11-24 0:42 ` ericonr
` (37 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-11-06 15:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-723133854
Comment:
Thank you for the tip! I've updated the commit message.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (3 preceding siblings ...)
2020-11-06 15:15 ` cinerea0
@ 2020-11-24 0:42 ` ericonr
2020-12-06 18:15 ` sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4 cinerea0
` (36 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-11-24 0:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-732509437
Comment:
@cinerea0 feel free to ping PRs which haven't been looked at in a while.
Do you want to wait for a resolution to #26419 first?
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (4 preceding siblings ...)
2020-11-24 0:42 ` ericonr
@ 2020-12-06 18:15 ` cinerea0
2020-12-06 22:45 ` [PR REVIEW] " ericonr
` (35 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-06 18:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-739541314
Comment:
@ericonr Is this okay to be merged?
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (5 preceding siblings ...)
2020-12-06 18:15 ` sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4 cinerea0
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
` (34 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140030
Comment:
Should be `usr/share/alsa/ucm2`.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (7 preceding siblings ...)
2020-12-06 22:45 ` ericonr
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
` (32 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140158
Comment:
hm, why is it restricted?
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (10 preceding siblings ...)
2020-12-06 22:45 ` ericonr
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
` (29 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140116
Comment:
For that matter, this should probably be `vdoc`.
And you don't want to use 755 permissions for documentation :P
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (6 preceding siblings ...)
2020-12-06 22:45 ` [PR REVIEW] " ericonr
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
` (33 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140617
Comment:
Could this loop simply `vinstall` the folder into `usr/share/alsa` ? That would avoid the need for `vmkdir`.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (8 preceding siblings ...)
2020-12-06 22:45 ` ericonr
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
` (31 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140490
Comment:
Does it actually need to depend on `alsa-lib`? The files are necessary for correct ALSA on some places, perhaps, but maybe it shouldn't need ALSA.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (9 preceding siblings ...)
2020-12-06 22:45 ` ericonr
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
` (30 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 157 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140059
Comment:
Same here.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (11 preceding siblings ...)
2020-12-06 22:45 ` ericonr
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
` (28 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537141456
Comment:
And here as well.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (12 preceding siblings ...)
2020-12-06 22:45 ` ericonr
@ 2020-12-06 22:45 ` ericonr
2020-12-06 22:46 ` ericonr
` (27 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537141250
Comment:
The `1.6-rc3` version number should be a variable, because it seems to be used in multiple places. You could do something like:
```
version=1.6rc3
_major=${version%rc*}
_minor=${version#${_major}}
```
And replace where it's used.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (13 preceding siblings ...)
2020-12-06 22:45 ` ericonr
@ 2020-12-06 22:46 ` ericonr
2020-12-06 22:46 ` ericonr
` (26 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140617
Comment:
Could this loop be replaced by `vinstall` the folder into `usr/share/alsa` ? That would avoid the need for `vmkdir`.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (14 preceding siblings ...)
2020-12-06 22:46 ` ericonr
@ 2020-12-06 22:46 ` ericonr
2020-12-07 0:52 ` cinerea0
` (25 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-06 22:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537140617
Comment:
Could this loop be replaced by `vinstall` the `ucm2` folder into `usr/share/alsa` ? That would avoid the need for `vmkdir`.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (15 preceding siblings ...)
2020-12-06 22:46 ` ericonr
@ 2020-12-07 0:52 ` cinerea0
2020-12-07 0:53 ` cinerea0
` (24 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 0:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 334 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537165381
Comment:
My thought was originally that it would only be useful for x86 chips, but I looked into it more and it provides files that are useful on a variety of architectures. I'll remove the line.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (16 preceding siblings ...)
2020-12-07 0:52 ` cinerea0
@ 2020-12-07 0:53 ` cinerea0
2020-12-07 0:54 ` cinerea0
` (23 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 0:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537165446
Comment:
It doesn't have a runtime dependency on ALSA, no. I'll remove the line.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (17 preceding siblings ...)
2020-12-07 0:53 ` cinerea0
@ 2020-12-07 0:54 ` cinerea0
2020-12-07 0:56 ` ericonr
` (22 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 0:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537165574
Comment:
Would that overwrite other files in the `ucm2` folder during installation?
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (18 preceding siblings ...)
2020-12-07 0:54 ` cinerea0
@ 2020-12-07 0:56 ` ericonr
2020-12-07 1:14 ` cinerea0
` (21 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-07 0:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537166127
Comment:
No. The result should be exactly the same.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (19 preceding siblings ...)
2020-12-07 0:56 ` ericonr
@ 2020-12-07 1:14 ` cinerea0
2020-12-07 1:36 ` cinerea0
` (20 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 1:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 212 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537170429
Comment:
Would you believe I forgot `vdoc` exists? I've changed the line.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (20 preceding siblings ...)
2020-12-07 1:14 ` cinerea0
@ 2020-12-07 1:36 ` cinerea0
2020-12-07 2:03 ` ericonr
` (19 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 1:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537175675
Comment:
I'm getting the following error after replacing the lines selected above with `vinstall ucm2 0755 usr/share/alsa`:
```
/usr/bin/install: omitting directory 'ucm2'
=> ERROR: alsa-ucm-conf-1.2.4_1: do_install: 'install -Dm${mode} "${file}" "${_destdir}/${targetdir}/${file##*/}"' exited with 1
=> ERROR: in _vinstall() at common/environment/setup/install.sh:171
=> ERROR: in _noglob_helper() at common/environment/setup/install.sh:12
=> ERROR: in do_install() at srcpkgs/alsa-ucm-conf/template:19
```
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (21 preceding siblings ...)
2020-12-07 1:36 ` cinerea0
@ 2020-12-07 2:03 ` ericonr
2020-12-07 3:22 ` cinerea0
` (18 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-07 2:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537182573
Comment:
I might be mistaken and the correct thing to do would be to use `vcopy` for the entire folder, then. (which avoid the loop)
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (22 preceding siblings ...)
2020-12-07 2:03 ` ericonr
@ 2020-12-07 3:22 ` cinerea0
2020-12-07 3:58 ` ericonr
` (17 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 3:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537204823
Comment:
That works! Is it okay to leave off the installation mode, because `vcopy` doesn't allow setting that.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (23 preceding siblings ...)
2020-12-07 3:22 ` cinerea0
@ 2020-12-07 3:58 ` ericonr
2020-12-07 4:11 ` [PR PATCH] [Updated] " cinerea0
` (16 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-07 3:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537214606
Comment:
Should be okay, assuming the permissions in the tarball itself were reasonable.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR PATCH] [Updated] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (24 preceding siblings ...)
2020-12-07 3:58 ` ericonr
@ 2020-12-07 4:11 ` cinerea0
2020-12-07 4:18 ` cinerea0
` (15 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 4:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages sof
https://github.com/void-linux/void-packages/pull/26003
sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
Closes #24776
Closes #24271
Closes #26419
A patch file from https://github.com/void-linux/void-packages/pull/26003.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-26003.patch --]
[-- Type: text/x-diff, Size: 1091 bytes --]
From 80fb9a406dfa9bdab6b38aa1b9d771c369fb617f Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Sun, 6 Dec 2020 23:11:05 -0500
Subject: [PATCH] New package: alsa-ucm-conf-1.2.4
---
srcpkgs/alsa-ucm-conf/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/alsa-ucm-conf/template
diff --git a/srcpkgs/alsa-ucm-conf/template b/srcpkgs/alsa-ucm-conf/template
new file mode 100644
index 00000000000..cb06705ef2f
--- /dev/null
+++ b/srcpkgs/alsa-ucm-conf/template
@@ -0,0 +1,17 @@
+# Template file for 'alsa-ucm-conf'
+pkgname=alsa-ucm-conf
+version=1.2.4
+revision=1
+short_desc="ALSA Use Case Manager topology configurations"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/alsa-project/alsa-ucm-conf"
+distfiles="https://www.alsa-project.org/files/pub/lib/${pkgname}-${version}.tar.bz2"
+checksum=2c3b535c77dcb9aaf62a61f4f8324f1ab184162f105f7ec9ed1e37c742fcd340
+
+do_install() {
+ vdoc ucm2/README.md
+ rm ucm2/README.md
+ vcopy ucm2 usr/share/alsa
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR PATCH] [Updated] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (25 preceding siblings ...)
2020-12-07 4:11 ` [PR PATCH] [Updated] " cinerea0
@ 2020-12-07 4:18 ` cinerea0
2020-12-07 7:32 ` [PR REVIEW] " cinerea0
` (14 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 4:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages sof
https://github.com/void-linux/void-packages/pull/26003
sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
Closes #24776
Closes #24271
Closes #26419
A patch file from https://github.com/void-linux/void-packages/pull/26003.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-26003.patch --]
[-- Type: text/x-diff, Size: 4087 bytes --]
From 80fb9a406dfa9bdab6b38aa1b9d771c369fb617f Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Sun, 6 Dec 2020 23:11:05 -0500
Subject: [PATCH 1/2] New package: alsa-ucm-conf-1.2.4
---
srcpkgs/alsa-ucm-conf/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/alsa-ucm-conf/template
diff --git a/srcpkgs/alsa-ucm-conf/template b/srcpkgs/alsa-ucm-conf/template
new file mode 100644
index 00000000000..cb06705ef2f
--- /dev/null
+++ b/srcpkgs/alsa-ucm-conf/template
@@ -0,0 +1,17 @@
+# Template file for 'alsa-ucm-conf'
+pkgname=alsa-ucm-conf
+version=1.2.4
+revision=1
+short_desc="ALSA Use Case Manager topology configurations"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/alsa-project/alsa-ucm-conf"
+distfiles="https://www.alsa-project.org/files/pub/lib/${pkgname}-${version}.tar.bz2"
+checksum=2c3b535c77dcb9aaf62a61f4f8324f1ab184162f105f7ec9ed1e37c742fcd340
+
+do_install() {
+ vdoc ucm2/README.md
+ rm ucm2/README.md
+ vcopy ucm2 usr/share/alsa
+ vlicense LICENSE
+}
From 410a421c405f7afc9948d57f3995c351383a8edc Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Sun, 6 Dec 2020 23:17:58 -0500
Subject: [PATCH 2/2] sof-firmware: update to 1.6rc3, Closes #24776, Closes
#24271
---
srcpkgs/sof-firmware/template | 32 +++++++++++++++++++-------------
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 00dfd262191..7ab46e76aa5 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,34 +1,40 @@
# Template file for 'sof-firmware'
pkgname=sof-firmware
-version=1.5.1
+version=1.6rc3
revision=1
+_major=${version%rc*}
+_minor=${version#${_major}}
archs="i686* x86_64*"
-wrksrc=sof-bin-stable-v${version}
+wrksrc="sof-bin-${_major}-${_minor}"
+depends="alsa-ucm-conf"
short_desc="Sound Open Firmware and topology binaries"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="BSD-3-Clause"
homepage="https://thesofproject.github.io/latest/index.html"
-distfiles="https://github.com/thesofproject/sof-bin/archive/stable-v${version}.tar.gz"
-checksum=270125fb621b9919de4190f53a86de5dc1163dcf839c349f4b22724a5a9c1fb1
+distfiles="https://github.com/thesofproject/sof-bin/archive/v${_major}-${_minor}.tar.gz"
+checksum=daefbeedfb26aa45ef73cc89d90f33dfb4c797244d40a00c8ac652ca3a5b4dce
do_install() {
local intel_path="lib/firmware/intel"
- for f in ${intel_path}/sof/v${version}/*.{ldc,ri}; do
+ for f in ${intel_path}/sof/v${_major}/*.{ldc,ri}; do
vinstall ${f} 0644 /usr/${intel_path}/sof
done
- for f in ${intel_path}/sof/v${version}/intel-signed/*; do
+ for f in ${intel_path}/sof/v${_major}/intel-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/intel-signed
done
- for f in ${intel_path}/sof/v${version}/public-signed/*; do
+ for f in ${intel_path}/sof/v${_major}/public-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/public-signed
done
- for arc in {bdw,byt,cht,apl,cnl,icl}; do
- ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ for arc in {bdw,byt,cht}; do
+ ln -s sof-${arc}-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
done
- ln -s sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
- for f in ${intel_path}/sof-tplg-v${version}/*; do
+ for arc in {apl,cnl,icl}; do
+ ln -s intel-signed/sof-${arc}-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ done
+ ln -s intel-signed/sof-apl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
+ ln -s intel-signed/sof-cnl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
+ ln -s intel-signed/sof-cnl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
+ for f in ${intel_path}/sof-tplg-v${_major}/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof-tplg
done
vlicense LICENCE.NXP
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (26 preceding siblings ...)
2020-12-07 4:18 ` cinerea0
@ 2020-12-07 7:32 ` cinerea0
2020-12-07 14:43 ` ericonr
` (13 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-07 7:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537285490
Comment:
I'm having a problem. Removing the `vmkdir` line and copying directly into the `alsa` directory just spews the contents of `ucm2` all over the `alsa` directory. Making the `ucm2` directory first and then copying the folder into it results in the files being located in `/usr/share/alsa/ucm2/ucm2`. Shouldn't there be a middle ground here?
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (27 preceding siblings ...)
2020-12-07 7:32 ` [PR REVIEW] " cinerea0
@ 2020-12-07 14:43 ` ericonr
2020-12-10 7:28 ` [PR PATCH] [Updated] " cinerea0
` (12 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-07 14:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r537560380
Comment:
I believe you need to `vmkdir usr/share/alsa` :)
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR PATCH] [Updated] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (28 preceding siblings ...)
2020-12-07 14:43 ` ericonr
@ 2020-12-10 7:28 ` cinerea0
2020-12-10 7:29 ` [PR REVIEW] " cinerea0
` (11 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 7:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages sof
https://github.com/void-linux/void-packages/pull/26003
sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
Closes #24776
Closes #24271
Closes #26419
A patch file from https://github.com/void-linux/void-packages/pull/26003.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-26003.patch --]
[-- Type: text/x-diff, Size: 1117 bytes --]
From 3fbc6d60a0237ad04622e5470004dafa46b421ab Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Thu, 10 Dec 2020 02:24:39 -0500
Subject: [PATCH] New package: alsa-ucm-conf-1.2.4
---
srcpkgs/alsa-ucm-conf/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/alsa-ucm-conf/template
diff --git a/srcpkgs/alsa-ucm-conf/template b/srcpkgs/alsa-ucm-conf/template
new file mode 100644
index 00000000000..1a222b9e3cc
--- /dev/null
+++ b/srcpkgs/alsa-ucm-conf/template
@@ -0,0 +1,18 @@
+# Template file for 'alsa-ucm-conf'
+pkgname=alsa-ucm-conf
+version=1.2.4
+revision=1
+short_desc="ALSA Use Case Manager topology configurations"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/alsa-project/alsa-ucm-conf"
+distfiles="https://www.alsa-project.org/files/pub/lib/${pkgname}-${version}.tar.bz2"
+checksum=2c3b535c77dcb9aaf62a61f4f8324f1ab184162f105f7ec9ed1e37c742fcd340
+
+do_install() {
+ vdoc ucm2/README.md
+ rm ucm2/README.md
+ vmkdir usr/share/alsa
+ vcopy ucm2 usr/share/alsa
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (29 preceding siblings ...)
2020-12-10 7:28 ` [PR PATCH] [Updated] " cinerea0
@ 2020-12-10 7:29 ` cinerea0
2020-12-10 7:32 ` [PR PATCH] [Updated] " cinerea0
` (10 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 7:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r539936317
Comment:
Yep, that did it. Pushing an update shortly.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR PATCH] [Updated] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (30 preceding siblings ...)
2020-12-10 7:29 ` [PR REVIEW] " cinerea0
@ 2020-12-10 7:32 ` cinerea0
2020-12-10 7:41 ` cinerea0
` (9 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 7:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages sof
https://github.com/void-linux/void-packages/pull/26003
sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
Closes #24776
Closes #24271
Closes #26419
A patch file from https://github.com/void-linux/void-packages/pull/26003.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-26003.patch --]
[-- Type: text/x-diff, Size: 4115 bytes --]
From 3fbc6d60a0237ad04622e5470004dafa46b421ab Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Thu, 10 Dec 2020 02:24:39 -0500
Subject: [PATCH 1/2] New package: alsa-ucm-conf-1.2.4
---
srcpkgs/alsa-ucm-conf/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/alsa-ucm-conf/template
diff --git a/srcpkgs/alsa-ucm-conf/template b/srcpkgs/alsa-ucm-conf/template
new file mode 100644
index 00000000000..1a222b9e3cc
--- /dev/null
+++ b/srcpkgs/alsa-ucm-conf/template
@@ -0,0 +1,18 @@
+# Template file for 'alsa-ucm-conf'
+pkgname=alsa-ucm-conf
+version=1.2.4
+revision=1
+short_desc="ALSA Use Case Manager topology configurations"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/alsa-project/alsa-ucm-conf"
+distfiles="https://www.alsa-project.org/files/pub/lib/${pkgname}-${version}.tar.bz2"
+checksum=2c3b535c77dcb9aaf62a61f4f8324f1ab184162f105f7ec9ed1e37c742fcd340
+
+do_install() {
+ vdoc ucm2/README.md
+ rm ucm2/README.md
+ vmkdir usr/share/alsa
+ vcopy ucm2 usr/share/alsa
+ vlicense LICENSE
+}
From bfb0b7e948fde2a358e4715f51d3f93ec9bad0dc Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Thu, 10 Dec 2020 02:28:21 -0500
Subject: [PATCH 2/2] sof-firmware: update to 1.6rc3, Closes #24776, Closes
#24271
---
srcpkgs/sof-firmware/template | 32 +++++++++++++++++++-------------
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 00dfd262191..7ab46e76aa5 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,34 +1,40 @@
# Template file for 'sof-firmware'
pkgname=sof-firmware
-version=1.5.1
+version=1.6rc3
revision=1
+_major=${version%rc*}
+_minor=${version#${_major}}
archs="i686* x86_64*"
-wrksrc=sof-bin-stable-v${version}
+wrksrc="sof-bin-${_major}-${_minor}"
+depends="alsa-ucm-conf"
short_desc="Sound Open Firmware and topology binaries"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="BSD-3-Clause"
homepage="https://thesofproject.github.io/latest/index.html"
-distfiles="https://github.com/thesofproject/sof-bin/archive/stable-v${version}.tar.gz"
-checksum=270125fb621b9919de4190f53a86de5dc1163dcf839c349f4b22724a5a9c1fb1
+distfiles="https://github.com/thesofproject/sof-bin/archive/v${_major}-${_minor}.tar.gz"
+checksum=daefbeedfb26aa45ef73cc89d90f33dfb4c797244d40a00c8ac652ca3a5b4dce
do_install() {
local intel_path="lib/firmware/intel"
- for f in ${intel_path}/sof/v${version}/*.{ldc,ri}; do
+ for f in ${intel_path}/sof/v${_major}/*.{ldc,ri}; do
vinstall ${f} 0644 /usr/${intel_path}/sof
done
- for f in ${intel_path}/sof/v${version}/intel-signed/*; do
+ for f in ${intel_path}/sof/v${_major}/intel-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/intel-signed
done
- for f in ${intel_path}/sof/v${version}/public-signed/*; do
+ for f in ${intel_path}/sof/v${_major}/public-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/public-signed
done
- for arc in {bdw,byt,cht,apl,cnl,icl}; do
- ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ for arc in {bdw,byt,cht}; do
+ ln -s sof-${arc}-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
done
- ln -s sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
- for f in ${intel_path}/sof-tplg-v${version}/*; do
+ for arc in {apl,cnl,icl}; do
+ ln -s intel-signed/sof-${arc}-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ done
+ ln -s intel-signed/sof-apl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
+ ln -s intel-signed/sof-cnl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
+ ln -s intel-signed/sof-cnl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
+ for f in ${intel_path}/sof-tplg-v${_major}/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof-tplg
done
vlicense LICENCE.NXP
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (31 preceding siblings ...)
2020-12-10 7:32 ` [PR PATCH] [Updated] " cinerea0
@ 2020-12-10 7:41 ` cinerea0
2020-12-10 15:22 ` [PR REVIEW] " ericonr
` (8 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 7:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-742320560
Comment:
@ericonr Sorry for taking so long to fix this, but these templates install everything where they're supposed to now. Is it okay to merge?
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (32 preceding siblings ...)
2020-12-10 7:41 ` cinerea0
@ 2020-12-10 15:22 ` ericonr
2020-12-10 15:24 ` ericonr
` (7 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-10 15:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r540256062
Comment:
Question, why wouldn't you use https://github.com/thesofproject/sof-bin/tree/stable-v1.6 ?
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (33 preceding siblings ...)
2020-12-10 15:22 ` [PR REVIEW] " ericonr
@ 2020-12-10 15:24 ` ericonr
2020-12-10 18:35 ` [PR REVIEW] " cinerea0
` (6 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-10 15:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-742589182
Comment:
Hm, about the commit message,
> sof-firmware: update to 1.6rc3, Closes #24776, Closes #24271
You can either omit them (listing them in the PR description is enough) or put them in the commit body, otherwise the title gets a bit crowded for little gain.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (34 preceding siblings ...)
2020-12-10 15:24 ` ericonr
@ 2020-12-10 18:35 ` cinerea0
2020-12-10 18:43 ` [PR PATCH] [Updated] " cinerea0
` (5 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 18:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r540405022
Comment:
While the branch has the label "stable", there's no tagged release in it, so I'd have to choose the commit at the head of that branch. In general, I assumed it was preferred to choose tagged releases over potentially arbitrary commits.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR PATCH] [Updated] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (35 preceding siblings ...)
2020-12-10 18:35 ` [PR REVIEW] " cinerea0
@ 2020-12-10 18:43 ` cinerea0
2020-12-10 18:47 ` cinerea0
` (4 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 18:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages sof
https://github.com/void-linux/void-packages/pull/26003
sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
Closes #24776
Closes #24271
Closes #26419
A patch file from https://github.com/void-linux/void-packages/pull/26003.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-26003.patch --]
[-- Type: text/x-diff, Size: 4083 bytes --]
From 3fbc6d60a0237ad04622e5470004dafa46b421ab Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Thu, 10 Dec 2020 02:24:39 -0500
Subject: [PATCH 1/2] New package: alsa-ucm-conf-1.2.4
---
srcpkgs/alsa-ucm-conf/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/alsa-ucm-conf/template
diff --git a/srcpkgs/alsa-ucm-conf/template b/srcpkgs/alsa-ucm-conf/template
new file mode 100644
index 00000000000..1a222b9e3cc
--- /dev/null
+++ b/srcpkgs/alsa-ucm-conf/template
@@ -0,0 +1,18 @@
+# Template file for 'alsa-ucm-conf'
+pkgname=alsa-ucm-conf
+version=1.2.4
+revision=1
+short_desc="ALSA Use Case Manager topology configurations"
+maintainer="cinerea0 <cinerea0@protonmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/alsa-project/alsa-ucm-conf"
+distfiles="https://www.alsa-project.org/files/pub/lib/${pkgname}-${version}.tar.bz2"
+checksum=2c3b535c77dcb9aaf62a61f4f8324f1ab184162f105f7ec9ed1e37c742fcd340
+
+do_install() {
+ vdoc ucm2/README.md
+ rm ucm2/README.md
+ vmkdir usr/share/alsa
+ vcopy ucm2 usr/share/alsa
+ vlicense LICENSE
+}
From 27b350d678a7707d2aa805fa79b0429c9b528ca4 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@protonmail.com>
Date: Thu, 10 Dec 2020 13:42:59 -0500
Subject: [PATCH 2/2] sof-firmware: update to 1.6rc3
---
srcpkgs/sof-firmware/template | 32 +++++++++++++++++++-------------
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 00dfd262191..7ab46e76aa5 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,34 +1,40 @@
# Template file for 'sof-firmware'
pkgname=sof-firmware
-version=1.5.1
+version=1.6rc3
revision=1
+_major=${version%rc*}
+_minor=${version#${_major}}
archs="i686* x86_64*"
-wrksrc=sof-bin-stable-v${version}
+wrksrc="sof-bin-${_major}-${_minor}"
+depends="alsa-ucm-conf"
short_desc="Sound Open Firmware and topology binaries"
maintainer="cinerea0 <cinerea0@protonmail.com>"
license="BSD-3-Clause"
homepage="https://thesofproject.github.io/latest/index.html"
-distfiles="https://github.com/thesofproject/sof-bin/archive/stable-v${version}.tar.gz"
-checksum=270125fb621b9919de4190f53a86de5dc1163dcf839c349f4b22724a5a9c1fb1
+distfiles="https://github.com/thesofproject/sof-bin/archive/v${_major}-${_minor}.tar.gz"
+checksum=daefbeedfb26aa45ef73cc89d90f33dfb4c797244d40a00c8ac652ca3a5b4dce
do_install() {
local intel_path="lib/firmware/intel"
- for f in ${intel_path}/sof/v${version}/*.{ldc,ri}; do
+ for f in ${intel_path}/sof/v${_major}/*.{ldc,ri}; do
vinstall ${f} 0644 /usr/${intel_path}/sof
done
- for f in ${intel_path}/sof/v${version}/intel-signed/*; do
+ for f in ${intel_path}/sof/v${_major}/intel-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/intel-signed
done
- for f in ${intel_path}/sof/v${version}/public-signed/*; do
+ for f in ${intel_path}/sof/v${_major}/public-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/public-signed
done
- for arc in {bdw,byt,cht,apl,cnl,icl}; do
- ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ for arc in {bdw,byt,cht}; do
+ ln -s sof-${arc}-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
done
- ln -s sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
- for f in ${intel_path}/sof-tplg-v${version}/*; do
+ for arc in {apl,cnl,icl}; do
+ ln -s intel-signed/sof-${arc}-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+ done
+ ln -s intel-signed/sof-apl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
+ ln -s intel-signed/sof-cnl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
+ ln -s intel-signed/sof-cnl-v${_major}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
+ for f in ${intel_path}/sof-tplg-v${_major}/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof-tplg
done
vlicense LICENCE.NXP
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (36 preceding siblings ...)
2020-12-10 18:43 ` [PR PATCH] [Updated] " cinerea0
@ 2020-12-10 18:47 ` cinerea0
2020-12-10 18:48 ` [PR REVIEW] " ericonr
` (3 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 18:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#issuecomment-742719808
Comment:
> Hm, about the commit message,
>
> > sof-firmware: update to 1.6rc3, Closes #24776, Closes #24271
>
> You can either omit them (listing them in the PR description is enough) or put them in the commit body, otherwise the title gets a bit crowded for little gain.
Gotcha, I've removed them from the commit title.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (37 preceding siblings ...)
2020-12-10 18:47 ` cinerea0
@ 2020-12-10 18:48 ` ericonr
2020-12-10 18:48 ` [PR PATCH] [Merged]: " ericonr
` (2 subsequent siblings)
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-10 18:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r540412983
Comment:
If you can reach out to upstream to ask about proper releases for the stable channels, that'd be awesome!
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR PATCH] [Merged]: sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (38 preceding siblings ...)
2020-12-10 18:48 ` [PR REVIEW] " ericonr
@ 2020-12-10 18:48 ` ericonr
2020-12-10 20:38 ` [PR REVIEW] " cinerea0
2020-12-10 20:41 ` ericonr
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-10 18:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
There's a merged pull request on the void-packages repository
sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
https://github.com/void-linux/void-packages/pull/26003
Description:
In addition to updating this package to version 1.6, this commit incorporates unmerged fixes proposed in #24776 and #24271. It also fixes a distfile error regarding pulling from a branch vs pulling from a commit. I would have pinned the distfile to a release tag, but unfortunately the sof-firmware project does not yet use those, though they are aware of the problem as shown by https://github.com/thesofproject/sof-bin/issues/21.
Closes #24776
Closes #24271
Closes #26419
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (39 preceding siblings ...)
2020-12-10 18:48 ` [PR PATCH] [Merged]: " ericonr
@ 2020-12-10 20:38 ` cinerea0
2020-12-10 20:41 ` ericonr
41 siblings, 0 replies; 43+ messages in thread
From: cinerea0 @ 2020-12-10 20:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r540480428
Comment:
It looks like there's ongoing discussion about it in thesofproject/sof-bin#25; I've left a comment there asking for clarification that this problem will be fixed for the next release.
^ permalink raw reply [flat|nested] 43+ messages in thread
* Re: [PR REVIEW] sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
` (40 preceding siblings ...)
2020-12-10 20:38 ` [PR REVIEW] " cinerea0
@ 2020-12-10 20:41 ` ericonr
41 siblings, 0 replies; 43+ messages in thread
From: ericonr @ 2020-12-10 20:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26003#discussion_r540482125
Comment:
Heh, that looks messy. Glad they are trying to fix it :)
^ permalink raw reply [flat|nested] 43+ messages in thread
end of thread, other threads:[~2020-12-10 20:41 UTC | newest]
Thread overview: 43+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-31 17:05 [PR PATCH] sof-firmware: update to 1.6 cinerea0
2020-11-02 2:45 ` cinerea0
2020-11-02 5:21 ` Johnnynator
2020-11-06 0:33 ` [PR PATCH] [Updated] " cinerea0
2020-11-06 15:15 ` cinerea0
2020-11-24 0:42 ` ericonr
2020-12-06 18:15 ` sof-firmware: update to 1.6rc3; New package: alsa-ucm-conf-1.2.4 cinerea0
2020-12-06 22:45 ` [PR REVIEW] " ericonr
2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
2020-12-06 22:45 ` ericonr
2020-12-06 22:46 ` ericonr
2020-12-06 22:46 ` ericonr
2020-12-07 0:52 ` cinerea0
2020-12-07 0:53 ` cinerea0
2020-12-07 0:54 ` cinerea0
2020-12-07 0:56 ` ericonr
2020-12-07 1:14 ` cinerea0
2020-12-07 1:36 ` cinerea0
2020-12-07 2:03 ` ericonr
2020-12-07 3:22 ` cinerea0
2020-12-07 3:58 ` ericonr
2020-12-07 4:11 ` [PR PATCH] [Updated] " cinerea0
2020-12-07 4:18 ` cinerea0
2020-12-07 7:32 ` [PR REVIEW] " cinerea0
2020-12-07 14:43 ` ericonr
2020-12-10 7:28 ` [PR PATCH] [Updated] " cinerea0
2020-12-10 7:29 ` [PR REVIEW] " cinerea0
2020-12-10 7:32 ` [PR PATCH] [Updated] " cinerea0
2020-12-10 7:41 ` cinerea0
2020-12-10 15:22 ` [PR REVIEW] " ericonr
2020-12-10 15:24 ` ericonr
2020-12-10 18:35 ` [PR REVIEW] " cinerea0
2020-12-10 18:43 ` [PR PATCH] [Updated] " cinerea0
2020-12-10 18:47 ` cinerea0
2020-12-10 18:48 ` [PR REVIEW] " ericonr
2020-12-10 18:48 ` [PR PATCH] [Merged]: " ericonr
2020-12-10 20:38 ` [PR REVIEW] " cinerea0
2020-12-10 20:41 ` ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).