Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] vpnd: drop noarch + add runit service
@ 2020-11-06  6:58 shizonic
  2020-11-06 14:39 ` [PR REVIEW] " ahesford
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: shizonic @ 2020-11-06  6:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

There is a new pull request by shizonic against master on the void-packages repository

https://github.com/shizonic/void-packages vpnd
https://github.com/void-linux/void-packages/pull/26162

vpnd: drop noarch + add runit service


A patch file from https://github.com/void-linux/void-packages/pull/26162.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vpnd-26162.patch --]
[-- Type: text/x-diff, Size: 1209 bytes --]

From 90b71801ce6bdcd3bdd0c90e5f7cf2ad8063043f Mon Sep 17 00:00:00 2001
From: Toby Merz <realtiaz@gmail.com>
Date: Fri, 6 Nov 2020 07:57:24 +0100
Subject: [PATCH] vpnd: drop noarch + add runit service

---
 srcpkgs/vpnd/files/vpnd/run | 3 +++
 srcpkgs/vpnd/template       | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/vpnd/files/vpnd/run

diff --git a/srcpkgs/vpnd/files/vpnd/run b/srcpkgs/vpnd/files/vpnd/run
new file mode 100644
index 00000000000..fd0567707a4
--- /dev/null
+++ b/srcpkgs/vpnd/files/vpnd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+install -d -m0700 /var/run/vpnd
+exec /usr/bin/vpnd
diff --git a/srcpkgs/vpnd/template b/srcpkgs/vpnd/template
index fa4222ae372..af90e155cab 100644
--- a/srcpkgs/vpnd/template
+++ b/srcpkgs/vpnd/template
@@ -1,9 +1,8 @@
 # Template file for 'vpnd'
 pkgname=vpnd
 version=0.1.3
-revision=1
-archs=noarch
-depends="bash"
+revision=2
+depends="bash libnotify"
 conf_files="/etc/vpnd.conf"
 short_desc="Package update notifier daemon for Void Linux"
 maintainer="Benjamin Slade <slade@lambda-y.net>"
@@ -17,4 +16,5 @@ do_install() {
 	vmkdir usr/share/icons/vpnd
 	vcopy "*.png" usr/share/icons/vpnd
 	vconf vpnd.conf
+	vsv vpnd
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] vpnd: drop noarch + add runit service
  2020-11-06  6:58 [PR PATCH] vpnd: drop noarch + add runit service shizonic
@ 2020-11-06 14:39 ` ahesford
  2020-11-06 17:26 ` shizonic
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-11-06 14:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26162#discussion_r518792787

Comment:
What is the purpose of this directory? I see no mention of it in `/usr/bin/vpnd` or `/etc/vpnd.conf`.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] vpnd: drop noarch + add runit service
  2020-11-06  6:58 [PR PATCH] vpnd: drop noarch + add runit service shizonic
  2020-11-06 14:39 ` [PR REVIEW] " ahesford
@ 2020-11-06 17:26 ` shizonic
  2020-11-09  6:17 ` [PR PATCH] [Updated] " shizonic
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: shizonic @ 2020-11-06 17:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by shizonic on void-packages repository

https://github.com/void-linux/void-packages/pull/26162#discussion_r518896879

Comment:
Oh my goodness! I am sorry. This was a leftover from an other template. I'll remove it ASAP. Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] vpnd: drop noarch + add runit service
  2020-11-06  6:58 [PR PATCH] vpnd: drop noarch + add runit service shizonic
  2020-11-06 14:39 ` [PR REVIEW] " ahesford
  2020-11-06 17:26 ` shizonic
@ 2020-11-09  6:17 ` shizonic
  2020-11-09  6:17 ` [PR REVIEW] " shizonic
  2020-11-09 18:51 ` [PR PATCH] [Merged]: " ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: shizonic @ 2020-11-09  6:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

There is an updated pull request by shizonic against master on the void-packages repository

https://github.com/shizonic/void-packages vpnd
https://github.com/void-linux/void-packages/pull/26162

vpnd: drop noarch + add runit service


A patch file from https://github.com/void-linux/void-packages/pull/26162.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vpnd-26162.patch --]
[-- Type: text/x-diff, Size: 1175 bytes --]

From 5d667707ebc20c3f384e7784a60a66c531a69eb1 Mon Sep 17 00:00:00 2001
From: Toby Merz <realtiaz@gmail.com>
Date: Fri, 6 Nov 2020 07:57:24 +0100
Subject: [PATCH] vpnd: drop noarch + add runit service

---
 srcpkgs/vpnd/files/vpnd/run | 2 ++
 srcpkgs/vpnd/template       | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/vpnd/files/vpnd/run

diff --git a/srcpkgs/vpnd/files/vpnd/run b/srcpkgs/vpnd/files/vpnd/run
new file mode 100644
index 00000000000..9f023775841
--- /dev/null
+++ b/srcpkgs/vpnd/files/vpnd/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec /usr/bin/vpnd
diff --git a/srcpkgs/vpnd/template b/srcpkgs/vpnd/template
index fa4222ae372..af90e155cab 100644
--- a/srcpkgs/vpnd/template
+++ b/srcpkgs/vpnd/template
@@ -1,9 +1,8 @@
 # Template file for 'vpnd'
 pkgname=vpnd
 version=0.1.3
-revision=1
-archs=noarch
-depends="bash"
+revision=2
+depends="bash libnotify"
 conf_files="/etc/vpnd.conf"
 short_desc="Package update notifier daemon for Void Linux"
 maintainer="Benjamin Slade <slade@lambda-y.net>"
@@ -17,4 +16,5 @@ do_install() {
 	vmkdir usr/share/icons/vpnd
 	vcopy "*.png" usr/share/icons/vpnd
 	vconf vpnd.conf
+	vsv vpnd
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR REVIEW] vpnd: drop noarch + add runit service
  2020-11-06  6:58 [PR PATCH] vpnd: drop noarch + add runit service shizonic
                   ` (2 preceding siblings ...)
  2020-11-09  6:17 ` [PR PATCH] [Updated] " shizonic
@ 2020-11-09  6:17 ` shizonic
  2020-11-09 18:51 ` [PR PATCH] [Merged]: " ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: shizonic @ 2020-11-09  6:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New review comment by shizonic on void-packages repository

https://github.com/void-linux/void-packages/pull/26162#discussion_r519573085

Comment:
Fixed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: vpnd: drop noarch + add runit service
  2020-11-06  6:58 [PR PATCH] vpnd: drop noarch + add runit service shizonic
                   ` (3 preceding siblings ...)
  2020-11-09  6:17 ` [PR REVIEW] " shizonic
@ 2020-11-09 18:51 ` ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-11-09 18:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

There's a merged pull request on the void-packages repository

vpnd: drop noarch + add runit service
https://github.com/void-linux/void-packages/pull/26162

Description:


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-11-09 18:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06  6:58 [PR PATCH] vpnd: drop noarch + add runit service shizonic
2020-11-06 14:39 ` [PR REVIEW] " ahesford
2020-11-06 17:26 ` shizonic
2020-11-09  6:17 ` [PR PATCH] [Updated] " shizonic
2020-11-09  6:17 ` [PR REVIEW] " shizonic
2020-11-09 18:51 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).