Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] deheader: update to 1.7
@ 2020-11-23 16:58 ndowens
  2020-11-24 15:57 ` [PR REVIEW] " ahesford
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: ndowens @ 2020-11-23 16:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

There is a new pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages deheader
https://github.com/void-linux/void-packages/pull/26648

deheader: update to 1.7
Change from python2 to python3

A patch file from https://github.com/void-linux/void-packages/pull/26648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-deheader-26648.patch --]
[-- Type: text/x-diff, Size: 1229 bytes --]

From a7412a19d3474e98c04bcd6060cb2b17f7cecf83 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 23 Nov 2020 10:58:13 -0600
Subject: [PATCH] deheader: update to 1.7

Change from python2 to python3
---
 srcpkgs/deheader/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/deheader/template b/srcpkgs/deheader/template
index 6b3a54eaf11..91fac0bfd45 100644
--- a/srcpkgs/deheader/template
+++ b/srcpkgs/deheader/template
@@ -1,18 +1,17 @@
 # Template file for 'deheader'
 pkgname=deheader
-version=1.6
-revision=4
-create_wrksrc=yes
+version=1.7
+revision=1
 hostmakedepends="tar"
-depends="python"
+depends="python3"
 short_desc="C and C++ header analyzer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="http://www.catb.org/~esr/deheader/"
 distfiles="http://www.catb.org/~esr/deheader/${pkgname}-${version}.tar.gz"
-checksum=3b99665c4f0dfda31d200bf2528540d6898cb846499ee91effa2e8f72aff3a60
+checksum=6856e4fa3efa664a0444b81c2e1f0209103be3b058455625c79abe65cf8db70d
 skip_extraction="${pkgname}-${version}.tar.gz"
-python_version=2
+python_version=3
 
 do_extract() {
 	# bsdtar fails to extract version 1.6 tarball which

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] deheader: update to 1.7
  2020-11-23 16:58 [PR PATCH] deheader: update to 1.7 ndowens
@ 2020-11-24 15:57 ` ahesford
  2020-11-24 19:49 ` ndowens
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-11-24 15:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26648#discussion_r529676967

Comment:
It looks like this, the entire `do_extract` function below the `hostmakedepends="tar"` are now unnecessary. Please confirm this to be true and, if so, remove them.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] deheader: update to 1.7
  2020-11-23 16:58 [PR PATCH] deheader: update to 1.7 ndowens
  2020-11-24 15:57 ` [PR REVIEW] " ahesford
@ 2020-11-24 19:49 ` ndowens
  2020-11-24 19:50 ` [PR PATCH] [Updated] " ndowens
  2020-11-24 19:56 ` [PR PATCH] [Merged]: " ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: ndowens @ 2020-11-24 19:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/26648#discussion_r529837548

Comment:
Seems, correct. ls -l doesn't show man page is linked, and man deheader works fine. So fix incoming.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] deheader: update to 1.7
  2020-11-23 16:58 [PR PATCH] deheader: update to 1.7 ndowens
  2020-11-24 15:57 ` [PR REVIEW] " ahesford
  2020-11-24 19:49 ` ndowens
@ 2020-11-24 19:50 ` ndowens
  2020-11-24 19:56 ` [PR PATCH] [Merged]: " ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: ndowens @ 2020-11-24 19:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages deheader
https://github.com/void-linux/void-packages/pull/26648

deheader: update to 1.7
Change from python2 to python3

A patch file from https://github.com/void-linux/void-packages/pull/26648.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-deheader-26648.patch --]
[-- Type: text/x-diff, Size: 1493 bytes --]

From 9b686f69f4b0b85c0e041c242ea284a3499c622a Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 23 Nov 2020 10:58:13 -0600
Subject: [PATCH] deheader: update to 1.7

Change from python2 to python3
---
 srcpkgs/deheader/template | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/deheader/template b/srcpkgs/deheader/template
index 6b3a54eaf11..8b763179efd 100644
--- a/srcpkgs/deheader/template
+++ b/srcpkgs/deheader/template
@@ -1,26 +1,15 @@
 # Template file for 'deheader'
 pkgname=deheader
-version=1.6
-revision=4
-create_wrksrc=yes
-hostmakedepends="tar"
-depends="python"
+version=1.7
+revision=1
+depends="python3"
 short_desc="C and C++ header analyzer"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="http://www.catb.org/~esr/deheader/"
 distfiles="http://www.catb.org/~esr/deheader/${pkgname}-${version}.tar.gz"
-checksum=3b99665c4f0dfda31d200bf2528540d6898cb846499ee91effa2e8f72aff3a60
-skip_extraction="${pkgname}-${version}.tar.gz"
-python_version=2
-
-do_extract() {
-	# bsdtar fails to extract version 1.6 tarball which
-	# contains a hard link from the man page to itself.
-	tar --strip-components 1 --no-same-owner --extract --file \
-		${XBPS_SRCDISTDIR}/${pkgname}-${version}/${pkgname}-${version}.tar.gz \
-		--directory ${wrksrc}
-}
+checksum=6856e4fa3efa664a0444b81c2e1f0209103be3b058455625c79abe65cf8db70d
+python_version=3
 
 do_install() {
 	vbin deheader

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: deheader: update to 1.7
  2020-11-23 16:58 [PR PATCH] deheader: update to 1.7 ndowens
                   ` (2 preceding siblings ...)
  2020-11-24 19:50 ` [PR PATCH] [Updated] " ndowens
@ 2020-11-24 19:56 ` ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-11-24 19:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

There's a merged pull request on the void-packages repository

deheader: update to 1.7
https://github.com/void-linux/void-packages/pull/26648

Description:
Change from python2 to python3

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-24 19:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 16:58 [PR PATCH] deheader: update to 1.7 ndowens
2020-11-24 15:57 ` [PR REVIEW] " ahesford
2020-11-24 19:49 ` ndowens
2020-11-24 19:50 ` [PR PATCH] [Updated] " ndowens
2020-11-24 19:56 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).