* [PR PATCH] pinebookpro-base: fix udev rules
@ 2020-12-02 2:44 CameronNemo
2020-12-02 3:23 ` [PR REVIEW] " ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: CameronNemo @ 2020-12-02 2:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
There is a new pull request by CameronNemo against master on the void-packages repository
https://github.com/CameronNemo/void-packages pbp-base
https://github.com/void-linux/void-packages/pull/26880
pinebookpro-base: fix udev rules
None
A patch file from https://github.com/void-linux/void-packages/pull/26880.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pbp-base-26880.patch --]
[-- Type: text/x-diff, Size: 1368 bytes --]
From 7d9724dcc48fdfdde93b1b60743b7bad53174b22 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Tue, 1 Dec 2020 18:43:51 -0800
Subject: [PATCH] pinebookpro-base: fix udev rules
---
srcpkgs/pinebookpro-base/files/60-pinebookpro.rules | 2 +-
srcpkgs/pinebookpro-base/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules b/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
index 63d3e9ea21f..182ae2a28cd 100644
--- a/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
+++ b/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
@@ -1,7 +1,7 @@
ACTION=="remove", GOTO="pinebookpro_end"
KERNEL!="event*", GOTO="pinebookpro_end"
-ENV{idVendor}=="258a", ENV{idProduct}=="001e", ENV{ID_INPUT_KEYBOARD}=="1", \
+ATTR{idVendor}=="258a", ATTR{idProduct}=="001e", ENV{ID_INPUT_KEYBOARD}=="1", \
IMPORT{builtin}="hwdb 'pinebookpro:keyboard'", RUN{builtin}+="keyboard"
LABEL="pinebookpro_end"
diff --git a/srcpkgs/pinebookpro-base/template b/srcpkgs/pinebookpro-base/template
index fce0a329b98..a43345eaafa 100644
--- a/srcpkgs/pinebookpro-base/template
+++ b/srcpkgs/pinebookpro-base/template
@@ -1,6 +1,6 @@
# Template file for 'pinebookpro-base'
pkgname=pinebookpro-base
-version=0.3
+version=0.4
revision=1
archs="aarch64*"
build_style=meta
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] pinebookpro-base: fix udev rules
2020-12-02 2:44 [PR PATCH] pinebookpro-base: fix udev rules CameronNemo
@ 2020-12-02 3:23 ` ericonr
2020-12-02 5:22 ` CameronNemo
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-12-02 3:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26880#discussion_r533870901
Comment:
I see `ATTRS` in most of my local rules...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] pinebookpro-base: fix udev rules
2020-12-02 2:44 [PR PATCH] pinebookpro-base: fix udev rules CameronNemo
2020-12-02 3:23 ` [PR REVIEW] " ericonr
@ 2020-12-02 5:22 ` CameronNemo
2020-12-02 5:23 ` [PR PATCH] [Updated] " CameronNemo
2020-12-02 5:34 ` [PR PATCH] [Merged]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: CameronNemo @ 2020-12-02 5:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New review comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/26880#discussion_r533903925
Comment:
crap thanks for checking that
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] pinebookpro-base: fix udev rules
2020-12-02 2:44 [PR PATCH] pinebookpro-base: fix udev rules CameronNemo
2020-12-02 3:23 ` [PR REVIEW] " ericonr
2020-12-02 5:22 ` CameronNemo
@ 2020-12-02 5:23 ` CameronNemo
2020-12-02 5:34 ` [PR PATCH] [Merged]: " ericonr
3 siblings, 0 replies; 5+ messages in thread
From: CameronNemo @ 2020-12-02 5:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
There is an updated pull request by CameronNemo against master on the void-packages repository
https://github.com/CameronNemo/void-packages pbp-base
https://github.com/void-linux/void-packages/pull/26880
pinebookpro-base: fix udev rules
None
A patch file from https://github.com/void-linux/void-packages/pull/26880.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pbp-base-26880.patch --]
[-- Type: text/x-diff, Size: 1370 bytes --]
From ba8cb750ca8c456db3c27d31c9ed5297321672b8 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Tue, 1 Dec 2020 18:43:51 -0800
Subject: [PATCH] pinebookpro-base: fix udev rules
---
srcpkgs/pinebookpro-base/files/60-pinebookpro.rules | 2 +-
srcpkgs/pinebookpro-base/template | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules b/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
index 63d3e9ea21f..6bece04c214 100644
--- a/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
+++ b/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
@@ -1,7 +1,7 @@
ACTION=="remove", GOTO="pinebookpro_end"
KERNEL!="event*", GOTO="pinebookpro_end"
-ENV{idVendor}=="258a", ENV{idProduct}=="001e", ENV{ID_INPUT_KEYBOARD}=="1", \
+ATTRS{idVendor}=="258a", ATTRS{idProduct}=="001e", ENV{ID_INPUT_KEYBOARD}=="1", \
IMPORT{builtin}="hwdb 'pinebookpro:keyboard'", RUN{builtin}+="keyboard"
LABEL="pinebookpro_end"
diff --git a/srcpkgs/pinebookpro-base/template b/srcpkgs/pinebookpro-base/template
index fce0a329b98..a43345eaafa 100644
--- a/srcpkgs/pinebookpro-base/template
+++ b/srcpkgs/pinebookpro-base/template
@@ -1,6 +1,6 @@
# Template file for 'pinebookpro-base'
pkgname=pinebookpro-base
-version=0.3
+version=0.4
revision=1
archs="aarch64*"
build_style=meta
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: pinebookpro-base: fix udev rules
2020-12-02 2:44 [PR PATCH] pinebookpro-base: fix udev rules CameronNemo
` (2 preceding siblings ...)
2020-12-02 5:23 ` [PR PATCH] [Updated] " CameronNemo
@ 2020-12-02 5:34 ` ericonr
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-12-02 5:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
There's a merged pull request on the void-packages repository
pinebookpro-base: fix udev rules
https://github.com/void-linux/void-packages/pull/26880
Description:
None
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-02 5:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 2:44 [PR PATCH] pinebookpro-base: fix udev rules CameronNemo
2020-12-02 3:23 ` [PR REVIEW] " ericonr
2020-12-02 5:22 ` CameronNemo
2020-12-02 5:23 ` [PR PATCH] [Updated] " CameronNemo
2020-12-02 5:34 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).