Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] redo: fix package configuration (typo)
@ 2020-12-12 12:58 sirikid
  2020-12-12 13:03 ` ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: sirikid @ 2020-12-12 12:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

There is a new pull request by sirikid against master on the void-packages repository

https://github.com/sirikid/void-packages redo/fix-configure
https://github.com/void-linux/void-packages/pull/27110

redo: fix package configuration (typo)


A patch file from https://github.com/void-linux/void-packages/pull/27110.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-redo/fix-configure-27110.patch --]
[-- Type: text/x-diff, Size: 877 bytes --]

From f63cc18f115026fc5c83e8230d29f7b9d1975f5e Mon Sep 17 00:00:00 2001
From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
Date: Sat, 12 Dec 2020 15:54:41 +0300
Subject: [PATCH] redo: fix package configuration (typo)

---
 srcpkgs/redo/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/redo/template b/srcpkgs/redo/template
index 7ff8783fa0a..12ff84c893a 100644
--- a/srcpkgs/redo/template
+++ b/srcpkgs/redo/template
@@ -1,7 +1,7 @@
 # Template file for 'redo'
 pkgname=redo
 version=1.5
-revision=1
+revision=2
 create_wrksrc=yes
 hostmakedepends="perl"
 short_desc="Incremental build system (version of de Boyne Pollard)"
@@ -15,7 +15,7 @@ do_configure() {
 	./package/prepare
 
 	echo "$CXX" >build/cxx
-	echo "$CPPFLAGS" >build/cxxflags
+	echo "$CPPFLAGS" >build/cppflags
 	echo "$CXXFLAGS" >build/cxxflags
 	echo "$LDFLAGS" >build/ldflags
 }

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: redo: fix package configuration (typo)
  2020-12-12 12:58 [PR PATCH] redo: fix package configuration (typo) sirikid
@ 2020-12-12 13:03 ` ericonr
  2020-12-12 13:17 ` sirikid
  2020-12-12 13:43 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2020-12-12 13:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27110#issuecomment-743753109

Comment:
Did you spot any issue caused by this or is it mostly just a fix for correctness?

Hmm, I guess it might miss `_FORTIFY_SOURCE` on glibc.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: redo: fix package configuration (typo)
  2020-12-12 12:58 [PR PATCH] redo: fix package configuration (typo) sirikid
  2020-12-12 13:03 ` ericonr
@ 2020-12-12 13:17 ` sirikid
  2020-12-12 13:43 ` [PR PATCH] [Merged]: " ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: sirikid @ 2020-12-12 13:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by sirikid on void-packages repository

https://github.com/void-linux/void-packages/pull/27110#issuecomment-743755006

Comment:
> Did you spot any issue caused by this or is it mostly just a fix for correctness?

No.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Merged]: redo: fix package configuration (typo)
  2020-12-12 12:58 [PR PATCH] redo: fix package configuration (typo) sirikid
  2020-12-12 13:03 ` ericonr
  2020-12-12 13:17 ` sirikid
@ 2020-12-12 13:43 ` ericonr
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2020-12-12 13:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

There's a merged pull request on the void-packages repository

redo: fix package configuration (typo)
https://github.com/void-linux/void-packages/pull/27110

Description:


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-12 13:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-12 12:58 [PR PATCH] redo: fix package configuration (typo) sirikid
2020-12-12 13:03 ` ericonr
2020-12-12 13:17 ` sirikid
2020-12-12 13:43 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).