[PR PATCH] claws-mail: unmark noross

[PR PATCH] claws-mail: unmark noross

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

There is a new pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages claws
https://github.com/void-linux/void-packages/pull/27158

claws-mail: unmark noross


A patch file from https://github.com/void-linux/void-packages/pull/27158.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-claws-27158.patch --]
[-- Type: text/x-diff, Size: 1129 bytes --]

From 07663e47ef872e456a486621b2743c9c2d656b03 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 14 Dec 2020 15:17:46 -0600
Subject: [PATCH] claws-mail: unmark noross

---
 srcpkgs/claws-mail/template | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/srcpkgs/claws-mail/template b/srcpkgs/claws-mail/template
index 852457a93c0..12b30963b7c 100644
--- a/srcpkgs/claws-mail/template
+++ b/srcpkgs/claws-mail/template
@@ -18,14 +18,6 @@ license="GPL-3.0-or-later"
 homepage="https://claws-mail.org"
 distfiles="https://www.claws-mail.org/download.php?file=releases/claws-mail-${version}.tar.xz"
 checksum=cdb7b2814995d6f4a9c3b1f0bc1467ed5c3cf2a5e0da1730aaa25a8accafddaf
-nocross=yes
-
-# TODO(dominikh): claws-mail is a mess. If we don't have python
-# installed at all, the build process will fail, even if we don't want
-# the python plugin. If we do have python installed, cross-compilation
-# fails. It's probably possible to fix the configure script to
-# cross-compile properly, but it's not worth the trouble. To me,
-# anyway.
 
 claws-mail-devel_package() {
 	depends="${makedepends}"

Re: claws-mail: unmark noross

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27158#issuecomment-745310956

Comment:
I wonder what changed

Re: claws-mail: unmark noross

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27158#issuecomment-745311367

Comment:
Did you confirm the binaries were for the correct arch? 

Re: claws-mail: unmark noross

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27158#issuecomment-745374827

Comment:
> Did you confirm the binaries were for the correct arch?

Looks like it is using the cc related to the arch

Re: claws-mail: unmark noross

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27158#issuecomment-745376452

Comment:
Ah, please fix typo in the commit title: `noross`

Re: [PR PATCH] [Updated] claws-mail: unmark noross

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is an updated pull request by ndowens against master on the void-packages repository

https://github.com/ndowens/void-packages claws
https://github.com/void-linux/void-packages/pull/27158

claws-mail: unmark noross


A patch file from https://github.com/void-linux/void-packages/pull/27158.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-claws-27158.patch --]
[-- Type: text/x-diff, Size: 1130 bytes --]

From 66ed8d552db1bbc93cfaa5e33cab6b503889c9f9 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Mon, 14 Dec 2020 15:17:46 -0600
Subject: [PATCH] claws-mail: unmark nocross

---
 srcpkgs/claws-mail/template | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/srcpkgs/claws-mail/template b/srcpkgs/claws-mail/template
index 852457a93c0..12b30963b7c 100644
--- a/srcpkgs/claws-mail/template
+++ b/srcpkgs/claws-mail/template
@@ -18,14 +18,6 @@ license="GPL-3.0-or-later"
 homepage="https://claws-mail.org"
 distfiles="https://www.claws-mail.org/download.php?file=releases/claws-mail-${version}.tar.xz"
 checksum=cdb7b2814995d6f4a9c3b1f0bc1467ed5c3cf2a5e0da1730aaa25a8accafddaf
-nocross=yes
-
-# TODO(dominikh): claws-mail is a mess. If we don't have python
-# installed at all, the build process will fail, even if we don't want
-# the python plugin. If we do have python installed, cross-compilation
-# fails. It's probably possible to fix the configure script to
-# cross-compile properly, but it's not worth the trouble. To me,
-# anyway.
 
 claws-mail-devel_package() {
 	depends="${makedepends}"

Re: claws-mail: unmark noross

[ndowens]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by ndowens on void-packages repository

https://github.com/void-linux/void-packages/pull/27158#issuecomment-745379103

Comment:
> Ah, please fix typo in the commit title: `noross`

Done

Re: [PR PATCH] [Merged]: claws-mail: unmark noross

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

There's a merged pull request on the void-packages repository

claws-mail: unmark noross
https://github.com/void-linux/void-packages/pull/27158

Description: