[PR PATCH] New package: ungoogled-chromium-67.0.3396.87-1

[PR PATCH] New package: ungoogled-chromium-67.0.3396.87-1

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

There is a new pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ungoogled-chromium
https://github.com/void-linux/void-packages/pull/27163

New package: ungoogled-chromium-67.0.3396.87-1
# Current issues
* Durring the `do_build()` process, the command `./build/src/build/linux/sysroot_scripts/install-sysroot.py --arch=amd64` is returning (on my local test build):
```
Installing Debian sid amd64 root image: /home/amber/.local/src/ungoogled-chromium/build/src/build/linux/debian_sid_amd64-sysroot
Downloading https://commondatastorage.9oo91eapis.qjz9zk/chrome-linux-sysroot/toolchain/5f64b417e1018dcf8fcc81dc2714e0f264b9b911/debian_sid_amd64_sysroot.tar.xz
Failed to download https://commondatastorage.9oo91eapis.qjz9zk/chrome-linux-sysroot/toolchain/5f64b417e1018dcf8fcc81dc2714e0f264b9b911/debian_sid_amd64_sysroot.tar.xz
```

A patch file from https://github.com/void-linux/void-packages/pull/27163.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ungoogled-chromium-27163.patch --]
[-- Type: text/x-diff, Size: 2546 bytes --]

From c0a79903f25172ef8177f286c0a0689b2746f7ce Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Mon, 14 Dec 2020 14:56:23 -0700
Subject: [PATCH] New package: ungoogled-chromium-67.0.3396.87-1

---
 srcpkgs/ungoogled-chromium/template | 45 +++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 srcpkgs/ungoogled-chromium/template

diff --git a/srcpkgs/ungoogled-chromium/template b/srcpkgs/ungoogled-chromium/template
new file mode 100644
index 00000000000..8878a42dc84
--- /dev/null
+++ b/srcpkgs/ungoogled-chromium/template
@@ -0,0 +1,45 @@
+# Template file for 'ungoogled-chromium'
+pkgname=ungoogled-chromium
+version=67.0.3396.87-1
+revision=1
+short_desc="A lightweight approach to removing Google web service dependency"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/Eloston/ungoogled-chromium"
+distfiles="https://github.com/Eloston/ungoogled-chromium/archive/${version}.tar.gz"
+checksum=3c589087e163aa67a899b7f21b9a658ffed5e5944127b97028f183d677a81233
+
+hostmakedepends="python ninja clang"
+depends="libexif hwids desktop-file-utils hicolor-icon-theme xdg-utils"
+
+# Instructions from https://github.com/Eloston/ungoogled-chromium/blob/master/docs/building.md
+do_configure() {
+	# Ensure Chromium is downloaded
+	mkdir -p build/download_cache
+	./utils/downloads.py retrieve -c build/download_cache -i downloads.ini
+	./utils/downloads.py unpack -c build/download_cache -i downloads.ini -- build/src
+	# Prune binaries
+	./utils/prune_binaries.py build/src pruning.list
+	# Apply patches
+	./utils/patches.py apply build/src patches
+	# Substitute domains
+	./utils/domain_substitution.py apply -r domain_regex.list -f domain_substitution.list -c build/domsubcache.tar.gz build/src
+	# Build GN
+	mkdir -p build/src/out/Default
+	./build/src/tools/gn/bootstrap/bootstrap.py --skip-generate-buildfiles -j4 -o build/src/out/Default/
+}
+
+do_build() {
+	# mkdir -p build/src/out/Default
+	# NOTE: flags.gn contains only a subset of what is needed to run the build.
+	cp flags.gn build/src/out/Default/args.gn
+	# FIXME The below command is failing to download needed arch
+	./build/src/build/linux/sysroot_scripts/install-sysroot.py --arch=amd64
+	./build/src/out/Default/gn gen build/src/out/Default --fail-on-unused-args
+	ninja -C build/src/out/Default chrome chromedriver chrome_sandbox
+}
+
+do_install() {
+	vinstall build/src/out/Default/chrome 755 usr/lib/${pkgname} ${pkgname}
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: ungoogled-chromium-67.0.3396.87-1

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

There is an updated pull request by kawaiiamber against master on the void-packages repository

https://github.com/kawaiiamber/void-packages ungoogled-chromium
https://github.com/void-linux/void-packages/pull/27163

New package: ungoogled-chromium-67.0.3396.87-1
# Current issues
* Durring the `do_build()` process, the command `./build/src/build/linux/sysroot_scripts/install-sysroot.py --arch=amd64` is returning (on my local test build):
```
Installing Debian sid amd64 root image: /home/amber/.local/src/ungoogled-chromium/build/src/build/linux/debian_sid_amd64-sysroot
Downloading https://commondatastorage.9oo91eapis.qjz9zk/chrome-linux-sysroot/toolchain/5f64b417e1018dcf8fcc81dc2714e0f264b9b911/debian_sid_amd64_sysroot.tar.xz
Failed to download https://commondatastorage.9oo91eapis.qjz9zk/chrome-linux-sysroot/toolchain/5f64b417e1018dcf8fcc81dc2714e0f264b9b911/debian_sid_amd64_sysroot.tar.xz
```

A patch file from https://github.com/void-linux/void-packages/pull/27163.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ungoogled-chromium-27163.patch --]
[-- Type: text/x-diff, Size: 2591 bytes --]

From c04d61d9fe56d0a98358df6c7ae84a43d2cd613e Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Mon, 14 Dec 2020 14:56:23 -0700
Subject: [PATCH] New package: ungoogled-chromium-67.0.3396.87-1

New package: ungoogled-chromium-67.0.3396.87-1
---
 srcpkgs/ungoogled-chromium/template | 45 +++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 srcpkgs/ungoogled-chromium/template

diff --git a/srcpkgs/ungoogled-chromium/template b/srcpkgs/ungoogled-chromium/template
new file mode 100644
index 00000000000..62df109de1f
--- /dev/null
+++ b/srcpkgs/ungoogled-chromium/template
@@ -0,0 +1,45 @@
+# Template file for 'ungoogled-chromium'
+pkgname=ungoogled-chromium
+version=67.0.3396.87
+revision=1
+short_desc="Lightweight approach to removing Google web service dependency"
+maintainer="KawaiiAmber <japaneselearning101@gmail.com>"
+license="BSD-3-Clause"
+homepage="https://github.com/Eloston/ungoogled-chromium"
+distfiles="https://github.com/Eloston/ungoogled-chromium/archive/${version}-1.tar.gz"
+checksum=3c589087e163aa67a899b7f21b9a658ffed5e5944127b97028f183d677a81233
+
+hostmakedepends="python ninja clang"
+depends="libexif hwids desktop-file-utils hicolor-icon-theme xdg-utils"
+
+# Instructions from https://github.com/Eloston/ungoogled-chromium/blob/master/docs/building.md
+do_configure() {
+	# Ensure Chromium is downloaded
+	mkdir -p build/download_cache
+	./utils/downloads.py retrieve -c build/download_cache -i downloads.ini
+	./utils/downloads.py unpack -c build/download_cache -i downloads.ini -- build/src
+	# Prune binaries
+	./utils/prune_binaries.py build/src pruning.list
+	# Apply patches
+	./utils/patches.py apply build/src patches
+	# Substitute domains
+	./utils/domain_substitution.py apply -r domain_regex.list -f domain_substitution.list -c build/domsubcache.tar.gz build/src
+	# Build GN
+	mkdir -p build/src/out/Default
+	./build/src/tools/gn/bootstrap/bootstrap.py --skip-generate-buildfiles -j4 -o build/src/out/Default/
+}
+
+do_build() {
+	# mkdir -p build/src/out/Default
+	# NOTE: flags.gn contains only a subset of what is needed to run the build.
+	cp flags.gn build/src/out/Default/args.gn
+	# FIXME The below command is failing to download needed arch
+	./build/src/build/linux/sysroot_scripts/install-sysroot.py --arch=amd64
+	./build/src/out/Default/gn gen build/src/out/Default --fail-on-unused-args
+	ninja -C build/src/out/Default chrome chromedriver chrome_sandbox
+}
+
+do_install() {
+	vinstall build/src/out/Default/chrome 755 usr/lib/${pkgname} ${pkgname}
+	vlicense LICENSE
+}

Re: New package: ungoogled-chromium-67.0.3396.87-1

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/27163#issuecomment-744743757

Comment:
So ignoring for a moment the moratorium on any more chromium or firefox based browsers, this is almost 2 years out of date and the template isn't anywhere near correct (see the chromium template for things missing from this one).

Fails the quality bar for inclusion on grounds of being a security liability for anyone who installs it, and that Void is not accepting new chromium or firefox derived browsers at this time.

Re: [PR PATCH] [Closed]: New package: ungoogled-chromium-67.0.3396.87-1

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

There's a closed pull request on the void-packages repository

New package: ungoogled-chromium-67.0.3396.87-1
https://github.com/void-linux/void-packages/pull/27163

Description:
# Current issues
* Durring the `do_build()` process, the command `./build/src/build/linux/sysroot_scripts/install-sysroot.py --arch=amd64` is returning (on my local test build):
```
Installing Debian sid amd64 root image: /home/amber/.local/src/ungoogled-chromium/build/src/build/linux/debian_sid_amd64-sysroot
Downloading https://commondatastorage.9oo91eapis.qjz9zk/chrome-linux-sysroot/toolchain/5f64b417e1018dcf8fcc81dc2714e0f264b9b911/debian_sid_amd64_sysroot.tar.xz
Failed to download https://commondatastorage.9oo91eapis.qjz9zk/chrome-linux-sysroot/toolchain/5f64b417e1018dcf8fcc81dc2714e0f264b9b911/debian_sid_amd64_sysroot.tar.xz
```

Re: New package: ungoogled-chromium-67.0.3396.87-1

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/27163#issuecomment-744748630

Comment:
I see, I didn't know that Void wasn't taking new browsers, sorry.

Re: New package: ungoogled-chromium-67.0.3396.87-1

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/27163#issuecomment-744752462

Comment:
NP, I think its not as well posted as it could be, just wanted to make sure you were aware before you invested significant time efforts.

Re: New package: ungoogled-chromium-67.0.3396.87-1

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/27163#issuecomment-744755673

Comment:
I see, thank you very much. I'll be sure to read more of what is currently being accepted. I saw there was no PR for ungoogle-chromium and thought I'd PR it. I'm sorry about that.

Re: New package: ungoogled-chromium-67.0.3396.87-1

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/27163#issuecomment-744756187

Comment:
no need for apologies.  if you hadn't opened the ticket you wouldn't have gained the knowledge you now have!