[PR PATCH] apvlv: update to 0.2.0

[PR PATCH] apvlv: update to 0.2.0

[logenkain]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There is a new pull request by logenkain against master on the void-packages repository

https://github.com/logenkain/void-packages apvlv-0.2.0
https://github.com/void-linux/void-packages/pull/27312

apvlv: update to 0.2.0


A patch file from https://github.com/void-linux/void-packages/pull/27312.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-apvlv-0.2.0-27312.patch --]
[-- Type: text/x-diff, Size: 3664 bytes --]

From 87c06ec08887d3398c517d5ce54602de41b65768 Mon Sep 17 00:00:00 2001
From: logen <logen@plagsup.attlocal.net>
Date: Sun, 20 Dec 2020 15:12:49 -0500
Subject: [PATCH] apvlv: update to 0.2.0

---
 .../fix-build-with-poppler-0.73.0.patch       | 11 ---------
 srcpkgs/apvlv/patches/fix-gcc6-getline.patch  | 11 ---------
 srcpkgs/apvlv/patches/fix-gcc7-ftbfs.patch    | 23 -------------------
 srcpkgs/apvlv/template                        | 10 ++++----
 4 files changed, 5 insertions(+), 50 deletions(-)
 delete mode 100644 srcpkgs/apvlv/patches/fix-build-with-poppler-0.73.0.patch
 delete mode 100644 srcpkgs/apvlv/patches/fix-gcc6-getline.patch
 delete mode 100644 srcpkgs/apvlv/patches/fix-gcc7-ftbfs.patch

diff --git a/srcpkgs/apvlv/patches/fix-build-with-poppler-0.73.0.patch b/srcpkgs/apvlv/patches/fix-build-with-poppler-0.73.0.patch
deleted file mode 100644
index 773a297ceaa..00000000000
--- a/srcpkgs/apvlv/patches/fix-build-with-poppler-0.73.0.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- src/ApvlvPdf.cc
-+++ src/ApvlvPdf.cc
-@@ -29,7 +29,7 @@
- #include "ApvlvPdf.h"
-
- #ifndef POPPLER_WITH_GDK
--#include <goo/gtypes.h>
-+#include <goo/gfile.h>
-
- static void
- copy_cairo_surface_to_pixbuf (cairo_surface_t *surface,
diff --git a/srcpkgs/apvlv/patches/fix-gcc6-getline.patch b/srcpkgs/apvlv/patches/fix-gcc6-getline.patch
deleted file mode 100644
index 66dae781332..00000000000
--- a/srcpkgs/apvlv/patches/fix-gcc6-getline.patch
+++ /dev/null
@@ -1,11 +0,0 @@
---- src/ApvlvParams.cc	2015-01-10 15:04:24.000000000 +0100
-+++ src/ApvlvParams.cc	2016-10-04 00:06:58.187468048 +0200
-@@ -90,7 +90,7 @@
- 	return false;
-       }
- 
--    while ((getline (os, str)) != NULL)
-+    while (getline (os, str))
-       {
- 	string argu, data, crap;
- 	stringstream is (str);
diff --git a/srcpkgs/apvlv/patches/fix-gcc7-ftbfs.patch b/srcpkgs/apvlv/patches/fix-gcc7-ftbfs.patch
deleted file mode 100644
index 464ea258368..00000000000
--- a/srcpkgs/apvlv/patches/fix-gcc7-ftbfs.patch
+++ /dev/null
@@ -1,23 +0,0 @@
---- src/ApvlvCmds.cc
-+++ src/ApvlvCmds.cc
-@@ -200,7 +200,7 @@ namespace apvlv
- 
-     if (len >= 4
- 	&& *s == '<'
--	&& (e = strchr ((char *) s, '>')) != '\0' && *(s + 2) != '-')
-+	&& (e = strchr ((char *) s, '>')) && *(s + 2) != '-')
-       {
- 	e++;
- 	StringKeyMap::iterator it;
---- src/ApvlvCore.cc
-+++ src/ApvlvCore.cc
-@@ -90,7 +90,7 @@ namespace apvlv
-   {
-     mInuse = use;
- 
--    if (mInuse == false && gView->hasloaded (filename (), type ()) == false)
-+    if (mInuse == false && !gView->hasloaded (filename (), type ()))
-       {
- 	debug ("core :%p is not needed, delete it\n", this);
- 	delete this;
-
diff --git a/srcpkgs/apvlv/template b/srcpkgs/apvlv/template
index 9fd8927487c..8d343dbe335 100644
--- a/srcpkgs/apvlv/template
+++ b/srcpkgs/apvlv/template
@@ -1,16 +1,16 @@
 # Template file for 'apvlv'
 pkgname=apvlv
-version=0.1.5
-revision=8
+version=0.2.0
+revision=1
 build_style=cmake
 configure_args="-DAPVLV_WITH_UMD=no -DAPVLV_WITH_DJVU=yes -DAPVLV_WITH_TXT=yes"
 hostmakedepends="pkg-config"
-makedepends="gtk+3-devel poppler-glib-devel djvulibre-devel"
+makedepends="gtk+3-devel poppler-glib-devel djvulibre-devel webkit2gtk-devel ebook-tools-devel"
 depends="desktop-file-utils"
 short_desc="Vim-like PDF/DJVU/TXT viewer"
 maintainer="Logen K <logen@sudotask.com>"
-license="GPL-2"
+license="GPL-2.0-only"
 homepage="http://naihe2010.github.io/apvlv/"
 distfiles="https://github.com/naihe2010/apvlv/archive/v${version}.tar.gz"
-checksum=dca98157e63c9fec12d6514751ea26549813dc7b87d838b0003f31a444100a8a
+checksum=a4a2f42a7e42715a21d2356def3ed93c180c6ae41128580addee42835e5374c2
 replaces="apvlv-git>=0"

Re: apvlv: update to 0.2.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27312#issuecomment-748670372

Comment:
Your PR is good, but gtk+3-devel dependencies are wonky right now. I will merge when I have managed to solve them.

Re: [PR PATCH] [Merged]: apvlv: update to 0.2.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

There's a merged pull request on the void-packages repository

apvlv: update to 0.2.0
https://github.com/void-linux/void-packages/pull/27312

Description:

Re: apvlv: update to 0.2.0

[D-Nice]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New comment by D-Nice on void-packages repository

https://github.com/void-linux/void-packages/pull/27312#issuecomment-749280558

Comment:
damn, this would install 21 new dependencies... some undesirables with various recent CVEs. I'll either hold or rm apvlv

Re: apvlv: update to 0.2.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27312#issuecomment-749290254

Comment:
@D-Nice could you point out the dependencies with issues? Possibly make PRs to update them.

Re: apvlv: update to 0.2.0

[D-Nice]

[-- Attachment #1: Type: text/plain, Size: 3248 bytes --]

New comment by D-Nice on void-packages repository

https://github.com/void-linux/void-packages/pull/27312#issuecomment-749759377

Comment:
@ericonr There's none necessarily with active CVEs, I'm just surprised if a major version change, really requires 21 dependencies compared to the last, in which case I mentioned what the best solution for me would be then, probably hold for a bit and remove it.

For posterity, here are all the new dependencies the apparent update from apvlv  0.1.5_8  to 0.2.0_1 requires:
```
bubblewrap                install   -                 0.4.1_2                29KB 
xdg-dbus-proxy            install   -                 0.1.2_1                20KB 
gsettings-desktop-schemas install   -                 3.38.0_1               710KB 
libproxy                  install   -                 0.4.15_1               - 
glib-networking           install   -                 2.66.0_1               127KB 
libpsl                    install   -                 0.21.1_1               60KB 
brotli                    install   -                 1.0.9_2                384KB 
libsoup                   install   -                 2.72.0_1               334KB 
libwoff2common1.0.2       install   -                 1.0.2_1                4072B 
libwoff2dec1.0.2          install   -                 1.0.2_1                19KB 
gstreamer1                install   -                 1.16.2_1               1131KB 
libcdparanoia             install   -                 10.2_14                39KB 
libvisual                 install   -                 0.4.0_9                - 
graphene                  install   -                 1.10.2_1               58KB 
gst-plugins-base1         install   -                 1.16.2_2               2141KB 
libhunspell1.7            install   -                 1.7.0_2                133KB 
enchant                   install   -                 1.6.0_8                30KB 
hyphen                    install   -                 2.8.8_2                49KB 
webkit2gtk                install   -                 2.30.4_1               24MB 
libzip                    install   -                 1.7.3_1                82KB 
ebook-tools               install   -                 0.2.2_3                21KB 
```

And there's a bunch here with a history of CVEs, which isn't worth having on my system for a single app, just as a personal philosophy and security practice:

https://www.cvedetails.com/vulnerability-list/vendor_id-283/product_id-16275/Gnome-Glib.html
https://www.cvedetails.com/vulnerability-list/vendor_id-283/product_id-21096/Gnome-Libsoup.html
https://www.cvedetails.com/vulnerability-list/vendor_id-9481/Gstreamer.html
https://www.cvedetails.com/vulnerability-list/vendor_id-11350/Webkitgtk.html

I am a user for the underlying minimalism potential the distro (void) provides, albeit I understand the current direction isn't necessarily one of minimalism, but I think it would be a preferred practice to not just pull in a whole bunch of dependencies unless strictly necessary, which I am not aware if that is or isn't the case here. If it in fact is, then I just need to find a more minimalist alternative to apvlv, and end of discussion.

Re: apvlv: update to 0.2.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/27312#issuecomment-749761062

Comment:
You pulled in `webkit2gtk` into your package, these are dependencies for that.

Re: apvlv: update to 0.2.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/27312#issuecomment-749763316

Comment:
@D-Nice if you'd like to add a build option that removes the webkit2gtk dependency, feel free to do so and make a PR for it. Otherwise the package will probably keep its dependencies.

Re: apvlv: update to 0.2.0

[D-Nice]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New comment by D-Nice on void-packages repository

https://github.com/void-linux/void-packages/pull/27312#issuecomment-749787969

Comment:
@ericonr got it, thanks, I'll consider it depending on the importance of the package, and if it's possible in the first place, was just wondering if this was already considered or explored already.