From: vixus0 <vixus0@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [ISSUE] go packages may have mismatched package names
Date: Tue, 05 Jan 2021 16:38:30 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27690@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
New issue by vixus0 on void-packages repository
https://github.com/void-linux/void-packages/issues/27690
Description:
### Problem
When using the `build_style=go`, package templates may be using a `go_import_path=` that does not match the name of the go package. This could be because the package name changed in the upstream source. The result is a seemingly correct package that was actually built from very old sources thanks to the way go works. I suspect this is mainly likely to happen with go sources that make use of go modules but as that becomes more standard it might become more likely.
For an example, see #27688.
### Mitigations
- Linting: when `go.mod` is present, check that `go_import_path=` is set to the name defined there.
- `build-style/go.sh`: (better, imo) set the value of `go_import_path=` to the module name defined in `go.mod`.
next reply other threads:[~2021-01-05 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 15:38 vixus0 [this message]
2021-02-18 19:32 ` ericonr
2022-05-02 2:15 ` github-actions
2022-05-03 12:50 ` vixus0
2023-06-26 4:55 ` [ISSUE] [CLOSED] " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27690@inbox.vuxu.org \
--to=vixus0@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).